From: Sameer Pujar <spujar@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <broonie@kernel.org>, <robh+dt@kernel.org>,
<jonathanh@nvidia.com>, <kuninori.morimoto.gx@renesas.com>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sharadg@nvidia.com>
Subject: Re: Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210
Date: Tue, 19 Jan 2021 23:09:32 +0530 [thread overview]
Message-ID: <b83eb795-328e-acc5-4555-7befd919a136@nvidia.com> (raw)
In-Reply-To: <YAcTxxyogVgfN1uw@ulmo>
On 1/19/2021 10:45 PM, Thierry Reding wrote:
> On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote:
>> Expose a header which describes DT bindings required to use audio-graph
>> based sound card. All Tegra210 based platforms can include this header
>> and add platform specific information. Currently, from SoC point of view,
>> all links are exposed for ADMAIF, AHUB, I2S and DMIC components.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 +++++++++++++++++++++
>> 1 file changed, 153 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi
> I prefer keeping everything in tegra210.dtsi, but I can do that merge
> when I apply, after the DT bindings have been acked, so no need to
> resend just because of that.
I think this may be fine for Tegra210 based boards. But for Tegra186 and
Tegra194, whenever we add support for it, can rely on a common
audio-graph dtsi because there is no change w.r.t APE. This can help us
to avoid duplication of the bindings. This most likely applies to future
chips as well (where Tegra186 audio-graph bindings can be considered as
base) when there is no significant change in APE.
WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, jonathanh@nvidia.com, sharadg@nvidia.com,
broonie@kernel.org, linux-tegra@vger.kernel.org
Subject: Re: Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210
Date: Tue, 19 Jan 2021 23:09:32 +0530 [thread overview]
Message-ID: <b83eb795-328e-acc5-4555-7befd919a136@nvidia.com> (raw)
In-Reply-To: <YAcTxxyogVgfN1uw@ulmo>
On 1/19/2021 10:45 PM, Thierry Reding wrote:
> On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote:
>> Expose a header which describes DT bindings required to use audio-graph
>> based sound card. All Tegra210 based platforms can include this header
>> and add platform specific information. Currently, from SoC point of view,
>> all links are exposed for ADMAIF, AHUB, I2S and DMIC components.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 +++++++++++++++++++++
>> 1 file changed, 153 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi
> I prefer keeping everything in tegra210.dtsi, but I can do that merge
> when I apply, after the DT bindings have been acked, so no need to
> resend just because of that.
I think this may be fine for Tegra210 based boards. But for Tegra186 and
Tegra194, whenever we add support for it, can rely on a common
audio-graph dtsi because there is no change w.r.t APE. This can help us
to avoid duplication of the bindings. This most likely applies to future
chips as well (where Tegra186 audio-graph bindings can be considered as
base) when there is no significant change in APE.
next prev parent reply other threads:[~2021-01-19 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 9:28 [RESEND PATCH v6 0/6] Tegra210 audio graph card Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-19 9:28 ` [RESEND PATCH v6 1/6] ASoC: dt-bindings: tegra: Add graph bindings Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-19 9:28 ` [RESEND PATCH v6 2/6] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-19 9:28 ` [RESEND PATCH v6 3/6] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-19 9:28 ` [RESEND PATCH v6 4/6] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-21 18:59 ` Thierry Reding
2021-01-21 18:59 ` Thierry Reding
2021-01-19 9:28 ` [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-19 17:15 ` Thierry Reding
2021-01-19 17:15 ` Thierry Reding
2021-01-19 17:39 ` Sameer Pujar [this message]
2021-01-19 17:39 ` Sameer Pujar
2021-01-19 17:57 ` Thierry Reding
2021-01-19 17:57 ` Thierry Reding
2021-01-20 5:06 ` Sameer Pujar
2021-01-20 5:06 ` Sameer Pujar
2021-01-21 19:00 ` Thierry Reding
2021-01-21 19:00 ` Thierry Reding
2021-01-19 9:28 ` [RESEND PATCH v6 6/6] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2021-01-19 9:28 ` Sameer Pujar
2021-01-19 17:17 ` Thierry Reding
2021-01-19 17:17 ` Thierry Reding
2021-01-21 19:00 ` Thierry Reding
2021-01-21 19:00 ` Thierry Reding
2021-01-21 0:05 ` (subset) [RESEND PATCH v6 0/6] Tegra210 audio graph card Mark Brown
2021-01-21 0:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b83eb795-328e-acc5-4555-7befd919a136@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.