From: shuah <shuah@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>, Andy Lutomirski <luto@kernel.org>
Cc: Steve Muckle <smuckle@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests: x86: add version check in test_syscall_vdso
Date: Sat, 2 Mar 2019 11:31:16 -0700 [thread overview]
Message-ID: <b9805f57-5fc8-454e-c1c8-c06dab86e863@kernel.org> (raw)
In-Reply-To: <20190302091047.GA14963@kroah.com>
On 3/2/19 2:10 AM, Greg KH wrote:
> On Fri, Mar 01, 2019 at 11:59:24AM -0800, Andy Lutomirski wrote:
>>> On Feb 28, 2019, at 4:18 PM, Steve Muckle <smuckle@google.com> wrote:
>>>
>>> Since 4.17 registers r8-r11 are not clobbered/zeroed by a 64-bit kernel
>>> handling a 32-bit syscall and this behavior is enforced by the
>>> test_syscall_vdso testcase. See commit 8bb2610bc496
>>> ("x86/entry/64/compat: Preserve r8-r11 in int $0x80").
>>>
>>> Permit the old behavior in the testcase for kernels prior to 4.17.
>>
>> NAK. If you want an old buggy kernel to pass a test, please either
>> patch the kernel or run an old test.
>
> Yeah, this isn't ok, especially as you might have 4.14 or 4.9 kernels
> that can pass the test if the needed patches were backported. Checking
> kernel version numbers should never be used for anything.
>
Also, this test failure can tell us if we should backport important
fixes. I have had requests to add kernel version checking in tests
before and the recommendation is "don't check kernel versions and
reply on feature type checks". In the case of fixes like this one,
it is better for the test to fail than make us feel warm and fuzzy
by making it pass.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (shuah)
Subject: [PATCH] selftests: x86: add version check in test_syscall_vdso
Date: Sat, 2 Mar 2019 11:31:16 -0700 [thread overview]
Message-ID: <b9805f57-5fc8-454e-c1c8-c06dab86e863@kernel.org> (raw)
In-Reply-To: <20190302091047.GA14963@kroah.com>
On 3/2/19 2:10 AM, Greg KH wrote:
> On Fri, Mar 01, 2019 at 11:59:24AM -0800, Andy Lutomirski wrote:
>>> On Feb 28, 2019, at 4:18 PM, Steve Muckle <smuckle at google.com> wrote:
>>>
>>> Since 4.17 registers r8-r11 are not clobbered/zeroed by a 64-bit kernel
>>> handling a 32-bit syscall and this behavior is enforced by the
>>> test_syscall_vdso testcase. See commit 8bb2610bc496
>>> ("x86/entry/64/compat: Preserve r8-r11 in int $0x80").
>>>
>>> Permit the old behavior in the testcase for kernels prior to 4.17.
>>
>> NAK. If you want an old buggy kernel to pass a test, please either
>> patch the kernel or run an old test.
>
> Yeah, this isn't ok, especially as you might have 4.14 or 4.9 kernels
> that can pass the test if the needed patches were backported. Checking
> kernel version numbers should never be used for anything.
>
Also, this test failure can tell us if we should backport important
fixes. I have had requests to add kernel version checking in tests
before and the recommendation is "don't check kernel versions and
reply on feature type checks". In the case of fixes like this one,
it is better for the test to fail than make us feel warm and fuzzy
by making it pass.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (shuah)
Subject: [PATCH] selftests: x86: add version check in test_syscall_vdso
Date: Sat, 2 Mar 2019 11:31:16 -0700 [thread overview]
Message-ID: <b9805f57-5fc8-454e-c1c8-c06dab86e863@kernel.org> (raw)
Message-ID: <20190302183116.FYKA-aQqr-XCDxJttFPDrkYS_Nm2yoGGnX6uRuTMY4Q@z> (raw)
In-Reply-To: <20190302091047.GA14963@kroah.com>
On 3/2/19 2:10 AM, Greg KH wrote:
> On Fri, Mar 01, 2019@11:59:24AM -0800, Andy Lutomirski wrote:
>>> On Feb 28, 2019,@4:18 PM, Steve Muckle <smuckle@google.com> wrote:
>>>
>>> Since 4.17 registers r8-r11 are not clobbered/zeroed by a 64-bit kernel
>>> handling a 32-bit syscall and this behavior is enforced by the
>>> test_syscall_vdso testcase. See commit 8bb2610bc496
>>> ("x86/entry/64/compat: Preserve r8-r11 in int $0x80").
>>>
>>> Permit the old behavior in the testcase for kernels prior to 4.17.
>>
>> NAK. If you want an old buggy kernel to pass a test, please either
>> patch the kernel or run an old test.
>
> Yeah, this isn't ok, especially as you might have 4.14 or 4.9 kernels
> that can pass the test if the needed patches were backported. Checking
> kernel version numbers should never be used for anything.
>
Also, this test failure can tell us if we should backport important
fixes. I have had requests to add kernel version checking in tests
before and the recommendation is "don't check kernel versions and
reply on feature type checks". In the case of fixes like this one,
it is better for the test to fail than make us feel warm and fuzzy
by making it pass.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-03-02 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 0:18 [PATCH] selftests: x86: add version check in test_syscall_vdso Steve Muckle
2019-03-01 0:18 ` Steve Muckle
2019-03-01 0:18 ` smuckle
2019-03-01 19:59 ` Andy Lutomirski
2019-03-01 19:59 ` Andy Lutomirski
2019-03-01 19:59 ` luto
2019-03-02 9:10 ` Greg KH
2019-03-02 9:10 ` Greg KH
2019-03-02 9:10 ` gregkh
2019-03-02 18:31 ` shuah [this message]
2019-03-02 18:31 ` shuah
2019-03-02 18:31 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9805f57-5fc8-454e-c1c8-c06dab86e863@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=smuckle@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.