From: Jens Axboe <axboe@fb.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 7/8] wbt: add general throttling mechanism
Date: Thu, 1 Sep 2016 12:51:49 -0600 [thread overview]
Message-ID: <b983e71b-c959-ca43-ce7b-b234db6035fa@fb.com> (raw)
In-Reply-To: <20160901180523.GA3280@vader.DHCP.thefacebook.com>
On 09/01/2016 12:05 PM, Omar Sandoval wrote:
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index d79909dc01ec..5a65a1f91889 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -550,4 +550,8 @@ config STACKDEPOT
>> bool
>> select STACKTRACE
>>
>> +config WBT
>> + bool
>> + select SCALE_BITMAP
>
> Looks like this snuck in from your experiments to get this to work on
> top of scale_bitmap?
Oops yes, it is indeed. Killed, thanks.
>> + if (waitqueue_active(&rwb->wait)) {
>> + int diff = limit - inflight;
>> +
>> + if (!inflight || diff >= rwb->wb_background / 2)
>> + wake_up_nr(&rwb->wait, 1);
>
> wake_up(&rwb->wait)?
Yeah, that'd be cleaner. I think this is a leftover from when I
experimented with batched wakeups, with nr != 1. I'll change it to just
wake_up().
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@fb.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>
Subject: Re: [PATCH 7/8] wbt: add general throttling mechanism
Date: Thu, 1 Sep 2016 12:51:49 -0600 [thread overview]
Message-ID: <b983e71b-c959-ca43-ce7b-b234db6035fa@fb.com> (raw)
In-Reply-To: <20160901180523.GA3280@vader.DHCP.thefacebook.com>
On 09/01/2016 12:05 PM, Omar Sandoval wrote:
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index d79909dc01ec..5a65a1f91889 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -550,4 +550,8 @@ config STACKDEPOT
>> bool
>> select STACKTRACE
>>
>> +config WBT
>> + bool
>> + select SCALE_BITMAP
>
> Looks like this snuck in from your experiments to get this to work on
> top of scale_bitmap?
Oops yes, it is indeed. Killed, thanks.
>> + if (waitqueue_active(&rwb->wait)) {
>> + int diff = limit - inflight;
>> +
>> + if (!inflight || diff >= rwb->wb_background / 2)
>> + wake_up_nr(&rwb->wait, 1);
>
> wake_up(&rwb->wait)?
Yeah, that'd be cleaner. I think this is a leftover from when I
experimented with batched wakeups, with nr != 1. I'll change it to just
wake_up().
--
Jens Axboe
next prev parent reply other threads:[~2016-09-01 18:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 17:05 [PATCHSET v6] Throttled background buffered writeback Jens Axboe
2016-08-31 17:05 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
2016-09-01 7:55 ` Johannes Thumshirn
2016-09-01 7:55 ` Johannes Thumshirn
2016-09-01 7:59 ` Johannes Thumshirn
2016-09-01 7:59 ` Johannes Thumshirn
2016-08-31 17:05 ` [PATCH 2/8] writeback: add wbc_to_write_flags() Jens Axboe
2016-08-31 23:32 ` Omar Sandoval
2016-09-01 3:54 ` Jens Axboe
2016-08-31 17:05 ` [PATCH 3/8] writeback: use WRITE_BG for kupdate and background writeback Jens Axboe
2016-08-31 17:05 ` [PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages() Jens Axboe
2016-08-31 17:05 ` [PATCH 5/8] block: add code to track actual device queue depth Jens Axboe
2016-08-31 17:05 ` [PATCH 6/8] block: add scalable completion tracking of requests Jens Axboe
2016-08-31 17:05 ` [PATCH 7/8] wbt: add general throttling mechanism Jens Axboe
2016-09-01 18:05 ` Omar Sandoval
2016-09-01 18:51 ` Jens Axboe [this message]
2016-09-01 18:51 ` Jens Axboe
2016-08-31 17:05 ` [PATCH 8/8] writeback: throttle buffered writeback Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2016-09-07 14:46 [PATCH 0/8] Throttled background buffered writeback v7 Jens Axboe
2016-09-07 14:46 ` [PATCH 7/8] wbt: add general throttling mechanism Jens Axboe
2016-04-26 15:55 [PATCHSET v5] Make background writeback great again for the first time Jens Axboe
2016-04-26 15:55 ` [PATCH 7/8] wbt: add general throttling mechanism Jens Axboe
2016-04-27 12:06 ` xiakaixu
2016-04-27 15:21 ` Jens Axboe
2016-04-28 3:29 ` xiakaixu
2016-04-28 11:05 ` Jan Kara
2016-04-28 18:53 ` Jens Axboe
2016-04-28 19:03 ` Jens Axboe
2016-05-03 9:34 ` Jan Kara
2016-05-03 14:23 ` Jens Axboe
2016-05-03 15:22 ` Jan Kara
2016-05-03 15:32 ` Jens Axboe
2016-05-03 15:40 ` Jan Kara
2016-05-03 15:48 ` Jan Kara
2016-05-03 16:59 ` Jens Axboe
2016-05-03 18:14 ` Jens Axboe
2016-05-03 19:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b983e71b-c959-ca43-ce7b-b234db6035fa@fb.com \
--to=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.