From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Paul Gortmaker <paul.gortmaker@windriver.com>, Lee Jones <lee.jones@linaro.org> Cc: <linux-kernel@vger.kernel.org>, Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org> Subject: Re: [PATCH 08/18] mfd: twl4030-audio: Make it explicitly non-modular Date: Fri, 20 Dec 2019 10:43:41 +0200 [thread overview] Message-ID: <b9d0151b-b2cd-c75b-f146-db00b372354c@ti.com> (raw) In-Reply-To: <1576702137-25905-9-git-send-email-paul.gortmaker@windriver.com> On 18/12/2019 22.48, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_TWL4030_AUDIO > drivers/mfd/Kconfig: bool "TI TWL4030 Audio" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Cc: Tony Lindgren <tony@atomide.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > Cc: linux-omap@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/mfd/twl4030-audio.c | 21 +++------------------ > 1 file changed, 3 insertions(+), 18 deletions(-) > > diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c > index 4536d829b43e..7612997e3b86 100644 > --- a/drivers/mfd/twl4030-audio.c > +++ b/drivers/mfd/twl4030-audio.c > @@ -8,7 +8,7 @@ > * Copyright: (C) 2009 Nokia Corporation > */ > > -#include <linux/module.h> > +#include <linux/init.h> > #include <linux/types.h> > #include <linux/slab.h> > #include <linux/kernel.h> > @@ -258,32 +258,17 @@ static int twl4030_audio_probe(struct platform_device *pdev) > return ret; > } > > -static int twl4030_audio_remove(struct platform_device *pdev) > -{ > - mfd_remove_devices(&pdev->dev); > - twl4030_audio_dev = NULL; > - > - return 0; > -} > - > static const struct of_device_id twl4030_audio_of_match[] = { > {.compatible = "ti,twl4030-audio", }, > { }, > }; > -MODULE_DEVICE_TABLE(of, twl4030_audio_of_match); > > static struct platform_driver twl4030_audio_driver = { > .driver = { > .name = "twl4030-audio", > .of_match_table = twl4030_audio_of_match, > + .suppress_bind_attrs = true, > }, > .probe = twl4030_audio_probe, > - .remove = twl4030_audio_remove, > }; > - > -module_platform_driver(twl4030_audio_driver); > - > -MODULE_AUTHOR("Peter Ujfalusi <peter.ujfalusi@ti.com>"); > -MODULE_DESCRIPTION("TWL4030 audio block MFD driver"); > -MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:twl4030-audio"); > +builtin_platform_driver(twl4030_audio_driver); > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: Paul Gortmaker <paul.gortmaker@windriver.com>, Lee Jones <lee.jones@linaro.org> Cc: linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org Subject: Re: [PATCH 08/18] mfd: twl4030-audio: Make it explicitly non-modular Date: Fri, 20 Dec 2019 10:43:41 +0200 [thread overview] Message-ID: <b9d0151b-b2cd-c75b-f146-db00b372354c@ti.com> (raw) In-Reply-To: <1576702137-25905-9-git-send-email-paul.gortmaker@windriver.com> On 18/12/2019 22.48, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_TWL4030_AUDIO > drivers/mfd/Kconfig: bool "TI TWL4030 Audio" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Cc: Tony Lindgren <tony@atomide.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > Cc: linux-omap@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/mfd/twl4030-audio.c | 21 +++------------------ > 1 file changed, 3 insertions(+), 18 deletions(-) > > diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c > index 4536d829b43e..7612997e3b86 100644 > --- a/drivers/mfd/twl4030-audio.c > +++ b/drivers/mfd/twl4030-audio.c > @@ -8,7 +8,7 @@ > * Copyright: (C) 2009 Nokia Corporation > */ > > -#include <linux/module.h> > +#include <linux/init.h> > #include <linux/types.h> > #include <linux/slab.h> > #include <linux/kernel.h> > @@ -258,32 +258,17 @@ static int twl4030_audio_probe(struct platform_device *pdev) > return ret; > } > > -static int twl4030_audio_remove(struct platform_device *pdev) > -{ > - mfd_remove_devices(&pdev->dev); > - twl4030_audio_dev = NULL; > - > - return 0; > -} > - > static const struct of_device_id twl4030_audio_of_match[] = { > {.compatible = "ti,twl4030-audio", }, > { }, > }; > -MODULE_DEVICE_TABLE(of, twl4030_audio_of_match); > > static struct platform_driver twl4030_audio_driver = { > .driver = { > .name = "twl4030-audio", > .of_match_table = twl4030_audio_of_match, > + .suppress_bind_attrs = true, > }, > .probe = twl4030_audio_probe, > - .remove = twl4030_audio_remove, > }; > - > -module_platform_driver(twl4030_audio_driver); > - > -MODULE_AUTHOR("Peter Ujfalusi <peter.ujfalusi@ti.com>"); > -MODULE_DESCRIPTION("TWL4030 audio block MFD driver"); > -MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:twl4030-audio"); > +builtin_platform_driver(twl4030_audio_driver); > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-12-20 8:43 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-18 20:48 [PATCH 00/18] mfd: demodularization of non-modular drivers Paul Gortmaker 2019-12-18 20:48 ` Paul Gortmaker 2019-12-18 20:48 ` [PATCH 01/18] mfd: stmpe-spi: Make it explicitly non-modular Paul Gortmaker 2019-12-18 20:48 ` [PATCH 02/18] mfd: stmpe-i2c: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 03/18] mfd: ezx-pcap: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 04/18] mfd: 88pm860x-*: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 05/18] mfd: tc3589: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 06/18] mfd: tc6387xb: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 07/18] mfd: tc6393xb: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 08/18] mfd: twl4030-audio: " Paul Gortmaker 2019-12-20 8:43 ` Peter Ujfalusi [this message] 2019-12-20 8:43 ` Peter Ujfalusi 2019-12-18 20:48 ` [PATCH 09/18] mfd: twl4030-power: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 10/18] mfd: twl6040: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 11/18] mfd: t7l66xb: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 12/18] mfd: lp8788: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 13/18] mfd: menelaus: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 14/18] mfd: tps6586x: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 15/18] mfd: omap-usb-tll: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 16/18] mfd: omap-usb-host: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 17/18] mfd: palmas: " Paul Gortmaker 2019-12-18 20:48 ` [PATCH 18/18] mfd: intel_soc_pmic_core: " Paul Gortmaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b9d0151b-b2cd-c75b-f146-db00b372354c@ti.com \ --to=peter.ujfalusi@ti.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul.gortmaker@windriver.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.