From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: "Jan Sebastian Götte" <linux@jaseg.net>
Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com,
linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
bhanusreemahesh@gmail.com, Phil Reid <preid@electromag.com.au>
Subject: Re: [PATCH] Staging: fbtft: Fix GPIO handling
Date: Mon, 15 Jul 2019 15:14:27 +0000 [thread overview]
Message-ID: <ba7c763b5c2a2d5edc4c0f700dabe08c47970600.camel@suse.de> (raw)
In-Reply-To: <294c94d2-d2c1-514d-ba6d-c62e98017bc0@jaseg.net>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On Tue, 2019-07-16 at 00:04 +0900, Jan Sebastian Götte wrote:
> Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface") breaks GPIO handling. In several places, checks to only set
> a GPIO if it was configured ended up backwards.
> I have tested this fix. The fixed driver works with a ili9486
> display connected to a raspberry pi via SPI.
>
> Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor
> interface")
> Tested-by: Jan Sebastian Götte <linux@jaseg.net>
> Signed-off-by: Jan Sebastian Götte <linux@jaseg.net>
Thanks Jan, this version is indeed more complete.
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: "Jan Sebastian Götte" <linux@jaseg.net>
Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com,
linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
bhanusreemahesh@gmail.com, Phil Reid <preid@electromag.com.au>
Subject: Re: [PATCH] Staging: fbtft: Fix GPIO handling
Date: Mon, 15 Jul 2019 17:14:27 +0200 [thread overview]
Message-ID: <ba7c763b5c2a2d5edc4c0f700dabe08c47970600.camel@suse.de> (raw)
In-Reply-To: <294c94d2-d2c1-514d-ba6d-c62e98017bc0@jaseg.net>
[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]
On Tue, 2019-07-16 at 00:04 +0900, Jan Sebastian Götte wrote:
> Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface") breaks GPIO handling. In several places, checks to only set
> a GPIO if it was configured ended up backwards.
> I have tested this fix. The fixed driver works with a ili9486
> display connected to a raspberry pi via SPI.
>
> Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor
> interface")
> Tested-by: Jan Sebastian Götte <linux@jaseg.net>
> Signed-off-by: Jan Sebastian Götte <linux@jaseg.net>
Thanks Jan, this version is indeed more complete.
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Regards,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-07-15 15:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:30 [PATCH] Staging: fbtft: Fix wrong check in fbtft_write_wmem16_bus8() Nicolas Saenz Julienne
2019-07-15 14:30 ` Nicolas Saenz Julienne
2019-07-15 14:30 ` Nicolas Saenz Julienne
[not found] ` <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
2019-07-15 14:58 ` [PATCH] Staging: fbtft: Fix wrong check in,fbtft_write_wmem16_bus8() Jan Sebastian Götte
2019-07-15 14:58 ` Jan Sebastian Götte
2019-07-15 14:58 ` Jan Sebastian Götte
2019-07-15 15:04 ` [PATCH] Staging: fbtft: Fix GPIO handling Jan Sebastian Götte
2019-07-15 15:04 ` Jan Sebastian Götte
2019-07-15 15:04 ` Jan Sebastian Götte
2019-07-15 15:14 ` Nicolas Saenz Julienne [this message]
2019-07-15 15:14 ` Nicolas Saenz Julienne
2019-07-17 14:41 ` [PATCH v2] " Jan Sebastian Götte
2019-07-17 14:41 ` Jan Sebastian Götte
2019-07-17 14:41 ` Jan Sebastian Götte
2019-07-25 7:21 ` Greg KH
2019-07-25 7:21 ` Greg KH
2019-07-25 7:23 ` Nicolas Saenz Julienne
2019-07-25 7:23 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7c763b5c2a2d5edc4c0f700dabe08c47970600.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bhanusreemahesh@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=leobras.c@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux@jaseg.net \
--cc=nishadkamdar@gmail.com \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.