From: 高峰 <fgao@ikuai8.com>
To: 'Sven Eckelmann' <sven@narfation.org>, b.a.t.m.a.n@lists.open-mesh.org
Cc: gfree.wind@foxmail.com, mareklindner@neomailbox.ch,
sw@simonwunderlich.de, a@unstable.cc, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice
Date: Fri, 9 Jun 2017 15:26:26 +0800 [thread overview]
Message-ID: <001a01d2e0f1$b529a070$1f7ce150$@ikuai8.com> (raw)
In-Reply-To: <5895676.ebVRaD88im@bentobox>
> From: Sven Eckelmann [mailto:sven@narfation.org]
> Sent: Friday, June 9, 2017 3:23 PM
> Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible
memleaks
> when fail to register_netdevice
>
> On Dienstag, 25. April 2017 20:03:20 CEST gfree.wind@foxmail.com wrote:
> > From: Gao Feng <fgao@ikuai8.com>
> >
> > Because the func batadv_softif_init_late allocate some resources and
> > it would be invoked in register_netdevice. So we need to invoke the
> > func batadv_softif_free instead of free_netdev to cleanup when fail to
> > register_netdevice.
> >
> > Signed-off-by: Gao Feng <fgao@ikuai8.com>
> > ---
> > net/batman-adv/soft-interface.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/batman-adv/soft-interface.c
> > b/net/batman-adv/soft-interface.c index d042c99..90bf990 100644
> > --- a/net/batman-adv/soft-interface.c
> > +++ b/net/batman-adv/soft-interface.c
> > @@ -1011,7 +1011,7 @@ struct net_device *batadv_softif_create(struct net
> *net, const char *name)
> > if (ret < 0) {
> > pr_err("Unable to register the batman interface '%s': %i\n",
> > name, ret);
> > - free_netdev(soft_iface);
> > + batadv_softif_free(soft_iface);
> > return NULL;
> > }
>
> It looks to me like this change is invalid after David's change [1]. Can
you
> confirm that?
>
> Thanks,
> Sven
>
> [1]
>
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=cf1
> 24db566e6b036b8bcbe8decbed740bdfac8c6
[Gao Feng]
yes, this change is unnecessary.
Best Regards
Feng
prev parent reply other threads:[~2017-06-09 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 12:03 [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice gfree.wind
2017-04-25 13:53 ` Sven Eckelmann
2017-04-26 0:41 ` Gao Feng
2017-04-26 5:57 ` Sven Eckelmann
2017-04-26 6:44 ` Gao Feng
2017-04-26 7:16 ` Sven Eckelmann
2017-04-26 7:28 ` Gao Feng
2017-06-09 7:23 ` Sven Eckelmann
2017-06-09 7:26 ` 高峰 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001a01d2e0f1$b529a070$1f7ce150$@ikuai8.com' \
--to=fgao@ikuai8.com \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=gfree.wind@foxmail.com \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).