From: Sven Eckelmann <sven@narfation.org>
To: Gao Feng <gfree.wind@foxmail.com>
Cc: mareklindner@neomailbox.ch, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org, a@unstable.cc,
'Gao Feng' <fgao@ikuai8.com>,
davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice
Date: Wed, 26 Apr 2017 09:16:54 +0200 [thread overview]
Message-ID: <2857108.moq831zFsU@bentobox> (raw)
In-Reply-To: <002101d2be58$8bcaaa00$a35ffe00$@foxmail.com>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
On Mittwoch, 26. April 2017 14:44:24 CEST Gao Feng wrote:
[...]
> I get it now, thanks.
[...]
> BTW, I think although the batadv_softif_create is legacy, we should fix it
> when it still exists :)
I didn't meant that we should not fix it. I just said that it looks to me like
the fix should look different to ensure that it actually fixes the sysfs and
rtnl link implementation for the batadv interface creation. Right now the
ndo_uninit (when it would be set by batadv) is called in the netdev core
functions when an error happens during the registration. This is not the case
for the destructor. Your patch would not change it. It therefore looks like
you simply have to move the current destructor (without the free_netdev) to
ndo_uninit and change the destructor to free_netdev.
The batadv ops doesn't have a newlink function. It will therefore use the
register_netdevice code path which calls free_netdev on failures. The extra
cleanup you've added in
https://www.mail-archive.com/netdev@vger.kernel.org/msg165253.html can
therefore not work for batman-adv. Actually, it is not touching anything
batman-adv related. The suggestion to change the register_netdevice ->
free_netdev part in rtnl_newlink was new in the reply to the batadv
discussion. It is therefore still an open discussion how it is correctly
fixed.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-26 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 12:03 [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice gfree.wind
2017-04-25 13:53 ` Sven Eckelmann
2017-04-26 0:41 ` Gao Feng
2017-04-26 5:57 ` Sven Eckelmann
2017-04-26 6:44 ` Gao Feng
2017-04-26 7:16 ` Sven Eckelmann [this message]
2017-04-26 7:28 ` Gao Feng
2017-06-09 7:23 ` Sven Eckelmann
2017-06-09 7:26 ` 高峰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2857108.moq831zFsU@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).