* [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig
@ 2018-05-26 9:40 Sven Eckelmann
2018-05-26 9:40 ` [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig Sven Eckelmann
2018-07-17 17:59 ` [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig Sven Eckelmann
0 siblings, 2 replies; 4+ messages in thread
From: Sven Eckelmann @ 2018-05-26 9:40 UTC (permalink / raw)
To: davem
Cc: netdev, b.a.t.m.a.n, a, sw, mareklindner, joe, sergei.shtylyov,
Sven Eckelmann
The "default n" is the default value for any bool or tristate Kconfig
setting. It is therefore not necessary to add it to a config entry.
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
v2: changed "the an config entry" to "a config entry" in commit message
net/batman-adv/Kconfig | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index de8034d80623..41bb67d70c83 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -24,7 +24,6 @@ config BATMAN_ADV
depends on NET
select CRC16
select LIBCRC32C
- default n
help
B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is
a routing protocol for multi-hop ad-hoc mesh networks. The
@@ -60,7 +59,6 @@ config BATMAN_ADV_BLA
config BATMAN_ADV_DAT
bool "Distributed ARP Table"
depends on BATMAN_ADV && INET
- default n
help
This option enables DAT (Distributed ARP Table), a DHT based
mechanism that increases ARP reliability on sparse wireless
@@ -70,7 +68,6 @@ config BATMAN_ADV_DAT
config BATMAN_ADV_NC
bool "Network Coding"
depends on BATMAN_ADV
- default n
help
This option enables network coding, a mechanism that aims to
increase the overall network throughput by fusing multiple
@@ -84,7 +81,6 @@ config BATMAN_ADV_NC
config BATMAN_ADV_MCAST
bool "Multicast optimisation"
depends on BATMAN_ADV && INET && !(BRIDGE=m && BATMAN_ADV=y)
- default n
help
This option enables the multicast optimisation which aims to
reduce the air overhead while improving the reliability of
@@ -94,7 +90,6 @@ config BATMAN_ADV_DEBUGFS
bool "batman-adv debugfs entries"
depends on BATMAN_ADV
depends on DEBUG_FS
- default n
help
Enable this to export routing related debug tables via debugfs.
The information for each soft-interface and used hard-interface can be
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig
2018-05-26 9:40 [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig Sven Eckelmann
@ 2018-05-26 9:40 ` Sven Eckelmann
2018-07-17 18:00 ` Sven Eckelmann
2018-07-17 17:59 ` [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig Sven Eckelmann
1 sibling, 1 reply; 4+ messages in thread
From: Sven Eckelmann @ 2018-05-26 9:40 UTC (permalink / raw)
To: davem
Cc: netdev, b.a.t.m.a.n, a, sw, mareklindner, joe, sergei.shtylyov,
Sven Eckelmann
The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the
BATMAN_ADV is enabled. A feature which is enabled by default for a module
should not be considered experimental.
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
v2: no change
net/batman-adv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index 41bb67d70c83..da0b7aa98be9 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -32,7 +32,7 @@ config BATMAN_ADV
tools.
config BATMAN_ADV_BATMAN_V
- bool "B.A.T.M.A.N. V protocol (experimental)"
+ bool "B.A.T.M.A.N. V protocol"
depends on BATMAN_ADV && !(CFG80211=m && BATMAN_ADV=y)
default y
help
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig
2018-05-26 9:40 [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig Sven Eckelmann
2018-05-26 9:40 ` [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig Sven Eckelmann
@ 2018-07-17 17:59 ` Sven Eckelmann
1 sibling, 0 replies; 4+ messages in thread
From: Sven Eckelmann @ 2018-07-17 17:59 UTC (permalink / raw)
To: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On Samstag, 26. Mai 2018 11:40:31 CEST Sven Eckelmann wrote:
> The "default n" is the default value for any bool or tristate Kconfig
> setting. It is therefore not necessary to add it to a config entry.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2: changed "the an config entry" to "a config entry" in commit message
Added as ba1a986d4af5 [1]
Kind regards,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/ba1a986d4af5ed4182966dcbd0fd04189b5e13cb
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig
2018-05-26 9:40 ` [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig Sven Eckelmann
@ 2018-07-17 18:00 ` Sven Eckelmann
0 siblings, 0 replies; 4+ messages in thread
From: Sven Eckelmann @ 2018-07-17 18:00 UTC (permalink / raw)
To: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Samstag, 26. Mai 2018 11:40:32 CEST Sven Eckelmann wrote:
> The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the
> BATMAN_ADV is enabled. A feature which is enabled by default for a module
> should not be considered experimental.
>
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2: no change
Added as c812861ac3d3 [1].
Kind regards,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/c812861ac3d391243e8059955c99b9b20ca7a82e
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-17 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-26 9:40 [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig Sven Eckelmann
2018-05-26 9:40 ` [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig Sven Eckelmann
2018-07-17 18:00 ` Sven Eckelmann
2018-07-17 17:59 ` [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig Sven Eckelmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).