From: Antonio Quartulli <ordex@autistici.org>
To: "B.A.T.M.A.N" <b.a.t.m.a.n@lists.open-mesh.org>
Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: skbs have to be freed using kfree_skb()
Date: Tue, 14 Jun 2011 18:01:39 +0200 [thread overview]
Message-ID: <1308067299-2282-1-git-send-email-ordex@autistici.org> (raw)
The skb structures have always to be freed using kfree_skb() and not the
simple kfree()
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
routing.c | 2 +-
translation-table.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/routing.c b/routing.c
index 30d0f73..41d065e 100644
--- a/routing.c
+++ b/routing.c
@@ -1299,7 +1299,7 @@ int recv_roam_adv(struct sk_buff *skb, struct hard_iface *recv_if)
orig_node_free_ref(orig_node);
ret = NET_RX_SUCCESS;
out:
- kfree(skb);
+ kfree_skb(skb);
return ret;
}
diff --git a/translation-table.c b/translation-table.c
index adecf1b..373ee81 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -1199,7 +1199,7 @@ out:
if (primary_if)
hardif_free_ref(primary_if);
if (!ret)
- kfree(skb);
+ kfree_skb(skb);
return ret;
}
@@ -1312,7 +1312,7 @@ out:
if (primary_if)
hardif_free_ref(primary_if);
if (!ret)
- kfree(skb);
+ kfree_skb(skb);
/* This packet was for me, so it doesn't need to be re-routed */
return true;
}
--
1.7.3.4
next reply other threads:[~2011-06-14 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 16:01 Antonio Quartulli [this message]
2011-06-15 18:56 ` [B.A.T.M.A.N.] [PATCH] batman-adv: skbs have to be freed using kfree_skb() Marek Lindner
2011-06-15 22:32 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: the skb has not to be freed in recv_roam_adv() Antonio Quartulli
2011-06-16 10:16 ` Marek Lindner
2011-06-15 22:32 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: skbs have to be freed using kfree_skb() Antonio Quartulli
2011-06-16 10:22 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308067299-2282-1-git-send-email-ordex@autistici.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).