b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: skbs have to be freed using kfree_skb()
Date: Wed, 15 Jun 2011 20:56:17 +0200	[thread overview]
Message-ID: <201106152056.18072.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1308067299-2282-1-git-send-email-ordex@autistici.org>

On Tuesday, June 14, 2011 06:01:39 PM Antonio Quartulli wrote:
> @@ -1299,7 +1299,7 @@ int recv_roam_adv(struct sk_buff *skb, struct
> hard_iface *recv_if) orig_node_free_ref(orig_node);
>         ret = NET_RX_SUCCESS;
>  out:
> -       kfree(skb);
> +       kfree_skb(skb);
>         return ret;
>  }
>  

I'd say recv_roam_adv() suffers from the same problem you fixed in 
recv_tt_query() with your previous patch. Wouldn't you say so ?

Cheers,
Marek

  reply	other threads:[~2011-06-15 18:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 16:01 [B.A.T.M.A.N.] [PATCH] batman-adv: skbs have to be freed using kfree_skb() Antonio Quartulli
2011-06-15 18:56 ` Marek Lindner [this message]
2011-06-15 22:32   ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: the skb has not to be freed in recv_roam_adv() Antonio Quartulli
2011-06-16 10:16     ` Marek Lindner
2011-06-15 22:32   ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: skbs have to be freed using kfree_skb() Antonio Quartulli
2011-06-16 10:22     ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106152056.18072.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).