* [B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames
@ 2014-08-06 14:34 Simon Wunderlich
2014-08-11 4:52 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Simon Wunderlich @ 2014-08-06 14:34 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Simon Wunderlich
From: Simon Wunderlich <simon@open-mesh.com>
hw_src just contains another copy of the destination. The backbone
sending the request is setting its mac address into Ethernet source, so
print that instead.
For reference, see the documentation:
http://www.open-mesh.org/projects/batman-adv/wiki/Bridge-loop-avoidance-Protocol
Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
---
tcpdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcpdump.c b/tcpdump.c
index e84617e..ada8938 100644
--- a/tcpdump.c
+++ b/tcpdump.c
@@ -148,7 +148,7 @@ static int dump_bla2_claim(struct ether_header *eth_hdr,
break;
case BATADV_CLAIM_TYPE_REQUEST:
printf("BLA REQUEST, src backbone %s, ",
- get_name_by_macaddr((struct ether_addr *)hw_src, read_opt));
+ get_name_by_macaddr((struct ether_addr *)eth_hdr->ether_shost, read_opt));
printf("dst backbone %s\n",
get_name_by_macaddr((struct ether_addr *)eth_hdr->ether_dhost, read_opt));
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames
2014-08-06 14:34 [B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames Simon Wunderlich
@ 2014-08-11 4:52 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2014-08-11 4:52 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Simon Wunderlich
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Wednesday 06 August 2014 16:34:03 Simon Wunderlich wrote:
> From: Simon Wunderlich <simon@open-mesh.com>
>
> hw_src just contains another copy of the destination. The backbone
> sending the request is setting its mac address into Ethernet source, so
> print that instead.
>
> For reference, see the documentation:
> http://www.open-mesh.org/projects/batman-adv/wiki/Bridge-loop-avoidance-Prot
> ocol
>
> Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
> ---
> tcpdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision b904124.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-11 4:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 14:34 [B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames Simon Wunderlich
2014-08-11 4:52 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).