* [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix local TT check for outgoing arp requests in DAT
@ 2014-03-29 16:27 Antonio Quartulli
2014-03-31 9:42 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Quartulli @ 2014-03-29 16:27 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
From: Antonio Quartulli <antonio@open-mesh.com>
Change introduced by d6bd8b36fa1f3d72a6fd5942a6e9bde6ddafcd0d
("batman-adv: make DAT drop ARP requests targeting local clients")
implements a check that prevents DAT from using the caching
mechanism when the client that is supposed to provide a reply
to an arp request is local.
However change brought by 3e26722bc9f248ec4316749fc1957365c0fa5e4b
("batman-adv: make the Distributed ARP Table vlan aware")
has not converted the above check into its vlan aware version
thus making it useless when the local client is behind a vlan.
Fix the behaviour by properly specifying the vlan when
checking for a client being local or not.
Reported-by: Simon Wunderlich <simon@open-mesh.com>
Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
---
Changes from v2:
- added reported-by clause
distributed-arp-table.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/distributed-arp-table.c b/distributed-arp-table.c
index 5bb37a8..a5d75be 100644
--- a/distributed-arp-table.c
+++ b/distributed-arp-table.c
@@ -940,8 +940,7 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv,
* additional DAT answer may trigger kernel warnings about
* a packet coming from the wrong port.
*/
- if (batadv_is_my_client(bat_priv, dat_entry->mac_addr,
- BATADV_NO_FLAGS)) {
+ if (batadv_is_my_client(bat_priv, dat_entry->mac_addr, vid)) {
ret = true;
goto out;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix local TT check for outgoing arp requests in DAT
2014-03-29 16:27 [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix local TT check for outgoing arp requests in DAT Antonio Quartulli
@ 2014-03-31 9:42 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2014-03-31 9:42 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli, Antonio Quartulli
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Saturday 29 March 2014 17:27:38 Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
>
> Change introduced by d6bd8b36fa1f3d72a6fd5942a6e9bde6ddafcd0d
> ("batman-adv: make DAT drop ARP requests targeting local clients")
> implements a check that prevents DAT from using the caching
> mechanism when the client that is supposed to provide a reply
> to an arp request is local.
>
> However change brought by 3e26722bc9f248ec4316749fc1957365c0fa5e4b
> ("batman-adv: make the Distributed ARP Table vlan aware")
> has not converted the above check into its vlan aware version
> thus making it useless when the local client is behind a vlan.
>
> Fix the behaviour by properly specifying the vlan when
> checking for a client being local or not.
>
> Reported-by: Simon Wunderlich <simon@open-mesh.com>
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> ---
>
> Changes from v2:
> - added reported-by clause
>
> distributed-arp-table.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied in revision 1c2e700.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-31 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-29 16:27 [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix local TT check for outgoing arp requests in DAT Antonio Quartulli
2014-03-31 9:42 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).