* [B.A.T.M.A.N.] reorganized kernel interface
@ 2010-02-27 20:30 Marek Lindner
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Marek Lindner
0 siblings, 1 reply; 10+ messages in thread
From: Marek Lindner @ 2010-02-27 20:30 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
Hi folks,
during the last batman developer meeting in Bruxelles we decided that it is
time to reorganize the batman-adv kernel interface to address numerous issues
and feature requests we have been hearing about throughout the last year. The
required changes are extensive, therefore it will take a while to get it all
sorted out.
Specifically we are targeting the following items:
* People with larger layer2 meshes have expressed the idea of having multiple
meshes running on the same device in order to build a node which sits
inbetween 2 (or more) mesh networks and routes the traffic from one to the other
(thereby reducing the overhead). Due to code limitations batman-adv can only
create a single mesh on a machine. There are numerous global variables and
functions that need to be modfied in order to support multiple meshes.
* Despite the fact that we have a growing number of events which would allow
user space applications to implement some intelligence to improve the mesh
experience batman-adv has no way of communicating these events back to
applications. To address this issue we will be moving batman-adv from /proc to
sysfs which empowers batman-adv to trigger uevents that can be handled from
user space.
* Since batman-adv's existence its parameter always were configurable using
simple commands like echo or cat. Although this interface was easy it is not
possible to direct error messages back to the shell, In case you misspelled a
parameter you had to check the system logs to learn about it. The following
patch introduces a way of exporting "allowed values", so that user space
applications can parse it and alert the user immediately. See batctl as an
example.
Please review and comment the following patches. As soon as those were
digested I will send more.
Known issues:
* When sending a wrong input value to aggregate_ogm or bonding the kernel
processes the input 3 times.
Cheers,
Marek
^ permalink raw reply [flat|nested] 10+ messages in thread
* [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs
2010-02-27 20:30 [B.A.T.M.A.N.] reorganized kernel interface Marek Lindner
@ 2010-02-27 20:30 ` Marek Lindner
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation Marek Lindner
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Marek Lindner @ 2010-02-27 20:30 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
This is the first patch in a series of patches which aim to convert
all batman-adv /proc files to sysfs. To keep the changes in a
digestable size it has been split up into smaller chunks. During
the transition period batman-adv will use /proc as well as sysfs.
As a first step the following files have been converted:
aggregate_ogm, bonding, originators, transtable_global, transtable_local
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
batman-adv-kernelland/Makefile.kbuild | 2 +-
batman-adv-kernelland/aggregation.c | 5 +-
batman-adv-kernelland/aggregation.h | 3 +-
batman-adv-kernelland/bat_sysfs.c | 318 ++++++++++++++++++++++++++
batman-adv-kernelland/bat_sysfs.h | 26 +++
batman-adv-kernelland/main.c | 13 +-
batman-adv-kernelland/main.h | 1 -
batman-adv-kernelland/originator.c | 79 +++++++-
batman-adv-kernelland/originator.h | 1 +
batman-adv-kernelland/proc.c | 350 +----------------------------
batman-adv-kernelland/proc.h | 5 -
batman-adv-kernelland/routing.c | 29 ++-
batman-adv-kernelland/routing.h | 3 +-
batman-adv-kernelland/send.c | 17 +-
batman-adv-kernelland/translation-table.c | 44 +++-
batman-adv-kernelland/translation-table.h | 6 +-
batman-adv-kernelland/types.h | 3 +
17 files changed, 512 insertions(+), 393 deletions(-)
create mode 100644 batman-adv-kernelland/bat_sysfs.c
create mode 100644 batman-adv-kernelland/bat_sysfs.h
diff --git a/batman-adv-kernelland/Makefile.kbuild b/batman-adv-kernelland/Makefile.kbuild
index 3cee49c..b206bc6 100644
--- a/batman-adv-kernelland/Makefile.kbuild
+++ b/batman-adv-kernelland/Makefile.kbuild
@@ -32,4 +32,4 @@ EXTRA_CFLAGS += -DREVISION_VERSION=\"r$(REVISION)\"
endif
obj-m += batman-adv.o
-batman-adv-objs := main.o proc.o send.o routing.o soft-interface.o device.o translation-table.o bitarray.o hash.o ring_buffer.o vis.o hard-interface.o aggregation.o originator.o gateway_common.o gateway_client.o $(shell [ "2" -eq "$(VERSION)" ] 2>&- && [ "6" -eq "$(PATCHLEVEL)" ] 2>&- && [ "$(SUBLEVEL)" -le "28" ] 2>&- && echo bat_printk.o)
+batman-adv-objs := main.o proc.o bat_sysfs.o send.o routing.o soft-interface.o device.o translation-table.o bitarray.o hash.o ring_buffer.o vis.o hard-interface.o aggregation.o originator.o gateway_common.o gateway_client.o $(shell [ "2" -eq "$(VERSION)" ] 2>&- && [ "6" -eq "$(PATCHLEVEL)" ] 2>&- && [ "$(SUBLEVEL)" -le "28" ] 2>&- && echo bat_printk.o)
diff --git a/batman-adv-kernelland/aggregation.c b/batman-adv-kernelland/aggregation.c
index 7917322..7b63be8 100644
--- a/batman-adv-kernelland/aggregation.c
+++ b/batman-adv-kernelland/aggregation.c
@@ -159,7 +159,8 @@ static void aggregate(struct forw_packet *forw_packet_aggr,
void add_bat_packet_to_list(unsigned char *packet_buff, int packet_len,
struct batman_if *if_incoming, char own_packet,
- unsigned long send_time)
+ unsigned long send_time,
+ atomic_t *aggregation_enabled)
{
/**
* _aggr -> pointer to the packet we want to aggregate with
@@ -175,7 +176,7 @@ void add_bat_packet_to_list(unsigned char *packet_buff, int packet_len,
/* find position for the packet in the forward queue */
spin_lock_irqsave(&forw_bat_list_lock, flags);
/* own packets are not to be aggregated */
- if ((atomic_read(&aggregation_enabled)) && (!own_packet)) {
+ if ((atomic_read(aggregation_enabled)) && (!own_packet)) {
hlist_for_each_entry(forw_packet_pos, tmp_node, &forw_bat_list,
list) {
if (can_aggregate_with(batman_packet,
diff --git a/batman-adv-kernelland/aggregation.h b/batman-adv-kernelland/aggregation.h
index 6da8df9..27cb039 100644
--- a/batman-adv-kernelland/aggregation.h
+++ b/batman-adv-kernelland/aggregation.h
@@ -32,6 +32,7 @@ static inline int aggregated_packet(int buff_pos, int packet_len, int num_hna)
void add_bat_packet_to_list(unsigned char *packet_buff, int packet_len,
struct batman_if *if_outgoing, char own_packet,
- unsigned long send_time);
+ unsigned long send_time,
+ atomic_t *aggregation_enabled);
void receive_aggr_bat_packet(struct ethhdr *ethhdr, unsigned char *packet_buff,
int packet_len, struct batman_if *if_incoming);
diff --git a/batman-adv-kernelland/bat_sysfs.c b/batman-adv-kernelland/bat_sysfs.c
new file mode 100644
index 0000000..9502cf6
--- /dev/null
+++ b/batman-adv-kernelland/bat_sysfs.c
@@ -0,0 +1,318 @@
+/*
+ * Copyright (C) 20010 B.A.T.M.A.N. contributors:
+ *
+ * Marek Lindner
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of version 2 of the GNU General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ * 02110-1301, USA
+ *
+ */
+
+#include "main.h"
+#include "bat_sysfs.h"
+#include "translation-table.h"
+#include "originator.h"
+#include "hard-interface.h"
+
+#define to_dev(obj) container_of(obj, struct device, kobj)
+
+struct bat_attribute {
+ struct attribute attr;
+ ssize_t (*show)(struct kobject *kobj, struct attribute *attr,
+ char *buf);
+ ssize_t (*store)(struct kobject *kobj, struct attribute *attr,
+ const char *buf, size_t count);
+};
+
+#define BAT_ATTR(_name, _mode, _show, _store) \
+struct bat_attribute bat_attr_##_name = { \
+ .attr = {.name = __stringify(_name), \
+ .mode = _mode }, \
+ .show = _show, \
+ .store = _store, \
+};
+
+#define BAT_BIN_ATTR(_name, _mode, _read, _write) \
+struct bin_attribute bat_attr_##_name = { \
+ .attr = { .name = __stringify(_name), \
+ .mode = _mode, }, \
+ .read = _read, \
+ .write = _write, \
+};
+
+static ssize_t show_bond(struct kobject *kobj, struct attribute *attr,
+ char *buff)
+{
+ struct device *dev = to_dev(kobj->parent);
+ struct bat_priv *bat_priv = netdev_priv(to_net_dev(dev));
+ int bond_status = atomic_read(&bat_priv->bonding_enabled);
+
+ return sprintf(buff, "status: %s\ncommands: enable, disable, 0, 1 \n",
+ bond_status == 0 ? "disabled" : "enabled");
+}
+
+static ssize_t store_bond(struct kobject *kobj, struct attribute *attr,
+ const char *buff, size_t count)
+{
+ struct device *dev = to_dev(kobj->parent);
+ struct net_device *net_dev = to_net_dev(dev);
+ struct bat_priv *bat_priv = netdev_priv(net_dev);
+ int bonding_enabled_tmp = -1;
+
+ if (((count == 2) && (buff[0] == '1')) ||
+ (strncmp(buff, "enable", 6) == 0))
+ bonding_enabled_tmp = 1;
+
+ if (((count == 2) && (buff[0] == '0')) ||
+ (strncmp(buff, "disable", 7) == 0))
+ bonding_enabled_tmp = 0;
+
+ if (bonding_enabled_tmp < 0) {
+ printk(KERN_ERR "batman-adv:Invalid parameter for 'bonding' setting on mesh %s received: %s\n",
+ net_dev->name, buff);
+ return -EINVAL;
+ }
+
+ if (atomic_read(&bat_priv->bonding_enabled) == bonding_enabled_tmp)
+ return count;
+
+ printk(KERN_INFO "batman-adv:Changing bonding from: %s to: %s on mesh: %s\n",
+ atomic_read(&bat_priv->bonding_enabled) == 1 ?
+ "enabled" : "disabled",
+ bonding_enabled_tmp == 1 ? "enabled" : "disabled",
+ net_dev->name);
+
+ atomic_set(&bat_priv->bonding_enabled, (unsigned)bonding_enabled_tmp);
+ return count;
+}
+
+static ssize_t show_aggr_ogm(struct kobject *kobj, struct attribute *attr,
+ char *buff)
+{
+ struct device *dev = to_dev(kobj->parent);
+ struct bat_priv *bat_priv = netdev_priv(to_net_dev(dev));
+ int aggr_status = atomic_read(&bat_priv->aggregation_enabled);
+
+ return sprintf(buff, "status: %s\ncommands: enable, disable, 0, 1 \n",
+ aggr_status == 0 ? "disabled" : "enabled");
+}
+
+static ssize_t store_aggr_ogm(struct kobject *kobj, struct attribute *attr,
+ const char *buff, size_t count)
+{
+ struct device *dev = to_dev(kobj->parent);
+ struct net_device *net_dev = to_net_dev(dev);
+ struct bat_priv *bat_priv = netdev_priv(net_dev);
+ int aggr_tmp = -1;
+
+ if (((count == 2) && (buff[0] == '1')) ||
+ (strncmp(buff, "enable", 6) == 0))
+ aggr_tmp = 1;
+
+ if (((count == 2) && (buff[0] == '0')) ||
+ (strncmp(buff, "disable", 7) == 0))
+ aggr_tmp = 0;
+
+ if (aggr_tmp < 0) {
+ printk(KERN_INFO "batman-adv:Invalid parameter for 'aggregate OGM' setting on mesh %s received: %s\n",
+ net_dev->name, buff);
+ return -EINVAL;
+ }
+
+ if (atomic_read(&bat_priv->aggregation_enabled) == aggr_tmp)
+ return count;
+
+ printk(KERN_INFO "batman-adv:Changing aggregation from: %s to: %s on mesh: %s\n",
+ atomic_read(&bat_priv->aggregation_enabled) == 1 ?
+ "enabled" : "disabled", aggr_tmp == 1 ? "enabled" : "disabled",
+ net_dev->name);
+
+ atomic_set(&bat_priv->aggregation_enabled, (unsigned)aggr_tmp);
+ return count;
+}
+
+static BAT_ATTR(aggregate_ogm, S_IRUGO | S_IWUSR,
+ show_aggr_ogm, store_aggr_ogm);
+static BAT_ATTR(bonding, S_IRUGO | S_IWUSR, show_bond, store_bond);
+
+static struct bat_attribute *mesh_attrs[] = {
+ &bat_attr_bonding,
+ &bat_attr_aggregate_ogm,
+ NULL,
+};
+
+static ssize_t transtable_local_read(struct kobject *kobj,
+ struct bin_attribute *bin_attr,
+ char *buff, loff_t off, size_t count)
+{
+ struct device *dev = to_dev(kobj->parent);
+ struct net_device *net_dev = to_net_dev(dev);
+
+ rcu_read_lock();
+ if (list_empty(&if_list)) {
+ rcu_read_unlock();
+
+ if (off == 0)
+ return sprintf(buff,
+ "BATMAN mesh %s disabled - please specify interfaces to enable it\n",
+ net_dev->name);
+
+ return 0;
+ }
+ rcu_read_unlock();
+
+ return hna_local_fill_buffer_text(net_dev, buff, count, off);
+}
+
+static ssize_t transtable_global_read(struct kobject *kobj,
+ struct bin_attribute *bin_attr,
+ char *buff, loff_t off, size_t count)
+{
+ struct device *dev = to_dev(kobj->parent);
+ struct net_device *net_dev = to_net_dev(dev);
+
+ rcu_read_lock();
+ if (list_empty(&if_list)) {
+ rcu_read_unlock();
+
+ if (off == 0)
+ return sprintf(buff,
+ "BATMAN mesh %s disabled - please specify interfaces to enable it\n",
+ net_dev->name);
+
+ return 0;
+ }
+ rcu_read_unlock();
+
+ return hna_global_fill_buffer_text(net_dev, buff, count, off);
+}
+
+static ssize_t originators_read(struct kobject *kobj,
+ struct bin_attribute *bin_attr,
+ char *buff, loff_t off, size_t count)
+{
+ /* FIXME: orig table should exist per batif */
+ struct device *dev = to_dev(kobj->parent);
+ struct net_device *net_dev = to_net_dev(dev);
+
+ rcu_read_lock();
+ if (list_empty(&if_list)) {
+ rcu_read_unlock();
+
+ if (off == 0)
+ return sprintf(buff,
+ "BATMAN mesh %s disabled - please specify interfaces to enable it\n",
+ net_dev->name);
+
+ return 0;
+ }
+
+ if (((struct batman_if *)if_list.next)->if_active != IF_ACTIVE) {
+ rcu_read_unlock();
+
+ if (off == 0)
+ return sprintf(buff,
+ "BATMAN mesh %s disabled - primary interface not active\n",
+ net_dev->name);
+
+ return 0;
+ }
+ rcu_read_unlock();
+
+ return orig_fill_buffer_text(buff, count, off);
+}
+
+static BAT_BIN_ATTR(transtable_local, S_IRUGO, transtable_local_read, NULL);
+static BAT_BIN_ATTR(transtable_global, S_IRUGO, transtable_global_read, NULL);
+static BAT_BIN_ATTR(originators, S_IRUGO, originators_read, NULL);
+
+static struct bin_attribute *mesh_bin_attrs[] = {
+ &bat_attr_transtable_local,
+ &bat_attr_transtable_global,
+ &bat_attr_originators,
+ NULL,
+};
+
+int sysfs_add_meshif(struct net_device *dev)
+{
+ struct kobject *batif_kobject = &dev->dev.kobj;
+ struct bat_priv *bat_priv = netdev_priv(dev);
+ struct bat_attribute **bat_attr;
+ struct bin_attribute **bin_attr;
+ int err;
+
+ /* FIXME: should be done in the general mesh setup
+ routine as soon as we have it */
+ atomic_set(&bat_priv->aggregation_enabled, 1);
+ atomic_set(&bat_priv->bonding_enabled, 0);
+
+ bat_priv->mesh_obj = kobject_create_and_add(SYSFS_IF_MESH_SUBDIR,
+ batif_kobject);
+ if (!bat_priv->mesh_obj) {
+ printk(KERN_ERR "batman-adv:Can't add sysfs directory: %s/%s\n",
+ dev->name, SYSFS_IF_MESH_SUBDIR);
+ goto out;
+ }
+
+ for (bat_attr = mesh_attrs; *bat_attr; ++bat_attr) {
+ err = sysfs_create_file(bat_priv->mesh_obj,
+ &((*bat_attr)->attr));
+ if (err) {
+ printk(KERN_ERR "batman-adv:Can't add sysfs file: %s/%s/%s\n",
+ dev->name, SYSFS_IF_MESH_SUBDIR,
+ ((*bat_attr)->attr).name);
+ goto rem_attr;
+ }
+ }
+
+ for (bin_attr = mesh_bin_attrs; *bin_attr; ++bin_attr) {
+ err = sysfs_create_bin_file(bat_priv->mesh_obj, (*bin_attr));
+ if (err) {
+ printk(KERN_ERR "batman-adv:Can't add sysfs file: %s/%s/%s\n",
+ dev->name, SYSFS_IF_MESH_SUBDIR,
+ ((*bin_attr)->attr).name);
+ goto rem_bin_attr;
+ }
+ }
+
+ return 0;
+
+rem_bin_attr:
+ for (bin_attr = mesh_bin_attrs; *bin_attr; ++bin_attr)
+ sysfs_remove_bin_file(bat_priv->mesh_obj, (*bin_attr));
+rem_attr:
+ for (bat_attr = mesh_attrs; *bat_attr; ++bat_attr)
+ sysfs_remove_file(bat_priv->mesh_obj, &((*bat_attr)->attr));
+
+ kobject_put(bat_priv->mesh_obj);
+ bat_priv->mesh_obj = NULL;
+out:
+ return -ENOMEM;
+}
+
+void sysfs_del_meshif(struct net_device *dev)
+{
+ struct bat_priv *bat_priv = netdev_priv(dev);
+ struct bat_attribute **bat_attr;
+ struct bin_attribute **bin_attr;
+
+ for (bin_attr = mesh_bin_attrs; *bin_attr; ++bin_attr)
+ sysfs_remove_bin_file(bat_priv->mesh_obj, (*bin_attr));
+
+ for (bat_attr = mesh_attrs; *bat_attr; ++bat_attr)
+ sysfs_remove_file(bat_priv->mesh_obj, &((*bat_attr)->attr));
+
+ kobject_put(bat_priv->mesh_obj);
+ bat_priv->mesh_obj = NULL;
+}
diff --git a/batman-adv-kernelland/bat_sysfs.h b/batman-adv-kernelland/bat_sysfs.h
new file mode 100644
index 0000000..d215c5d
--- /dev/null
+++ b/batman-adv-kernelland/bat_sysfs.h
@@ -0,0 +1,26 @@
+/*
+ * Copyright (C) 20010 B.A.T.M.A.N. contributors:
+ *
+ * Marek Lindner
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of version 2 of the GNU General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ * 02110-1301, USA
+ *
+ */
+
+
+#define SYSFS_IF_MESH_SUBDIR "mesh"
+
+int sysfs_add_meshif(struct net_device *dev);
+void sysfs_del_meshif(struct net_device *dev);
diff --git a/batman-adv-kernelland/main.c b/batman-adv-kernelland/main.c
index 5c5bde9..a1f7111 100644
--- a/batman-adv-kernelland/main.c
+++ b/batman-adv-kernelland/main.c
@@ -21,6 +21,7 @@
#include "main.h"
#include "proc.h"
+#include "bat_sysfs.h"
#include "routing.h"
#include "send.h"
#include "originator.h"
@@ -47,8 +48,6 @@ DEFINE_SPINLOCK(forw_bcast_list_lock);
atomic_t originator_interval;
atomic_t vis_interval;
atomic_t vis_mode;
-atomic_t aggregation_enabled;
-atomic_t bonding_enabled;
int16_t num_hna;
int16_t num_ifs;
@@ -89,8 +88,6 @@ int init_module(void)
atomic_set(&vis_interval, 1000);/* TODO: raise this later, this is only
* for debugging now. */
atomic_set(&vis_mode, VIS_TYPE_CLIENT_UPDATE);
- atomic_set(&aggregation_enabled, 1);
- atomic_set(&bonding_enabled, 0);
atomic_set(&gw_mode, GW_MODE_OFF);
atomic_set(&gw_srv_class, 0);
atomic_set(&gw_clnt_class, 0);
@@ -124,6 +121,11 @@ int init_module(void)
goto free_soft_device;
}
+ retval = sysfs_add_meshif(soft_device);
+
+ if (retval < 0)
+ goto unreg_soft_device;
+
register_netdevice_notifier(&hard_if_notifier);
dev_add_pack(&batman_adv_packet_type);
@@ -132,6 +134,8 @@ int init_module(void)
return 0;
+unreg_soft_device:
+ unregister_netdevice(soft_device);
free_soft_device:
free_netdev(soft_device);
soft_device = NULL;
@@ -144,6 +148,7 @@ void cleanup_module(void)
shutdown_module();
if (soft_device) {
+ sysfs_del_meshif(soft_device);
unregister_netdev(soft_device);
soft_device = NULL;
}
diff --git a/batman-adv-kernelland/main.h b/batman-adv-kernelland/main.h
index 2018c4e..307a6e6 100644
--- a/batman-adv-kernelland/main.h
+++ b/batman-adv-kernelland/main.h
@@ -136,7 +136,6 @@ extern spinlock_t forw_bcast_list_lock;
extern atomic_t originator_interval;
extern atomic_t vis_interval;
extern atomic_t vis_mode;
-extern atomic_t aggregation_enabled;
extern atomic_t bonding_enabled;
extern int16_t num_hna;
extern int16_t num_ifs;
diff --git a/batman-adv-kernelland/originator.c b/batman-adv-kernelland/originator.c
index 100ecca..995c174 100644
--- a/batman-adv-kernelland/originator.c
+++ b/batman-adv-kernelland/originator.c
@@ -210,6 +210,8 @@ static bool purge_orig_neighbors(struct orig_node *orig_node,
static bool purge_orig_node(struct orig_node *orig_node)
{
+ /* FIXME: each batman_if will be attached to a softif */
+ struct bat_priv *bat_priv = netdev_priv(soft_device);
struct neigh_node *best_neigh_node;
if (time_after(jiffies,
@@ -227,7 +229,8 @@ static bool purge_orig_node(struct orig_node *orig_node)
orig_node->hna_buff_len);
/* update bonding candidates, we could have lost
* some candidates. */
- update_bonding_candidates(orig_node);
+ update_bonding_candidates(orig_node,
+ &bat_priv->bonding_enabled);
}
}
return false;
@@ -258,3 +261,77 @@ void purge_orig(struct work_struct *work)
gw_election();
start_purge_timer();
}
+
+ssize_t orig_fill_buffer_text(char *buff, size_t count, loff_t off)
+{
+ HASHIT(hashit);
+ struct orig_node *orig_node;
+ struct neigh_node *neigh_node;
+ size_t hdr_len, tmp_len;
+ int batman_count = 0, bytes_written = 0;
+ unsigned long flags;
+ char orig_str[ETH_STR_LEN], router_str[ETH_STR_LEN];
+
+ rcu_read_lock();
+ hdr_len = sprintf(buff,
+ " %-14s (%s/%i) %17s [%10s]: %20s ... [B.A.T.M.A.N. adv %s%s, MainIF/MAC: %s/%s] \n",
+ "Originator", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF",
+ "Potential nexthops", SOURCE_VERSION, REVISION_VERSION_STR,
+ ((struct batman_if *)if_list.next)->dev,
+ ((struct batman_if *)if_list.next)->addr_str);
+ rcu_read_unlock();
+
+ if (off < hdr_len)
+ bytes_written = hdr_len;
+
+ spin_lock_irqsave(&orig_hash_lock, flags);
+
+ while (hash_iterate(orig_hash, &hashit)) {
+
+ orig_node = hashit.bucket->data;
+
+ if (!orig_node->router)
+ continue;
+
+ if (orig_node->router->tq_avg == 0)
+ continue;
+
+ /* estimated line length */
+ if (count < bytes_written + 200)
+ break;
+
+ addr_to_string(orig_str, orig_node->orig);
+ addr_to_string(router_str, orig_node->router->addr);
+
+ tmp_len = sprintf(buff + bytes_written,
+ "%-17s (%3i) %17s [%10s]:",
+ orig_str, orig_node->router->tq_avg,
+ router_str,
+ orig_node->router->if_incoming->dev);
+
+ list_for_each_entry(neigh_node, &orig_node->neigh_list, list) {
+ addr_to_string(orig_str, neigh_node->addr);
+ tmp_len += sprintf(buff + bytes_written + tmp_len,
+ " %17s (%3i)", orig_str,
+ neigh_node->tq_avg);
+ }
+
+ tmp_len += sprintf(buff + bytes_written + tmp_len, "\n");
+
+ batman_count++;
+ hdr_len += tmp_len;
+
+ if (off >= hdr_len)
+ continue;
+
+ bytes_written += tmp_len;
+ }
+
+ spin_unlock_irqrestore(&orig_hash_lock, flags);
+
+ if ((batman_count == 0) && (off == 0))
+ bytes_written += sprintf(buff + bytes_written,
+ "No batman nodes in range ... \n");
+
+ return bytes_written;
+}
diff --git a/batman-adv-kernelland/originator.h b/batman-adv-kernelland/originator.h
index c1a9c2d..3d22259 100644
--- a/batman-adv-kernelland/originator.h
+++ b/batman-adv-kernelland/originator.h
@@ -28,3 +28,4 @@ struct orig_node *get_orig_node(uint8_t *addr);
struct neigh_node *
create_neighbor(struct orig_node *orig_node, struct orig_node *orig_neigh_node,
uint8_t *neigh, struct batman_if *if_incoming);
+ssize_t orig_fill_buffer_text(char *buff, size_t count, loff_t off);
diff --git a/batman-adv-kernelland/proc.c b/batman-adv-kernelland/proc.c
index 859547d..d9880b1 100644
--- a/batman-adv-kernelland/proc.c
+++ b/batman-adv-kernelland/proc.c
@@ -32,11 +32,8 @@
#include "gateway_client.h"
static struct proc_dir_entry *proc_batman_dir, *proc_interface_file;
-static struct proc_dir_entry *proc_orig_interval_file, *proc_originators_file;
-static struct proc_dir_entry *proc_transt_local_file;
-static struct proc_dir_entry *proc_transt_global_file;
+static struct proc_dir_entry *proc_orig_interval_file;
static struct proc_dir_entry *proc_vis_srv_file, *proc_vis_data_file;
-static struct proc_dir_entry *proc_aggr_file, *proc_bond_file;
static struct proc_dir_entry *proc_gw_mode_file, *proc_gw_srv_list_file;
static int proc_interfaces_read(struct seq_file *seq, void *offset)
@@ -180,145 +177,6 @@ static int proc_orig_interval_open(struct inode *inode, struct file *file)
return single_open(file, proc_orig_interval_read, NULL);
}
-static int proc_originators_read(struct seq_file *seq, void *offset)
-{
- HASHIT(hashit);
- struct orig_node *orig_node;
- struct neigh_node *neigh_node;
- int batman_count = 0;
- char orig_str[ETH_STR_LEN], router_str[ETH_STR_LEN];
- unsigned long flags;
-
- rcu_read_lock();
- if (list_empty(&if_list)) {
- rcu_read_unlock();
- seq_printf(seq, "BATMAN disabled - please specify interfaces to enable it \n");
- goto end;
- }
-
- if (((struct batman_if *)if_list.next)->if_active != IF_ACTIVE) {
- rcu_read_unlock();
- seq_printf(seq, "BATMAN disabled - primary interface not active \n");
- goto end;
- }
-
- seq_printf(seq,
- " %-14s (%s/%i) %17s [%10s]: %20s ... [B.A.T.M.A.N. adv %s%s, MainIF/MAC: %s/%s] \n",
- "Originator", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF",
- "Potential nexthops", SOURCE_VERSION, REVISION_VERSION_STR,
- ((struct batman_if *)if_list.next)->dev,
- ((struct batman_if *)if_list.next)->addr_str);
-
- rcu_read_unlock();
- spin_lock_irqsave(&orig_hash_lock, flags);
-
- while (hash_iterate(orig_hash, &hashit)) {
-
- orig_node = hashit.bucket->data;
-
- if (!orig_node->router)
- continue;
-
- if (orig_node->router->tq_avg == 0)
- continue;
-
- batman_count++;
-
- addr_to_string(orig_str, orig_node->orig);
- addr_to_string(router_str, orig_node->router->addr);
-
- seq_printf(seq, "%-17s (%3i) %17s [%10s]:",
- orig_str, orig_node->router->tq_avg,
- router_str, orig_node->router->if_incoming->dev);
-
- list_for_each_entry(neigh_node, &orig_node->neigh_list, list) {
- addr_to_string(orig_str, neigh_node->addr);
- seq_printf(seq, " %17s (%3i)",
- orig_str, neigh_node->tq_avg);
- }
-
- seq_printf(seq, "\n");
-
- }
-
- spin_unlock_irqrestore(&orig_hash_lock, flags);
-
- if (batman_count == 0)
- seq_printf(seq, "No batman nodes in range ... \n");
-
-end:
- return 0;
-}
-
-static int proc_originators_open(struct inode *inode, struct file *file)
-{
- return single_open(file, proc_originators_read, NULL);
-}
-
-static int proc_transt_local_read(struct seq_file *seq, void *offset)
-{
- char *buf;
-
- buf = kmalloc(4096, GFP_KERNEL);
- if (!buf)
- return 0;
-
- rcu_read_lock();
- if (list_empty(&if_list)) {
- rcu_read_unlock();
- seq_printf(seq, "BATMAN disabled - please specify interfaces to enable it \n");
- goto end;
- }
-
- rcu_read_unlock();
-
- seq_printf(seq, "Locally retrieved addresses (from %s) announced via HNA:\n", soft_device->name);
-
- hna_local_fill_buffer_text(buf, 4096);
- seq_printf(seq, "%s", buf);
-
-end:
- kfree(buf);
- return 0;
-}
-
-static int proc_transt_local_open(struct inode *inode, struct file *file)
-{
- return single_open(file, proc_transt_local_read, NULL);
-}
-
-static int proc_transt_global_read(struct seq_file *seq, void *offset)
-{
- char *buf;
-
- buf = kmalloc(4096, GFP_KERNEL);
- if (!buf)
- return 0;
-
- rcu_read_lock();
- if (list_empty(&if_list)) {
- rcu_read_unlock();
- seq_printf(seq, "BATMAN disabled - please specify interfaces to enable it \n");
- goto end;
- }
- rcu_read_unlock();
-
-
- seq_printf(seq, "Globally announced HNAs received via the mesh (translation table):\n");
-
- hna_global_fill_buffer_text(buf, 4096);
- seq_printf(seq, "%s", buf);
-
-end:
- kfree(buf);
- return 0;
-}
-
-static int proc_transt_global_open(struct inode *inode, struct file *file)
-{
- return single_open(file, proc_transt_global_read, NULL);
-}
-
/* setting the mode of the vis server by the user */
static ssize_t proc_vis_srv_write(struct file *file, const char __user * buffer,
size_t count, loff_t *ppos)
@@ -414,53 +272,6 @@ static int proc_vis_data_open(struct inode *inode, struct file *file)
return single_open(file, proc_vis_data_read, NULL);
}
-static int proc_aggr_read(struct seq_file *seq, void *offset)
-{
- seq_printf(seq, "%i\n", atomic_read(&aggregation_enabled));
-
- return 0;
-}
-
-static ssize_t proc_aggr_write(struct file *file, const char __user *buffer,
- size_t count, loff_t *ppos)
-{
- char *aggr_string;
- int not_copied = 0;
- unsigned long aggregation_enabled_tmp;
- int retval;
-
- aggr_string = kmalloc(count, GFP_KERNEL);
-
- if (!aggr_string)
- return -ENOMEM;
-
- not_copied = copy_from_user(aggr_string, buffer, count);
- aggr_string[count - not_copied - 1] = 0;
-
- retval = strict_strtoul(aggr_string, 10, &aggregation_enabled_tmp);
-
- if (retval || aggregation_enabled_tmp > 1) {
- printk(KERN_ERR "batman-adv:Aggregation can only be enabled (1) or disabled (0), given value: %li\n", aggregation_enabled_tmp);
- } else {
- printk(KERN_INFO "batman-adv:Changing aggregation from: %s (%i) to: %s (%li)\n",
- (atomic_read(&aggregation_enabled) == 1 ?
- "enabled" : "disabled"),
- atomic_read(&aggregation_enabled),
- (aggregation_enabled_tmp == 1 ? "enabled" : "disabled"),
- aggregation_enabled_tmp);
- atomic_set(&aggregation_enabled,
- (unsigned)aggregation_enabled_tmp);
- }
-
- kfree(aggr_string);
- return count;
-}
-
-static int proc_aggr_open(struct inode *inode, struct file *file)
-{
- return single_open(file, proc_aggr_read, NULL);
-}
-
static int proc_gw_mode_read(struct seq_file *seq, void *offset)
{
int down, up;
@@ -553,54 +364,6 @@ static int proc_gw_srv_list_open(struct inode *inode, struct file *file)
return single_open(file, proc_gw_srv_list_read, NULL);
}
-
-static int proc_bond_read(struct seq_file *seq, void *offset)
-{
- seq_printf(seq, "%i\n", atomic_read(&bonding_enabled));
-
- return 0;
-}
-
-static ssize_t proc_bond_write(struct file *file, const char __user *buffer,
- size_t count, loff_t *ppos)
-{
- char *bond_string;
- int not_copied = 0;
- unsigned long bonding_enabled_tmp;
- int retval;
-
- bond_string = kmalloc(count, GFP_KERNEL);
-
- if (!bond_string)
- return -ENOMEM;
-
- not_copied = copy_from_user(bond_string, buffer, count);
- bond_string[count - not_copied - 1] = 0;
-
- retval = strict_strtoul(bond_string, 10, &bonding_enabled_tmp);
-
- if (retval || bonding_enabled_tmp > 1) {
- printk(KERN_ERR "batman-adv: Bonding can only be enabled (1) or disabled (0), given value: %li\n", bonding_enabled_tmp);
- } else {
- printk(KERN_INFO "batman-adv:Changing bonding from: %s (%i) to: %s (%li)\n",
- (atomic_read(&bonding_enabled) == 1 ?
- "enabled" : "disabled"),
- atomic_read(&bonding_enabled),
- (bonding_enabled_tmp == 1 ? "enabled" : "disabled"),
- bonding_enabled_tmp);
- atomic_set(&bonding_enabled,
- (unsigned)bonding_enabled_tmp);
- }
-
- kfree(bond_string);
- return count;
-}
-
-static int proc_bond_open(struct inode *inode, struct file *file)
-{
- return single_open(file, proc_bond_read, NULL);
-}
-
/* satisfying different prototypes ... */
static ssize_t proc_dummy_write(struct file *file, const char __user *buffer,
size_t count, loff_t *ppos)
@@ -626,24 +389,6 @@ static const struct file_operations proc_gw_mode_fops = {
.release = single_release,
};
-static const struct file_operations proc_aggr_fops = {
- .owner = THIS_MODULE,
- .open = proc_aggr_open,
- .read = seq_read,
- .write = proc_aggr_write,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
-static const struct file_operations proc_bond_fops = {
- .owner = THIS_MODULE,
- .open = proc_bond_open,
- .read = seq_read,
- .write = proc_bond_write,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
static const struct file_operations proc_vis_srv_fops = {
.owner = THIS_MODULE,
.open = proc_vis_srv_open,
@@ -662,33 +407,6 @@ static const struct file_operations proc_vis_data_fops = {
.release = single_release,
};
-static const struct file_operations proc_originators_fops = {
- .owner = THIS_MODULE,
- .open = proc_originators_open,
- .read = seq_read,
- .write = proc_dummy_write,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
-static const struct file_operations proc_transt_local_fops = {
- .owner = THIS_MODULE,
- .open = proc_transt_local_open,
- .read = seq_read,
- .write = proc_dummy_write,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
-static const struct file_operations proc_transt_global_fops = {
- .owner = THIS_MODULE,
- .open = proc_transt_global_open,
- .read = seq_read,
- .write = proc_dummy_write,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
static const struct file_operations proc_interfaces_fops = {
.owner = THIS_MODULE,
.open = proc_interfaces_open,
@@ -709,15 +427,6 @@ static const struct file_operations proc_orig_interval_fops = {
void cleanup_procfs(void)
{
- if (proc_transt_global_file)
- remove_proc_entry(PROC_FILE_TRANST_GLOBAL, proc_batman_dir);
-
- if (proc_transt_local_file)
- remove_proc_entry(PROC_FILE_TRANST_LOCAL, proc_batman_dir);
-
- if (proc_originators_file)
- remove_proc_entry(PROC_FILE_ORIGINATORS, proc_batman_dir);
-
if (proc_orig_interval_file)
remove_proc_entry(PROC_FILE_ORIG_INTERVAL, proc_batman_dir);
@@ -730,19 +439,12 @@ void cleanup_procfs(void)
if (proc_vis_srv_file)
remove_proc_entry(PROC_FILE_VIS_SRV, proc_batman_dir);
- if (proc_aggr_file)
- remove_proc_entry(PROC_FILE_AGGR, proc_batman_dir);
-
if (proc_gw_mode_file)
remove_proc_entry(PROC_FILE_GW_MODE, proc_batman_dir);
if (proc_gw_srv_list_file)
remove_proc_entry(PROC_FILE_GW_SRV_LIST, proc_batman_dir);
- if (proc_bond_file)
- remove_proc_entry(PROC_FILE_BOND, proc_batman_dir);
-
-
if (proc_batman_dir)
#ifdef __NET_NET_NAMESPACE_H
remove_proc_entry(PROC_ROOT_DIR, init_net.proc_net);
@@ -786,36 +488,6 @@ int setup_procfs(void)
return -EFAULT;
}
- proc_originators_file = create_proc_entry(PROC_FILE_ORIGINATORS,
- S_IRUGO, proc_batman_dir);
- if (proc_originators_file) {
- proc_originators_file->proc_fops = &proc_originators_fops;
- } else {
- printk(KERN_ERR "batman-adv: Registering the '/proc/net/%s/%s' file failed\n", PROC_ROOT_DIR, PROC_FILE_ORIGINATORS);
- cleanup_procfs();
- return -EFAULT;
- }
-
- proc_transt_local_file = create_proc_entry(PROC_FILE_TRANST_LOCAL,
- S_IRUGO, proc_batman_dir);
- if (proc_transt_local_file) {
- proc_transt_local_file->proc_fops = &proc_transt_local_fops;
- } else {
- printk(KERN_ERR "batman-adv: Registering the '/proc/net/%s/%s' file failed\n", PROC_ROOT_DIR, PROC_FILE_TRANST_LOCAL);
- cleanup_procfs();
- return -EFAULT;
- }
-
- proc_transt_global_file = create_proc_entry(PROC_FILE_TRANST_GLOBAL,
- S_IRUGO, proc_batman_dir);
- if (proc_transt_global_file) {
- proc_transt_global_file->proc_fops = &proc_transt_global_fops;
- } else {
- printk(KERN_ERR "batman-adv: Registering the '/proc/net/%s/%s' file failed\n", PROC_ROOT_DIR, PROC_FILE_TRANST_GLOBAL);
- cleanup_procfs();
- return -EFAULT;
- }
-
proc_vis_srv_file = create_proc_entry(PROC_FILE_VIS_SRV,
S_IWUSR | S_IRUGO,
proc_batman_dir);
@@ -837,16 +509,6 @@ int setup_procfs(void)
return -EFAULT;
}
- proc_aggr_file = create_proc_entry(PROC_FILE_AGGR, S_IWUSR | S_IRUGO,
- proc_batman_dir);
- if (proc_aggr_file) {
- proc_aggr_file->proc_fops = &proc_aggr_fops;
- } else {
- printk(KERN_ERR "batman-adv: Registering the '/proc/net/%s/%s' file failed\n", PROC_ROOT_DIR, PROC_FILE_AGGR);
- cleanup_procfs();
- return -EFAULT;
- }
-
proc_gw_mode_file = create_proc_entry(PROC_FILE_GW_MODE,
S_IWUSR | S_IRUGO,
proc_batman_dir);
@@ -871,15 +533,5 @@ int setup_procfs(void)
return -EFAULT;
}
- proc_bond_file = create_proc_entry(PROC_FILE_BOND, S_IWUSR | S_IRUGO,
- proc_batman_dir);
- if (proc_bond_file) {
- proc_bond_file->proc_fops = &proc_bond_fops;
- } else {
- printk(KERN_ERR "batman-adv: Registering the '/proc/net/%s/%s' file failed\n", PROC_ROOT_DIR, PROC_FILE_BOND);
- cleanup_procfs();
- return -EFAULT;
- }
-
return 0;
}
diff --git a/batman-adv-kernelland/proc.h b/batman-adv-kernelland/proc.h
index ae33057..6d74c54 100644
--- a/batman-adv-kernelland/proc.h
+++ b/batman-adv-kernelland/proc.h
@@ -25,16 +25,11 @@
#define PROC_ROOT_DIR "batman-adv"
#define PROC_FILE_INTERFACES "interfaces"
#define PROC_FILE_ORIG_INTERVAL "orig_interval"
-#define PROC_FILE_ORIGINATORS "originators"
#define PROC_FILE_GATEWAYS "gateways"
#define PROC_FILE_LOG "log"
#define PROC_FILE_LOG_LEVEL "log_level"
-#define PROC_FILE_TRANST_LOCAL "transtable_local"
-#define PROC_FILE_TRANST_GLOBAL "transtable_global"
#define PROC_FILE_VIS_SRV "vis_server"
#define PROC_FILE_VIS_DATA "vis_data"
-#define PROC_FILE_AGGR "aggregate_ogm"
-#define PROC_FILE_BOND "bonding"
#define PROC_FILE_GW_MODE "gateway_mode"
#define PROC_FILE_GW_SRV_LIST "gateway_srv_list"
diff --git a/batman-adv-kernelland/routing.c b/batman-adv-kernelland/routing.c
index 47d5757..ff6fcbe 100644
--- a/batman-adv-kernelland/routing.c
+++ b/batman-adv-kernelland/routing.c
@@ -364,33 +364,35 @@ static char count_real_packets(struct ethhdr *ethhdr,
/* copy primary address for bonding */
static void mark_bonding_address(struct orig_node *orig_node,
struct orig_node *orig_neigh_node,
- struct batman_packet *batman_packet)
+ struct batman_packet *batman_packet,
+ atomic_t *bonding_enabled)
{
/* don't care if bonding is not enabled */
- if (!atomic_read(&bonding_enabled)) {
+ if (!atomic_read(bonding_enabled)) {
orig_node->bond.candidates = 0;
return;
}
if (batman_packet->flags & PRIMARIES_FIRST_HOP)
memcpy(orig_neigh_node->primary_addr,
- orig_node->orig, ETH_ALEN);
- else
- return;
+ orig_node->orig, ETH_ALEN);
+
+ return;
}
/* mark possible bonding candidates in the neighbor list */
-void update_bonding_candidates(struct orig_node *orig_node)
+void update_bonding_candidates(struct orig_node *orig_node,
+ atomic_t *bonding_enabled)
{
int candidates;
int interference_candidate;
int best_tq;
struct neigh_node *tmp_neigh_node, *tmp_neigh_node2;
- struct neigh_node *first_candidate, *last_candidate;
+ struct neigh_node *first_candidate, *last_candidate;
/* don't care if bonding is not enabled */
- if (!atomic_read(&bonding_enabled)) {
+ if (!atomic_read(bonding_enabled)) {
orig_node->bond.candidates = 0;
return;
}
@@ -477,6 +479,8 @@ void receive_bat_packet(struct ethhdr *ethhdr,
unsigned char *hna_buff, int hna_buff_len,
struct batman_if *if_incoming)
{
+ /* FIXME: each orig_node->batman_if will be attached to a softif */
+ struct bat_priv *bat_priv = netdev_priv(soft_device);
struct batman_if *batman_if;
struct orig_node *orig_neigh_node, *orig_node;
char has_directlink_flag;
@@ -638,8 +642,9 @@ void receive_bat_packet(struct ethhdr *ethhdr,
update_orig(orig_node, ethhdr, batman_packet,
if_incoming, hna_buff, hna_buff_len, is_duplicate);
- mark_bonding_address(orig_node, orig_neigh_node, batman_packet);
- update_bonding_candidates(orig_node);
+ mark_bonding_address(orig_node, orig_neigh_node, batman_packet,
+ &bat_priv->bonding_enabled);
+ update_bonding_candidates(orig_node, &bat_priv->bonding_enabled);
/* is single hop (direct) neighbor */
if (is_single_hop_neigh) {
@@ -928,6 +933,8 @@ int recv_icmp_packet(struct sk_buff *skb)
* bonding if possible. */
struct neigh_node *find_router(struct orig_node *orig_node)
{
+ /* FIXME: each orig_node->batman_if will be attached to a softif */
+ struct bat_priv *bat_priv = netdev_priv(soft_device);
struct orig_node *primary_orig_node;
struct orig_node *router_orig;
struct neigh_node *router;
@@ -940,7 +947,7 @@ struct neigh_node *find_router(struct orig_node *orig_node)
return NULL;
/* don't care if bonding is not enabled */
- if (!atomic_read(&bonding_enabled))
+ if (!atomic_read(&bat_priv->bonding_enabled))
return orig_node->router;
router_orig = orig_node->router->orig_node;
diff --git a/batman-adv-kernelland/routing.h b/batman-adv-kernelland/routing.h
index 725779f..51f7a8b 100644
--- a/batman-adv-kernelland/routing.h
+++ b/batman-adv-kernelland/routing.h
@@ -38,4 +38,5 @@ int recv_vis_packet(struct sk_buff *skb);
int recv_bat_packet(struct sk_buff *skb,
struct batman_if *batman_if);
struct neigh_node *find_router(struct orig_node *orig_node);
-void update_bonding_candidates(struct orig_node *orig_node);
+void update_bonding_candidates(struct orig_node *orig_node,
+ atomic_t *bonding_enabled);
diff --git a/batman-adv-kernelland/send.c b/batman-adv-kernelland/send.c
index 3e63535..f692554 100644
--- a/batman-adv-kernelland/send.c
+++ b/batman-adv-kernelland/send.c
@@ -47,11 +47,11 @@ static unsigned long own_send_time(void)
}
/* when do we schedule a forwarded packet to be sent */
-static unsigned long forward_send_time(void)
+static unsigned long forward_send_time(atomic_t *aggregation_enabled)
{
unsigned long send_time = jiffies; /* Starting now plus... */
- if (atomic_read(&aggregation_enabled))
+ if (atomic_read(aggregation_enabled))
send_time += (((MAX_AGGREGATION_MS - (JITTER/2) +
(random32() % JITTER)) * HZ) / 1000);
else
@@ -249,6 +249,8 @@ static void rebuild_batman_packet(struct batman_if *batman_if)
void schedule_own_packet(struct batman_if *batman_if)
{
+ /* FIXME: each batman_if will be attached to a softif */
+ struct bat_priv *bat_priv = netdev_priv(soft_device);
unsigned long send_time;
struct batman_packet *batman_packet;
int vis_server = atomic_read(&vis_mode);
@@ -289,7 +291,9 @@ void schedule_own_packet(struct batman_if *batman_if)
slide_own_bcast_window(batman_if);
send_time = own_send_time();
add_bat_packet_to_list(batman_if->packet_buff,
- batman_if->packet_len, batman_if, 1, send_time);
+ batman_if->packet_len,
+ batman_if, 1, send_time,
+ &bat_priv->aggregation_enabled);
}
void schedule_forward_packet(struct orig_node *orig_node,
@@ -298,6 +302,8 @@ void schedule_forward_packet(struct orig_node *orig_node,
uint8_t directlink, int hna_buff_len,
struct batman_if *if_incoming)
{
+ /* FIXME: each batman_if will be attached to a softif */
+ struct bat_priv *bat_priv = netdev_priv(soft_device);
unsigned char in_tq, in_ttl, tq_avg = 0;
unsigned long send_time;
@@ -343,10 +349,11 @@ void schedule_forward_packet(struct orig_node *orig_node,
else
batman_packet->flags &= ~DIRECTLINK;
- send_time = forward_send_time();
+ send_time = forward_send_time(&bat_priv->aggregation_enabled);
add_bat_packet_to_list((unsigned char *)batman_packet,
sizeof(struct batman_packet) + hna_buff_len,
- if_incoming, 0, send_time);
+ if_incoming, 0, send_time,
+ &bat_priv->aggregation_enabled);
}
static void forw_packet_free(struct forw_packet *forw_packet)
diff --git a/batman-adv-kernelland/translation-table.c b/batman-adv-kernelland/translation-table.c
index 398a808..e118d59 100644
--- a/batman-adv-kernelland/translation-table.c
+++ b/batman-adv-kernelland/translation-table.c
@@ -157,23 +157,36 @@ int hna_local_fill_buffer(unsigned char *buff, int buff_len)
return i;
}
-int hna_local_fill_buffer_text(unsigned char *buff, int buff_len)
+int hna_local_fill_buffer_text(struct net_device *net_dev, char *buff,
+ size_t count, loff_t off)
{
struct hna_local_entry *hna_local_entry;
HASHIT(hashit);
int bytes_written = 0;
unsigned long flags;
+ size_t hdr_len;
+
+ hdr_len = sprintf(buff,
+ "Locally retrieved addresses (from %s) announced via HNA:\n",
+ net_dev->name);
+
+ if (off < hdr_len)
+ bytes_written = hdr_len;
spin_lock_irqsave(&hna_local_hash_lock, flags);
while (hash_iterate(hna_local_hash, &hashit)) {
+ hdr_len += 21;
- if (buff_len < bytes_written + ETH_STR_LEN + 4)
+ if (count < bytes_written + 22)
break;
+ if (off >= hdr_len)
+ continue;
+
hna_local_entry = hashit.bucket->data;
- bytes_written += snprintf(buff + bytes_written, ETH_STR_LEN + 4,
+ bytes_written += snprintf(buff + bytes_written, 22,
" * %02x:%02x:%02x:%02x:%02x:%02x\n",
hna_local_entry->addr[0],
hna_local_entry->addr[1],
@@ -184,7 +197,6 @@ int hna_local_fill_buffer_text(unsigned char *buff, int buff_len)
}
spin_unlock_irqrestore(&hna_local_hash_lock, flags);
-
return bytes_written;
}
@@ -349,24 +361,37 @@ void hna_global_add_orig(struct orig_node *orig_node,
spin_unlock_irqrestore(&hna_global_hash_lock, flags);
}
-int hna_global_fill_buffer_text(unsigned char *buff, int buff_len)
+int hna_global_fill_buffer_text(struct net_device *net_dev, char *buff,
+ size_t count, loff_t off)
{
struct hna_global_entry *hna_global_entry;
HASHIT(hashit);
int bytes_written = 0;
unsigned long flags;
+ size_t hdr_len;
+
+ hdr_len = sprintf(buff,
+ "Globally announced HNAs received via the mesh %s (translation table):\n",
+ net_dev->name);
+
+ if (off < hdr_len)
+ bytes_written = hdr_len;
spin_lock_irqsave(&hna_global_hash_lock, flags);
while (hash_iterate(hna_global_hash, &hashit)) {
- if (buff_len < bytes_written + (2 * ETH_STR_LEN) + 10)
+ hdr_len += 43;
+
+ if (count < bytes_written + 44)
break;
+ if (off >= hdr_len)
+ continue;
+
hna_global_entry = hashit.bucket->data;
- bytes_written += snprintf(buff + bytes_written,
- (2 * ETH_STR_LEN) + 10,
- " * %02x:%02x:%02x:%02x:%02x:%02x via %02x:%02x:%02x:%02x:%02x:%02x \n",
+ bytes_written += snprintf(buff + bytes_written, 44,
+ " * %02x:%02x:%02x:%02x:%02x:%02x via %02x:%02x:%02x:%02x:%02x:%02x\n",
hna_global_entry->addr[0],
hna_global_entry->addr[1],
hna_global_entry->addr[2],
@@ -382,7 +407,6 @@ int hna_global_fill_buffer_text(unsigned char *buff, int buff_len)
}
spin_unlock_irqrestore(&hna_global_hash_lock, flags);
-
return bytes_written;
}
diff --git a/batman-adv-kernelland/translation-table.h b/batman-adv-kernelland/translation-table.h
index 281125b..fc1be65 100644
--- a/batman-adv-kernelland/translation-table.h
+++ b/batman-adv-kernelland/translation-table.h
@@ -25,13 +25,15 @@ int hna_local_init(void);
void hna_local_add(uint8_t *addr);
void hna_local_remove(uint8_t *addr, char *message);
int hna_local_fill_buffer(unsigned char *buff, int buff_len);
-int hna_local_fill_buffer_text(unsigned char *buff, int buff_len);
+int hna_local_fill_buffer_text(struct net_device *net_dev, char *buff,
+ size_t count, loff_t off);
void hna_local_purge(struct work_struct *work);
void hna_local_free(void);
int hna_global_init(void);
void hna_global_add_orig(struct orig_node *orig_node, unsigned char *hna_buff,
int hna_buff_len);
-int hna_global_fill_buffer_text(unsigned char *buff, int buff_len);
+int hna_global_fill_buffer_text(struct net_device *net_dev, char *buff,
+ size_t count, loff_t off);
void _hna_global_del_orig(struct hna_global_entry *hna_global_entry,
char *orig_str);
void hna_global_del_orig(struct orig_node *orig_node, char *message);
diff --git a/batman-adv-kernelland/types.h b/batman-adv-kernelland/types.h
index a82b52d..feb3343 100644
--- a/batman-adv-kernelland/types.h
+++ b/batman-adv-kernelland/types.h
@@ -94,6 +94,9 @@ struct neigh_node {
struct bat_priv {
struct net_device_stats stats;
+ atomic_t aggregation_enabled;
+ atomic_t bonding_enabled;
+ struct kobject *mesh_obj;
};
struct device_client {
--
1.6.6.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Marek Lindner
@ 2010-02-27 20:30 ` Marek Lindner
2010-03-01 1:51 ` Linus Lüssing
2010-02-28 9:37 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Andrew Lunn
2010-02-28 17:47 ` Gus Wirth
2 siblings, 1 reply; 10+ messages in thread
From: Marek Lindner @ 2010-02-27 20:30 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
batman-adv is in the process of migrating to sysfs, hence batctl needs
to adapt the file paths. In addition batctl makes use of the input
validation support of the new files in sysfs.
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
batctl/functions.c | 9 +++-
batctl/functions.h | 3 +
batctl/main.c | 8 ++--
batctl/proc.c | 34 ---------------
batctl/proc.h | 4 --
batctl/sys.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++-
batctl/sys.h | 10 +++-
7 files changed, 141 insertions(+), 48 deletions(-)
diff --git a/batctl/functions.c b/batctl/functions.c
index 2ead2fc..cf4d264 100644
--- a/batctl/functions.c
+++ b/batctl/functions.c
@@ -35,8 +35,6 @@
#include "functions.h"
#include "bat-hosts.h"
-#define BATMAN_ADV_TAG "batman-adv:"
-
static struct timeval start_time;
static char *host_name;
char *line_ptr = NULL;
@@ -174,6 +172,13 @@ open:
read:
while ((read = getline(&line_ptr, &len, fp)) != -1) {
+ if (read_opt & SEARCH_ARGS) {
+ /* omit log lines which don't start with the correct tag */
+ if (strncmp(line_ptr, SEARCH_ARGS_TAG, strlen(SEARCH_ARGS_TAG)) == 0)
+ break;
+
+ continue;
+ }
/* the buffer will be handled elsewhere */
if (read_opt & USE_READ_BUFF)
diff --git a/batctl/functions.h b/batctl/functions.h
index 88fa53b..c21e9a3 100644
--- a/batctl/functions.h
+++ b/batctl/functions.h
@@ -25,6 +25,8 @@
#define ETH_STR_LEN 17
+#define BATMAN_ADV_TAG "batman-adv:"
+#define SEARCH_ARGS_TAG "commands:"
/* return time delta from start to end in milliseconds */
void start_timer(void);
@@ -45,4 +47,5 @@ enum {
USE_BAT_HOSTS = 0x04,
LOG_MODE = 0x08,
USE_READ_BUFF = 0x10,
+ SEARCH_ARGS = 0x20,
};
diff --git a/batctl/main.c b/batctl/main.c
index 6e4493d..99bfb5b 100644
--- a/batctl/main.c
+++ b/batctl/main.c
@@ -102,15 +102,15 @@ int main(int argc, char **argv)
} else if ((strcmp(argv[1], "originators") == 0) || (strcmp(argv[1], "o") == 0)) {
- ret = handle_table(argc - 1, argv + 1, PROC_ORIGINATORS, originators_usage);
+ ret = handle_sys_table(argc - 1, argv + 1, SYS_ORIGINATORS, originators_usage);
} else if ((strcmp(argv[1], "translocal") == 0) || (strcmp(argv[1], "tl") == 0)) {
- ret = handle_table(argc - 1, argv + 1, PROC_TRANSTABLE_LOCAL, trans_local_usage);
+ ret = handle_sys_table(argc - 1, argv + 1, SYS_TRANSTABLE_LOCAL, trans_local_usage);
} else if ((strcmp(argv[1], "transglobal") == 0) || (strcmp(argv[1], "tg") == 0)) {
- ret = handle_table(argc - 1, argv + 1, PROC_TRANSTABLE_GLOBAL, trans_global_usage);
+ ret = handle_sys_table(argc - 1, argv + 1, SYS_TRANSTABLE_GLOBAL, trans_global_usage);
} else if ((strcmp(argv[1], "loglevel") == 0) || (strcmp(argv[1], "ll") == 0)) {
@@ -142,7 +142,7 @@ int main(int argc, char **argv)
} else if ((strcmp(argv[1], "aggregation") == 0) || (strcmp(argv[1], "ag") == 0)) {
- ret = handle_proc_setting(argc - 1, argv + 1, PROC_AGGR, aggregation_usage);
+ ret = handle_sys_setting(argc - 1, argv + 1, SYS_AGGR, aggregation_usage);
} else if ((strcmp(argv[1], "bisect") == 0)) {
diff --git a/batctl/proc.c b/batctl/proc.c
index 3294662..e323a52 100644
--- a/batctl/proc.c
+++ b/batctl/proc.c
@@ -68,33 +68,6 @@ int interface(int argc, char **argv)
return EXIT_SUCCESS;
}
-void originators_usage(void)
-{
- printf("Usage: batctl [options] originators \n");
- printf("options:\n");
- printf(" \t -h print this help\n");
- printf(" \t -n don't replace mac addresses with bat-host names\n");
- printf(" \t -w watch mode - refresh the originator table continuously\n");
-}
-
-void trans_local_usage(void)
-{
- printf("Usage: batctl [options] translocal \n");
- printf("options:\n");
- printf(" \t -h print this help\n");
- printf(" \t -n don't replace mac addresses with bat-host names\n");
- printf(" \t -w watch mode - refresh the local translation table continuously\n");
-}
-
-void trans_global_usage(void)
-{
- printf("Usage: batctl [options] transglobal \n");
- printf("options:\n");
- printf(" \t -h print this help\n");
- printf(" \t -n don't replace mac addresses with bat-host names\n");
- printf(" \t -w watch mode - refresh the global translation table continuously\n");
-}
-
void gw_srv_list_usage(void)
{
printf("Usage: batctl [options] gw_srv_list \n");
@@ -118,13 +91,6 @@ void vis_server_usage(void)
printf(" \t -h print this help\n");
}
-void aggregation_usage(void)
-{
- printf("Usage: batctl [options] aggregation \n");
- printf("options:\n");
- printf(" \t -h print this help\n");
-}
-
void gw_mode_usage(void)
{
printf("Usage: batctl [options] gw_mode [mode]\n");
diff --git a/batctl/proc.h b/batctl/proc.h
index d867b78..74ac398 100644
--- a/batctl/proc.h
+++ b/batctl/proc.h
@@ -21,13 +21,9 @@
#define PROC_ROOT_PATH "/proc/net/batman-adv/"
#define PROC_INTERFACES "interfaces"
-#define PROC_ORIGINATORS "originators"
#define PROC_ORIG_INTERVAL "orig_interval"
-#define PROC_TRANSTABLE_LOCAL "transtable_local"
-#define PROC_TRANSTABLE_GLOBAL "transtable_global"
#define PROC_VIS_SERVER "vis_server"
#define PROC_VIS_DATA "vis_data"
-#define PROC_AGGR "aggregate_ogm"
#define PROC_GW_MODE "gateway_mode"
#define PROC_GW_SRV_LIST "gateway_srv_list"
diff --git a/batctl/sys.c b/batctl/sys.c
index d67a915..65f1ebd 100644
--- a/batctl/sys.c
+++ b/batctl/sys.c
@@ -94,11 +94,11 @@ int handle_loglevel(int argc, char **argv)
}
if (argc != 1) {
- res = write_file(SYS_ROOT_PATH, SYS_LOG_LEVEL, argv[1]);
+ res = write_file(SYS_MODULE_PATH, SYS_LOG_LEVEL, argv[1]);
goto out;
}
- res = read_file(SYS_ROOT_PATH, SYS_LOG_LEVEL, SINGLE_READ | USE_READ_BUFF);
+ res = read_file(SYS_MODULE_PATH, SYS_LOG_LEVEL, SINGLE_READ | USE_READ_BUFF);
if (res != EXIT_SUCCESS)
goto out;
@@ -118,3 +118,120 @@ out:
return res;
}
+
+void originators_usage(void)
+{
+ printf("Usage: batctl [options] originators \n");
+ printf("options:\n");
+ printf(" \t -h print this help\n");
+ printf(" \t -n don't replace mac addresses with bat-host names\n");
+ printf(" \t -w watch mode - refresh the originator table continuously\n");
+}
+
+void trans_local_usage(void)
+{
+ printf("Usage: batctl [options] translocal \n");
+ printf("options:\n");
+ printf(" \t -h print this help\n");
+ printf(" \t -n don't replace mac addresses with bat-host names\n");
+ printf(" \t -w watch mode - refresh the local translation table continuously\n");
+}
+
+void trans_global_usage(void)
+{
+ printf("Usage: batctl [options] transglobal \n");
+ printf("options:\n");
+ printf(" \t -h print this help\n");
+ printf(" \t -n don't replace mac addresses with bat-host names\n");
+ printf(" \t -w watch mode - refresh the global translation table continuously\n");
+}
+
+int handle_sys_table(int argc, char **argv, char *file_path, void table_usage(void))
+{
+ int optchar, read_opt = USE_BAT_HOSTS;
+
+ while ((optchar = getopt(argc, argv, "hnw")) != -1) {
+ switch (optchar) {
+ case 'h':
+ table_usage();
+ return EXIT_SUCCESS;
+ case 'n':
+ read_opt &= ~USE_BAT_HOSTS;
+ break;
+ case 'w':
+ read_opt |= CLR_CONT_READ;
+ break;
+ default:
+ table_usage();
+ return EXIT_FAILURE;
+ }
+ }
+
+ return read_file(SYS_BATIF_PATH, file_path, read_opt);
+}
+
+void aggregation_usage(void)
+{
+ printf("Usage: batctl [options] aggregation \n");
+ printf("options:\n");
+ printf(" \t -h print this help\n");
+}
+
+int handle_sys_setting(int argc, char **argv, char *file_path, void setting_usage(void))
+{
+ int optchar, res;
+ char *space_ptr, *comma_char, *cmds = NULL;
+
+ while ((optchar = getopt(argc, argv, "h")) != -1) {
+ switch (optchar) {
+ case 'h':
+ setting_usage();
+ return EXIT_SUCCESS;
+ default:
+ setting_usage();
+ return EXIT_FAILURE;
+ }
+ }
+
+ if (argc == 1)
+ return read_file(SYS_BATIF_PATH, file_path, SINGLE_READ);
+
+ res = read_file(SYS_BATIF_PATH, file_path, SEARCH_ARGS);
+ if (res != EXIT_SUCCESS)
+ return res;
+
+ while ((space_ptr = strchr(line_ptr, ' ')) != NULL) {
+ *space_ptr = '\0';
+
+ if (strncmp(line_ptr, SEARCH_ARGS_TAG, strlen(SEARCH_ARGS_TAG)) == 0) {
+ cmds = space_ptr + 1;
+ goto next;
+ }
+
+ comma_char = NULL;
+ if (line_ptr[strlen(line_ptr) - 1] == ',') {
+ comma_char = line_ptr + strlen(line_ptr) - 1;
+ *comma_char = '\0';
+ }
+
+ if (strcmp(line_ptr, argv[1]) == 0)
+ goto write_file;
+
+ *space_ptr = ' ';
+ if (comma_char)
+ *comma_char = ',';
+
+next:
+ line_ptr = space_ptr + 1;
+ }
+
+ if (!cmds)
+ goto write_file;
+
+ printf("Error - the supplied argument is invalid: %s\n", argv[1]);
+ printf("The following values are allowed: %s", cmds);
+ return EXIT_FAILURE;
+
+write_file:
+ return write_file(SYS_BATIF_PATH, file_path, argv[1]);
+}
diff --git a/batctl/sys.h b/batctl/sys.h
index 812da63..0d6f334 100644
--- a/batctl/sys.h
+++ b/batctl/sys.h
@@ -20,10 +20,16 @@
*/
-#define SYS_ROOT_PATH "/sys/module/batman_adv/"
+#define SYS_MODULE_PATH "/sys/module/batman_adv/"
+#define SYS_BATIF_PATH "/sys/devices/virtual/net/bat0/mesh/"
#define SYS_LOG_LEVEL "parameters/debug"
#define SYS_LOG "log"
-
+#define SYS_ORIGINATORS "originators"
+#define SYS_TRANSTABLE_LOCAL "transtable_local"
+#define SYS_TRANSTABLE_GLOBAL "transtable_global"
+#define SYS_AGGR "aggregate_ogm"
int log_print(int argc, char **argv);
int handle_loglevel(int argc, char **argv);
+int handle_sys_table(int argc, char **argv, char *file_path, void table_usage(void));
+int handle_sys_setting(int argc, char **argv, char *file_path, void setting_usage(void));
--
1.6.6.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Marek Lindner
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation Marek Lindner
@ 2010-02-28 9:37 ` Andrew Lunn
2010-02-28 10:19 ` Marek Lindner
2010-02-28 17:47 ` Gus Wirth
2 siblings, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2010-02-28 9:37 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking; +Cc: Marek Lindner
Hi Marek
I've not looked into the details yet, just a quick glans. However
maybe we should discuss this point:
> @@ -249,6 +249,8 @@ static void rebuild_batman_packet(struct batman_if *batman_if)
>
> void schedule_own_packet(struct batman_if *batman_if)
> {
> + /* FIXME: each batman_if will be attached to a softif */
> + struct bat_priv *bat_priv = netdev_priv(soft_device);
> unsigned long send_time;
> struct batman_packet *batman_packet;
> int vis_server = atomic_read(&vis_mode);
> @@ -289,7 +291,9 @@ void schedule_own_packet(struct batman_if *batman_if)
> slide_own_bcast_window(batman_if);
> send_time = own_send_time();
> add_bat_packet_to_list(batman_if->packet_buff,
> - batman_if->packet_len, batman_if, 1, send_time);
> + batman_if->packet_len,
> + batman_if, 1, send_time,
> + &bat_priv->aggregation_enabled);
> }
> struct bat_priv {
> struct net_device_stats stats;
> + atomic_t aggregation_enabled;
> + atomic_t bonding_enabled;
> + struct kobject *mesh_obj;
> };
With time i expect that bat_priv will gain many more members as global
variables are replaced with variables per mesh. Rather than passing to
functions a member, pass the pointer and let the function dereference
it. I think it will make the APIs neater in the long run.
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs
2010-02-28 9:37 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Andrew Lunn
@ 2010-02-28 10:19 ` Marek Lindner
0 siblings, 0 replies; 10+ messages in thread
From: Marek Lindner @ 2010-02-28 10:19 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Sunday 28 February 2010 17:37:28 Andrew Lunn wrote:
> With time i expect that bat_priv will gain many more members as global
> variables are replaced with variables per mesh. Rather than passing to
> functions a member, pass the pointer and let the function dereference
> it. I think it will make the APIs neater in the long run.
I agree - in the long run that will be better. I'll put that onto my todo
list.
Regards,
Marek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Marek Lindner
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation Marek Lindner
2010-02-28 9:37 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Andrew Lunn
@ 2010-02-28 17:47 ` Gus Wirth
2 siblings, 0 replies; 10+ messages in thread
From: Gus Wirth @ 2010-02-28 17:47 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On 02/27/2010 12:30 PM, Marek Lindner wrote:
> This is the first patch in a series of patches which aim to convert
> all batman-adv /proc files to sysfs. To keep the changes in a
> digestable size it has been split up into smaller chunks. During
> the transition period batman-adv will use /proc as well as sysfs.
[snip]
> index 0000000..9502cf6
> --- /dev/null
> +++ b/batman-adv-kernelland/bat_sysfs.c
> @@ -0,0 +1,318 @@
> +/*
> + * Copyright (C) 20010 B.A.T.M.A.N. contributors:
^
I know you're looking toward the future but isn't 20000 years a bit much?
Gus
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation Marek Lindner
@ 2010-03-01 1:51 ` Linus Lüssing
2010-03-01 6:06 ` Andrew Lunn
2010-03-01 7:27 ` Marek Lindner
0 siblings, 2 replies; 10+ messages in thread
From: Linus Lüssing @ 2010-03-01 1:51 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
[-- Attachment #1: Type: text/plain, Size: 11291 bytes --]
Hi Marek!
I like :). This already looks well structured for introducing more
than one bat-interface later. On the first test, I found two
smaller issues:
Just noticed, that I don't have this /sys/devices/virtual folder
on my Debian stable VM. But I think we should be on the safe side
to use
#define SYS_BATIF_PATH "/sys/class/net/bat0/mesh/"
instead, they look equivalent and I'm having them both avaiable on
Debian stable (2.6.26 kernel) and Debian unstable (2.6.32 kernel).
The second thing is, I'm getting two harmless compile time
warnings on the Debian stable VM here:
- bat-hosts.c:79/functions.c:174: warning: implicit declaration of function
getline
Cheers, Linus
On Sun, Feb 28, 2010 at 04:30:49AM +0800, Marek Lindner wrote:
> batman-adv is in the process of migrating to sysfs, hence batctl needs
> to adapt the file paths. In addition batctl makes use of the input
> validation support of the new files in sysfs.
>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> ---
> batctl/functions.c | 9 +++-
> batctl/functions.h | 3 +
> batctl/main.c | 8 ++--
> batctl/proc.c | 34 ---------------
> batctl/proc.h | 4 --
> batctl/sys.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> batctl/sys.h | 10 +++-
> 7 files changed, 141 insertions(+), 48 deletions(-)
>
> diff --git a/batctl/functions.c b/batctl/functions.c
> index 2ead2fc..cf4d264 100644
> --- a/batctl/functions.c
> +++ b/batctl/functions.c
> @@ -35,8 +35,6 @@
> #include "functions.h"
> #include "bat-hosts.h"
>
> -#define BATMAN_ADV_TAG "batman-adv:"
> -
> static struct timeval start_time;
> static char *host_name;
> char *line_ptr = NULL;
> @@ -174,6 +172,13 @@ open:
>
> read:
> while ((read = getline(&line_ptr, &len, fp)) != -1) {
> + if (read_opt & SEARCH_ARGS) {
> + /* omit log lines which don't start with the correct tag */
> + if (strncmp(line_ptr, SEARCH_ARGS_TAG, strlen(SEARCH_ARGS_TAG)) == 0)
> + break;
> +
> + continue;
> + }
>
> /* the buffer will be handled elsewhere */
> if (read_opt & USE_READ_BUFF)
> diff --git a/batctl/functions.h b/batctl/functions.h
> index 88fa53b..c21e9a3 100644
> --- a/batctl/functions.h
> +++ b/batctl/functions.h
> @@ -25,6 +25,8 @@
>
>
> #define ETH_STR_LEN 17
> +#define BATMAN_ADV_TAG "batman-adv:"
> +#define SEARCH_ARGS_TAG "commands:"
>
> /* return time delta from start to end in milliseconds */
> void start_timer(void);
> @@ -45,4 +47,5 @@ enum {
> USE_BAT_HOSTS = 0x04,
> LOG_MODE = 0x08,
> USE_READ_BUFF = 0x10,
> + SEARCH_ARGS = 0x20,
> };
> diff --git a/batctl/main.c b/batctl/main.c
> index 6e4493d..99bfb5b 100644
> --- a/batctl/main.c
> +++ b/batctl/main.c
> @@ -102,15 +102,15 @@ int main(int argc, char **argv)
>
> } else if ((strcmp(argv[1], "originators") == 0) || (strcmp(argv[1], "o") == 0)) {
>
> - ret = handle_table(argc - 1, argv + 1, PROC_ORIGINATORS, originators_usage);
> + ret = handle_sys_table(argc - 1, argv + 1, SYS_ORIGINATORS, originators_usage);
>
> } else if ((strcmp(argv[1], "translocal") == 0) || (strcmp(argv[1], "tl") == 0)) {
>
> - ret = handle_table(argc - 1, argv + 1, PROC_TRANSTABLE_LOCAL, trans_local_usage);
> + ret = handle_sys_table(argc - 1, argv + 1, SYS_TRANSTABLE_LOCAL, trans_local_usage);
>
> } else if ((strcmp(argv[1], "transglobal") == 0) || (strcmp(argv[1], "tg") == 0)) {
>
> - ret = handle_table(argc - 1, argv + 1, PROC_TRANSTABLE_GLOBAL, trans_global_usage);
> + ret = handle_sys_table(argc - 1, argv + 1, SYS_TRANSTABLE_GLOBAL, trans_global_usage);
>
> } else if ((strcmp(argv[1], "loglevel") == 0) || (strcmp(argv[1], "ll") == 0)) {
>
> @@ -142,7 +142,7 @@ int main(int argc, char **argv)
>
> } else if ((strcmp(argv[1], "aggregation") == 0) || (strcmp(argv[1], "ag") == 0)) {
>
> - ret = handle_proc_setting(argc - 1, argv + 1, PROC_AGGR, aggregation_usage);
> + ret = handle_sys_setting(argc - 1, argv + 1, SYS_AGGR, aggregation_usage);
>
> } else if ((strcmp(argv[1], "bisect") == 0)) {
>
> diff --git a/batctl/proc.c b/batctl/proc.c
> index 3294662..e323a52 100644
> --- a/batctl/proc.c
> +++ b/batctl/proc.c
> @@ -68,33 +68,6 @@ int interface(int argc, char **argv)
> return EXIT_SUCCESS;
> }
>
> -void originators_usage(void)
> -{
> - printf("Usage: batctl [options] originators \n");
> - printf("options:\n");
> - printf(" \t -h print this help\n");
> - printf(" \t -n don't replace mac addresses with bat-host names\n");
> - printf(" \t -w watch mode - refresh the originator table continuously\n");
> -}
> -
> -void trans_local_usage(void)
> -{
> - printf("Usage: batctl [options] translocal \n");
> - printf("options:\n");
> - printf(" \t -h print this help\n");
> - printf(" \t -n don't replace mac addresses with bat-host names\n");
> - printf(" \t -w watch mode - refresh the local translation table continuously\n");
> -}
> -
> -void trans_global_usage(void)
> -{
> - printf("Usage: batctl [options] transglobal \n");
> - printf("options:\n");
> - printf(" \t -h print this help\n");
> - printf(" \t -n don't replace mac addresses with bat-host names\n");
> - printf(" \t -w watch mode - refresh the global translation table continuously\n");
> -}
> -
> void gw_srv_list_usage(void)
> {
> printf("Usage: batctl [options] gw_srv_list \n");
> @@ -118,13 +91,6 @@ void vis_server_usage(void)
> printf(" \t -h print this help\n");
> }
>
> -void aggregation_usage(void)
> -{
> - printf("Usage: batctl [options] aggregation \n");
> - printf("options:\n");
> - printf(" \t -h print this help\n");
> -}
> -
> void gw_mode_usage(void)
> {
> printf("Usage: batctl [options] gw_mode [mode]\n");
> diff --git a/batctl/proc.h b/batctl/proc.h
> index d867b78..74ac398 100644
> --- a/batctl/proc.h
> +++ b/batctl/proc.h
> @@ -21,13 +21,9 @@
>
> #define PROC_ROOT_PATH "/proc/net/batman-adv/"
> #define PROC_INTERFACES "interfaces"
> -#define PROC_ORIGINATORS "originators"
> #define PROC_ORIG_INTERVAL "orig_interval"
> -#define PROC_TRANSTABLE_LOCAL "transtable_local"
> -#define PROC_TRANSTABLE_GLOBAL "transtable_global"
> #define PROC_VIS_SERVER "vis_server"
> #define PROC_VIS_DATA "vis_data"
> -#define PROC_AGGR "aggregate_ogm"
> #define PROC_GW_MODE "gateway_mode"
> #define PROC_GW_SRV_LIST "gateway_srv_list"
>
> diff --git a/batctl/sys.c b/batctl/sys.c
> index d67a915..65f1ebd 100644
> --- a/batctl/sys.c
> +++ b/batctl/sys.c
> @@ -94,11 +94,11 @@ int handle_loglevel(int argc, char **argv)
> }
>
> if (argc != 1) {
> - res = write_file(SYS_ROOT_PATH, SYS_LOG_LEVEL, argv[1]);
> + res = write_file(SYS_MODULE_PATH, SYS_LOG_LEVEL, argv[1]);
> goto out;
> }
>
> - res = read_file(SYS_ROOT_PATH, SYS_LOG_LEVEL, SINGLE_READ | USE_READ_BUFF);
> + res = read_file(SYS_MODULE_PATH, SYS_LOG_LEVEL, SINGLE_READ | USE_READ_BUFF);
>
> if (res != EXIT_SUCCESS)
> goto out;
> @@ -118,3 +118,120 @@ out:
>
> return res;
> }
> +
> +void originators_usage(void)
> +{
> + printf("Usage: batctl [options] originators \n");
> + printf("options:\n");
> + printf(" \t -h print this help\n");
> + printf(" \t -n don't replace mac addresses with bat-host names\n");
> + printf(" \t -w watch mode - refresh the originator table continuously\n");
> +}
> +
> +void trans_local_usage(void)
> +{
> + printf("Usage: batctl [options] translocal \n");
> + printf("options:\n");
> + printf(" \t -h print this help\n");
> + printf(" \t -n don't replace mac addresses with bat-host names\n");
> + printf(" \t -w watch mode - refresh the local translation table continuously\n");
> +}
> +
> +void trans_global_usage(void)
> +{
> + printf("Usage: batctl [options] transglobal \n");
> + printf("options:\n");
> + printf(" \t -h print this help\n");
> + printf(" \t -n don't replace mac addresses with bat-host names\n");
> + printf(" \t -w watch mode - refresh the global translation table continuously\n");
> +}
> +
> +int handle_sys_table(int argc, char **argv, char *file_path, void table_usage(void))
> +{
> + int optchar, read_opt = USE_BAT_HOSTS;
> +
> + while ((optchar = getopt(argc, argv, "hnw")) != -1) {
> + switch (optchar) {
> + case 'h':
> + table_usage();
> + return EXIT_SUCCESS;
> + case 'n':
> + read_opt &= ~USE_BAT_HOSTS;
> + break;
> + case 'w':
> + read_opt |= CLR_CONT_READ;
> + break;
> + default:
> + table_usage();
> + return EXIT_FAILURE;
> + }
> + }
> +
> + return read_file(SYS_BATIF_PATH, file_path, read_opt);
> +}
> +
> +void aggregation_usage(void)
> +{
> + printf("Usage: batctl [options] aggregation \n");
> + printf("options:\n");
> + printf(" \t -h print this help\n");
> +}
> +
> +int handle_sys_setting(int argc, char **argv, char *file_path, void setting_usage(void))
> +{
> + int optchar, res;
> + char *space_ptr, *comma_char, *cmds = NULL;
> +
> + while ((optchar = getopt(argc, argv, "h")) != -1) {
> + switch (optchar) {
> + case 'h':
> + setting_usage();
> + return EXIT_SUCCESS;
> + default:
> + setting_usage();
> + return EXIT_FAILURE;
> + }
> + }
> +
> + if (argc == 1)
> + return read_file(SYS_BATIF_PATH, file_path, SINGLE_READ);
> +
> + res = read_file(SYS_BATIF_PATH, file_path, SEARCH_ARGS);
> + if (res != EXIT_SUCCESS)
> + return res;
> +
> + while ((space_ptr = strchr(line_ptr, ' ')) != NULL) {
> + *space_ptr = '\0';
> +
> + if (strncmp(line_ptr, SEARCH_ARGS_TAG, strlen(SEARCH_ARGS_TAG)) == 0) {
> + cmds = space_ptr + 1;
> + goto next;
> + }
> +
> + comma_char = NULL;
> + if (line_ptr[strlen(line_ptr) - 1] == ',') {
> + comma_char = line_ptr + strlen(line_ptr) - 1;
> + *comma_char = '\0';
> + }
> +
> + if (strcmp(line_ptr, argv[1]) == 0)
> + goto write_file;
> +
> + *space_ptr = ' ';
> + if (comma_char)
> + *comma_char = ',';
> +
> +next:
> + line_ptr = space_ptr + 1;
> + }
> +
> + if (!cmds)
> + goto write_file;
> +
> + printf("Error - the supplied argument is invalid: %s\n", argv[1]);
> + printf("The following values are allowed: %s", cmds);
> + return EXIT_FAILURE;
> +
> +write_file:
> + return write_file(SYS_BATIF_PATH, file_path, argv[1]);
> +}
> diff --git a/batctl/sys.h b/batctl/sys.h
> index 812da63..0d6f334 100644
> --- a/batctl/sys.h
> +++ b/batctl/sys.h
> @@ -20,10 +20,16 @@
> */
>
>
> -#define SYS_ROOT_PATH "/sys/module/batman_adv/"
> +#define SYS_MODULE_PATH "/sys/module/batman_adv/"
> +#define SYS_BATIF_PATH "/sys/devices/virtual/net/bat0/mesh/"
> #define SYS_LOG_LEVEL "parameters/debug"
> #define SYS_LOG "log"
> -
> +#define SYS_ORIGINATORS "originators"
> +#define SYS_TRANSTABLE_LOCAL "transtable_local"
> +#define SYS_TRANSTABLE_GLOBAL "transtable_global"
> +#define SYS_AGGR "aggregate_ogm"
>
> int log_print(int argc, char **argv);
> int handle_loglevel(int argc, char **argv);
> +int handle_sys_table(int argc, char **argv, char *file_path, void table_usage(void));
> +int handle_sys_setting(int argc, char **argv, char *file_path, void setting_usage(void));
> --
> 1.6.6.2
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation
2010-03-01 1:51 ` Linus Lüssing
@ 2010-03-01 6:06 ` Andrew Lunn
2010-03-01 7:17 ` Marek Lindner
2010-03-01 7:27 ` Marek Lindner
1 sibling, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2010-03-01 6:06 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
> The second thing is, I'm getting two harmless compile time
> warnings on the Debian stable VM here:
> - bat-hosts.c:79/functions.c:174: warning: implicit declaration of function
> getline
getline(3) is a GNU extension. The man page says:
#define _GNU_SOURCE
#include <stdio.h>
ssize_t getline(char **lineptr, size_t *n, FILE *stream);
I guess it compiles fine on uclibc without the _GNU_SOURCE, but glibc
wants you to explicitly enable the extension so you know you are not
POSIX compatible.
BTW: batctl has used this for a while now. Anybody had problems with
this GNU extension? Is it available for all the C libraries used in
embedded systems which use BATMAN?
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation
2010-03-01 6:06 ` Andrew Lunn
@ 2010-03-01 7:17 ` Marek Lindner
0 siblings, 0 replies; 10+ messages in thread
From: Marek Lindner @ 2010-03-01 7:17 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Monday 01 March 2010 14:06:51 Andrew Lunn wrote:
> BTW: batctl has used this for a while now. Anybody had problems with
> this GNU extension? Is it available for all the C libraries used in
> embedded systems which use BATMAN?
I used it since a while on OpenWRT and it works fine for me.
Cheers,
Marek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation
2010-03-01 1:51 ` Linus Lüssing
2010-03-01 6:06 ` Andrew Lunn
@ 2010-03-01 7:27 ` Marek Lindner
1 sibling, 0 replies; 10+ messages in thread
From: Marek Lindner @ 2010-03-01 7:27 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
Hey,
> I like :). This already looks well structured for introducing more
> than one bat-interface later.
glad to hear that! :)
> Just noticed, that I don't have this /sys/devices/virtual folder
> on my Debian stable VM. But I think we should be on the safe side
> to use
> #define SYS_BATIF_PATH "/sys/class/net/bat0/mesh/"
> instead, they look equivalent and I'm having them both avaiable on
> Debian stable (2.6.26 kernel) and Debian unstable (2.6.32 kernel).
The path "/sys/class" simply contains symlinks to the real paths. On my
OpenWRT it looks like this:
ls -l /sys/class/net/
bat0 -> ../../devices/virtual/net/bat0
br-lan -> ../../devices/virtual/net/br-lan
lo -> ../../devices/virtual/net/lo
If the virtual path does not exist on your debian where does the symlink point
to ? Btw, on my debian (2.6.32) the virtual path exists but we use
/sys/class/net instead to be on the safe side.
Regards,
Marek
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-03-01 7:27 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-27 20:30 [B.A.T.M.A.N.] reorganized kernel interface Marek Lindner
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Marek Lindner
2010-02-27 20:30 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: follow /proc to sysfs conversion & introduce input validation Marek Lindner
2010-03-01 1:51 ` Linus Lüssing
2010-03-01 6:06 ` Andrew Lunn
2010-03-01 7:17 ` Marek Lindner
2010-03-01 7:27 ` Marek Lindner
2010-02-28 9:37 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs Andrew Lunn
2010-02-28 10:19 ` Marek Lindner
2010-02-28 17:47 ` Gus Wirth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).