* [B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings
@ 2010-10-23 15:11 Marek Lindner
2010-10-23 15:19 ` Sven Eckelmann
0 siblings, 1 reply; 3+ messages in thread
From: Marek Lindner @ 2010-10-23 15:11 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
batman-adv/bat_debugfs.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c
index 11e5f65..934c879 100644
--- a/batman-adv/bat_debugfs.c
+++ b/batman-adv/bat_debugfs.c
@@ -57,7 +57,6 @@ static int fdebug_log(struct debug_log *debug_log, char *fmt, ...)
va_list args;
static char debug_log_buf[256];
char *p;
- unsigned long flags;
if (!debug_log)
return 0;
@@ -113,7 +112,6 @@ static ssize_t log_read(struct file *file, char __user *buf,
struct debug_log *debug_log = bat_priv->debug_log;
int error, i = 0;
char c;
- unsigned long flags;
if ((file->f_flags & O_NONBLOCK) &&
!(debug_log->log_end - debug_log->log_start))
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings
2010-10-23 15:11 [B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings Marek Lindner
@ 2010-10-23 15:19 ` Sven Eckelmann
2010-10-23 15:21 ` Marek Lindner
0 siblings, 1 reply; 3+ messages in thread
From: Sven Eckelmann @ 2010-10-23 15:19 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
[-- Attachment #1: Type: Text/Plain, Size: 993 bytes --]
Marek Lindner wrote:
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> ---
> batman-adv/bat_debugfs.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c
> index 11e5f65..934c879 100644
> --- a/batman-adv/bat_debugfs.c
> +++ b/batman-adv/bat_debugfs.c
> @@ -57,7 +57,6 @@ static int fdebug_log(struct debug_log *debug_log, char
> *fmt, ...) va_list args;
> static char debug_log_buf[256];
> char *p;
> - unsigned long flags;
>
> if (!debug_log)
> return 0;
> @@ -113,7 +112,6 @@ static ssize_t log_read(struct file *file, char __user
> *buf, struct debug_log *debug_log = bat_priv->debug_log;
> int error, i = 0;
> char c;
> - unsigned long flags;
>
> if ((file->f_flags & O_NONBLOCK) &&
> !(debug_log->log_end - debug_log->log_start))
Correct. Forgot them because I only build it in non-debug mode.
Acked-by: Sven Eckelmann <sven.eckelmann@gmx.de>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings
2010-10-23 15:19 ` Sven Eckelmann
@ 2010-10-23 15:21 ` Marek Lindner
0 siblings, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2010-10-23 15:21 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Saturday 23 October 2010 17:19:21 Sven Eckelmann wrote:
> Correct. Forgot them because I only build it in non-debug mode.
Same here - I missed these warnings when I checked your patch before
submitting it. Just applied this patch (revision 1848).
Regards,
Marek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-23 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-23 15:11 [B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings Marek Lindner
2010-10-23 15:19 ` Sven Eckelmann
2010-10-23 15:21 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).