* [B.A.T.M.A.N.] [PATCH] batman-adv: Remove useless braces
@ 2010-10-23 22:42 Sven Eckelmann
2010-10-25 13:02 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2010-10-23 22:42 UTC (permalink / raw)
To: b.a.t.m.a.n
54466268785c9892d6e2af2ac2a54a684face022 added changes to vis.c which
trigger a checkpatch.pl warning about braces which are not necessary
anymore.
WARNING: braces {} are not necessary for any arm of this statement
+ if (entry->primary)
[...]
+ else {
[...]
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
batman-adv/vis.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/batman-adv/vis.c b/batman-adv/vis.c
index bde423a..5aea153 100644
--- a/batman-adv/vis.c
+++ b/batman-adv/vis.c
@@ -136,9 +136,8 @@ static ssize_t vis_data_read_prim_sec(char *buff, struct hlist_head *if_list)
hlist_for_each_entry(entry, pos, if_list, list) {
if (entry->primary)
len += sprintf(buff + len, "PRIMARY, ");
- else {
+ else
len += sprintf(buff + len, "SEC %pM, ", entry->addr);
- }
}
return len;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove useless braces
2010-10-23 22:42 [B.A.T.M.A.N.] [PATCH] batman-adv: Remove useless braces Sven Eckelmann
@ 2010-10-25 13:02 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2010-10-25 13:02 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Sunday 24 October 2010 00:42:22 Sven Eckelmann wrote:
> 54466268785c9892d6e2af2ac2a54a684face022 added changes to vis.c which
> trigger a checkpatch.pl warning about braces which are not necessary
> anymore.
Applied in revision 1850.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-25 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-23 22:42 [B.A.T.M.A.N.] [PATCH] batman-adv: Remove useless braces Sven Eckelmann
2010-10-25 13:02 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).