[B.A.T.M.A.N.] [PATCHv2] batman-adv: don't use !! in bool conversion

[B.A.T.M.A.N.] [PATCHv2] batman-adv: don't use !! in bool conversion

[Antonio Quartulli]

In C standard any expression different from 0 will be converted to
'true' when casting to bool (whatever is the length of the value).
Therefore all the "!!" conversions can be removed.

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---

* v2:
 - commit message reworded


 translation-table.c | 4 ++--
 unicast.c           | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/translation-table.c b/translation-table.c
index fb15b4c..e711b05 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -912,7 +912,7 @@ out_remove:
 	/* remove address from local hash if present */
 	local_flags = batadv_tt_local_remove(bat_priv, tt_addr,
 					     "global tt received",
-					     !!(flags & BATADV_TT_CLIENT_ROAM));
+					     flags & BATADV_TT_CLIENT_ROAM);
 	tt_global_entry->common.flags |= local_flags & BATADV_TT_CLIENT_WIFI;
 
 	if (!(flags & BATADV_TT_CLIENT_ROAM))
@@ -2540,7 +2540,7 @@ bool batadv_tt_global_client_is_roaming(struct batadv_priv *bat_priv,
 	if (!tt_global_entry)
 		goto out;
 
-	ret = !!(tt_global_entry->common.flags & BATADV_TT_CLIENT_ROAM);
+	ret = tt_global_entry->common.flags & BATADV_TT_CLIENT_ROAM;
 	batadv_tt_global_entry_free_ref(tt_global_entry);
 out:
 	return ret;
diff --git a/unicast.c b/unicast.c
index 50e079f..0bb3b59 100644
--- a/unicast.c
+++ b/unicast.c
@@ -122,7 +122,7 @@ batadv_frag_search_packet(struct list_head *head,
 {
 	struct batadv_frag_packet_list_entry *tfp;
 	struct batadv_unicast_frag_packet *tmp_up = NULL;
-	int is_head_tmp, is_head;
+	bool is_head_tmp, is_head;
 	uint16_t search_seqno;
 
 	if (up->flags & BATADV_UNI_FRAG_HEAD)
@@ -130,7 +130,7 @@ batadv_frag_search_packet(struct list_head *head,
 	else
 		search_seqno = ntohs(up->seqno)-1;
 
-	is_head = !!(up->flags & BATADV_UNI_FRAG_HEAD);
+	is_head = up->flags & BATADV_UNI_FRAG_HEAD;
 
 	list_for_each_entry(tfp, head, list) {
 		if (!tfp->skb)
@@ -142,7 +142,7 @@ batadv_frag_search_packet(struct list_head *head,
 		tmp_up = (struct batadv_unicast_frag_packet *)tfp->skb->data;
 
 		if (tfp->seqno == search_seqno) {
-			is_head_tmp = !!(tmp_up->flags & BATADV_UNI_FRAG_HEAD);
+			is_head_tmp = tmp_up->flags & BATADV_UNI_FRAG_HEAD;
 			if (is_head_tmp != is_head)
 				return tfp;
 			else
-- 
1.8.0.2

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: don't use !! in bool conversion

[Marek Lindner]

On Tuesday, January 15, 2013 20:17:19 Antonio Quartulli wrote:
> In C standard any expression different from 0 will be converted to
> 'true' when casting to bool (whatever is the length of the value).
> Therefore all the "!!" conversions can be removed.
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> 
> * v2:
>  - commit message reworded
> 
> 
>  translation-table.c | 4 ++--
>  unicast.c           | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)

Applied in revision a365cf4.

Thanks,
Marek