[B.A.T.M.A.N.] [PATCH] batman-adv: don't check compat version twice

[B.A.T.M.A.N.] [PATCH] batman-adv: don't check compat version twice

[Antonio Quartulli]

From: Antonio Quartulli <antonio@open-mesh.com>

Compatibility version is checked upon packet reception
before calling any handler. For this reason it does need to
be checked once more in the handler itself.

Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
---
 bat_iv_ogm.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c
index 6d62e29..38183dc 100644
--- a/bat_iv_ogm.c
+++ b/bat_iv_ogm.c
@@ -1054,13 +1054,6 @@ static void batadv_iv_ogm_process(const struct ethhdr *ethhdr,
 	}
 	rcu_read_unlock();
 
-	if (batadv_ogm_packet->header.version != BATADV_COMPAT_VERSION) {
-		batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
-			   "Drop packet: incompatible batman version (%i)\n",
-			   batadv_ogm_packet->header.version);
-		return;
-	}
-
 	if (is_my_addr) {
 		batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
 			   "Drop packet: received my own broadcast (sender: %pM)\n",
-- 
1.8.1.5

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't check compat version twice

[Marek Lindner]

On Thursday, March 28, 2013 21:21:12 Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
> 
> Compatibility version is checked upon packet reception
> before calling any handler. For this reason it does need to
> be checked once more in the handler itself.
> 
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> ---
>  bat_iv_ogm.c | 7 -------
>  1 file changed, 7 deletions(-)

Applied in revision ae9218e.

Thanks,
Marek