* [B.A.T.M.A.N.] [PATCHv2] batman-adv: (style) fix for switched vid-ifiindex parameter order
@ 2013-06-14 18:04 Linus Lüssing
2013-06-19 15:20 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Linus Lüssing @ 2013-06-14 18:04 UTC (permalink / raw)
To: b.a.t.m.a.n
batadv_tt_local_add() first takes the vid and then the interface index
parameter. One of these calls had the order switched.
However in this case it is not a functional, but just a style fix
because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.
Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042
("batman-adv: add the VLAN ID attribute to the TT entry")
Acked-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
v2: Added "Introduced by..." to commit message
main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.c b/main.c
index f2f1137..a7ad6cb 100644
--- a/main.c
+++ b/main.c
@@ -128,7 +128,7 @@ int batadv_mesh_init(struct net_device *soft_iface)
goto err;
batadv_tt_local_add(soft_iface, soft_iface->dev_addr,
- BATADV_NULL_IFINDEX, BATADV_NO_FLAGS);
+ BATADV_NO_FLAGS, BATADV_NULL_IFINDEX);
ret = batadv_bla_init(bat_priv);
if (ret < 0)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: (style) fix for switched vid-ifiindex parameter order
2013-06-14 18:04 [B.A.T.M.A.N.] [PATCHv2] batman-adv: (style) fix for switched vid-ifiindex parameter order Linus Lüssing
@ 2013-06-19 15:20 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2013-06-19 15:20 UTC (permalink / raw)
To: b.a.t.m.a.n
On Saturday, June 15, 2013 02:04:09 Linus Lüssing wrote:
> batadv_tt_local_add() first takes the vid and then the interface index
> parameter. One of these calls had the order switched.
>
> However in this case it is not a functional, but just a style fix
> because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.
>
> Introduced by 580d7919f19e4f73ccd79e82a532af2bdc638042
> ("batman-adv: add the VLAN ID attribute to the TT entry")
>
> Acked-by: Antonio Quartulli <ordex@autistici.org>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> v2: Added "Introduced by..." to commit message
>
> main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision cc14598.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-19 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-14 18:04 [B.A.T.M.A.N.] [PATCHv2] batman-adv: (style) fix for switched vid-ifiindex parameter order Linus Lüssing
2013-06-19 15:20 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).