From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] B.A.T.M.A.N. V leaves the nest
Date: Thu, 31 Dec 2015 12:07:12 +0100 [thread overview]
Message-ID: <20151231110712.GD30632@otheros> (raw)
In-Reply-To: <2457136.iz2mu7y0Mc@voltaire>
Hi,
It's nice to see how the whole BATMAN V idea has matured over the
years and both the documentation and code having become very
clean and simple to read :).
However, I think there is at least one more bug in the
specification that needs fixing, the one I had mentioned to Simon
some days ago on IRC, that with the current writing, there would
never be a selected router.
There are also two more things I would (still) like to discuss
regarding the OGMv2 specification in the wiki:
* Is the check "If the received neighbor is not (yet) a router,
drop the OGMv2" still necessary? If yes why?
* Suggestion: Change "If the OGMv2 sequence number is not newer or equal
compared to the last received OGMV2 (from any neighbor for this
originator) and if the throughput is not better, drop the OGMv2"
to:
"[...] (from the currently selected router for this originator) [...]"
(-> is another sequence number check here redundant?
see "Age check above"? maybe some merging+reordering here?)
* What does "is adopted"/"are applied" mean in section 3.2.2 and
section 4? Maybe clarify when the internal stats are updated and
when the OGMv2? ->
* Suggestion:
* Move "forward penalties are applied" to section 4
and change it to "forward penalties are applied to the OGMv2"
* Change "Path Throughput is adopted if its lower than the link
throughput to the neighbor, otherwise the link throuput is
adopted" to:
"If the link throughput to the neighbor this OGMv2 was
received from is lower than the Path Throughput of the OGMv2
then set the Path Throughput of the OGMv2 to this link throughput."
* Remove "The Path throughput for the considered outoging
interface is adopted" from section 4.
Also, I guess there is some awareness about potentially slow
convergence speeds. One of the reasons the idea with "RIP"
occured. But I think next to dead nodes, there are some more
scenarios with slow convergence speeds which depends on the
latency of links. Going to write a wiki page with pictures on
that, I think it should at least be documented before a release
(I'd have some ideas to fix it later in a backwards compatible
way, ensuring a convergence within one sequence number - it fact
that fix was in the original OGMv2 page I had written back then
;) ).
Cheers, Linus
next prev parent reply other threads:[~2015-12-31 11:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 12:38 [B.A.T.M.A.N.] B.A.T.M.A.N. V leaves the nest Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 01/13] batman-adv: Add hard_iface specific sysfs wrapper macros for UINT Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 02/13] batman-adv: ELP - adding basic infrastructure Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 03/13] batman-adv: ELP - creating neighbor structures Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 04/13] batman-adv: ELP - adding sysfs parameter for elp interval Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 05/13] batman-adv: OGMv2 - add basic infrastructure Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 06/13] batman-adv: OGMv2 - implement originators logic Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 07/13] batman-adv: add throughput override attribute to hard_ifaces Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 08/13] batman-adv: keep track of when unicast packets are sent Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 09/13] batman-adv: ELP - compute the metric based on the estimated throughput Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 10/13] batman-adv: ELP - send unicast ELP packets for throughput sampling Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 11/13] batman-adv: B.A.T.M.A.N. V - implement neighbor comparison API calls Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 12/13] batman-adv: B.A.T.M.A.N. V - implement bat_orig_print API Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 13/13] batman-adv: B.A.T.M.A.N. V - implement bat_neigh_print API Marek Lindner
2015-12-31 11:07 ` Linus Lüssing [this message]
2016-01-04 13:08 ` [B.A.T.M.A.N.] B.A.T.M.A.N. V leaves the nest Linus Lüssing
2016-01-09 2:29 ` Linus Lüssing
2016-01-09 13:43 ` Antonio Quartulli
2016-01-15 10:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151231110712.GD30632@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).