From: Antonio Quartulli <a@unstable.cc>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] B.A.T.M.A.N. V leaves the nest
Date: Sat, 9 Jan 2016 21:43:11 +0800 [thread overview]
Message-ID: <56910E6F.6050307@unstable.cc> (raw)
In-Reply-To: <20160109022925.GG5675@otheros>
[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]
On 09/01/16 10:29, Linus Lüssing wrote:
> On Thu, Dec 31, 2015 at 12:07:12PM +0100, Linus Lüssing wrote:
>> * Suggestion: Change "If the OGMv2 sequence number is not newer or equal
>> compared to the last received OGMV2 (from any neighbor for this
>> originator) and if the throughput is not better, drop the OGMv2"
>> to:
>> "[...] (from the currently selected router for this originator) [...]"
>>
>> (-> is another sequence number check here redundant?
>> see "Age check above"? maybe some merging+reordering here?)
>
> Another issue I just noticed with the according sentence we have
> in the spec right now:
>
> Bad news never travells:
>
> We would ignore updates from our selected router if the path
> throughput got worse - even if it's a new sequence number.
>
> * Add a branch: If seqno is new + from currently selected router:
> -> accept (even if path throughput is lower than with the previous seqno)
I think you are trying to say the same as what is written - just
reverting the condition to say "accept".
The spec says:
if (NOT(seqno newer or equal) AND NOT(better throughput)) then DROP
Therefore the statement "if the OGM is newer then accept it" is part of
this condition already, no ? Moreover, correct me if I am wrong, but any
new OGM should be accepted at this step, not only those arriving from
the selected router, hence your statement would be also a bit confusing
imho.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-09 13:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 12:38 [B.A.T.M.A.N.] B.A.T.M.A.N. V leaves the nest Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 01/13] batman-adv: Add hard_iface specific sysfs wrapper macros for UINT Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 02/13] batman-adv: ELP - adding basic infrastructure Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 03/13] batman-adv: ELP - creating neighbor structures Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 04/13] batman-adv: ELP - adding sysfs parameter for elp interval Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 05/13] batman-adv: OGMv2 - add basic infrastructure Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 06/13] batman-adv: OGMv2 - implement originators logic Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 07/13] batman-adv: add throughput override attribute to hard_ifaces Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 08/13] batman-adv: keep track of when unicast packets are sent Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 09/13] batman-adv: ELP - compute the metric based on the estimated throughput Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 10/13] batman-adv: ELP - send unicast ELP packets for throughput sampling Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 11/13] batman-adv: B.A.T.M.A.N. V - implement neighbor comparison API calls Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 12/13] batman-adv: B.A.T.M.A.N. V - implement bat_orig_print API Marek Lindner
2015-12-30 12:40 ` [B.A.T.M.A.N.] [PATCH 13/13] batman-adv: B.A.T.M.A.N. V - implement bat_neigh_print API Marek Lindner
2015-12-31 11:07 ` [B.A.T.M.A.N.] B.A.T.M.A.N. V leaves the nest Linus Lüssing
2016-01-04 13:08 ` Linus Lüssing
2016-01-09 2:29 ` Linus Lüssing
2016-01-09 13:43 ` Antonio Quartulli [this message]
2016-01-15 10:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56910E6F.6050307@unstable.cc \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).