b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv12 1/4] batman-adv: Always flood IGMP/MLD reports
Date: Sun, 10 Apr 2016 14:43:30 +0200	[thread overview]
Message-ID: <20160410124329.GH19310@otheros> (raw)
In-Reply-To: <20160410120748.GG19310@otheros>

On Sun, Apr 10, 2016 at 02:07:48PM +0200, Linus Lüssing wrote:
> On Thu, Apr 07, 2016 at 03:03:11PM +0200, Simon Wunderlich wrote:
> > > To avoid compatibility issues with older nodes not yet implementing this
> > > report handling, we need to force them to flood reports: We do this by
> > > bumping the multicast TVLV version to 2, effectively disabling their
> > > multicast optimization.
> > 
> > It looks like you register two containers, one with version 1 and version 2, 
> > both with the same content. Do we really need to have both containers? 
> > Wouldn't it be sufficient to register only version 2 and leave version 1 out?
> 
> The idea is to avoid unexpected regressions:
> 
[...]
> The registeration of two containers is probably a minor improvement.
> Haven't heard of any actual setups which would need it yet. On the
> other hand it's not that much extra code, so it felt like a good
> idea to add it for some extra compatibility courtesy.

My intention would be to have it just as a transitional mechanism,
too. Removing it in 2-4 years maybe.

Regards, Linus

  reply	other threads:[~2016-04-10 12:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  4:06 [B.A.T.M.A.N.] [PATCHv12 0/4] Multicast optimizations for bridges Linus Lüssing
2016-03-16  4:06 ` [B.A.T.M.A.N.] [PATCHv12 1/4] batman-adv: Always flood IGMP/MLD reports Linus Lüssing
2016-04-07 13:03   ` Simon Wunderlich
2016-04-07 13:24     ` Sven Eckelmann
2016-04-10 12:07     ` Linus Lüssing
2016-04-10 12:43       ` Linus Lüssing [this message]
2016-04-19  2:12     ` Linus Lüssing
2016-03-16  4:06 ` [B.A.T.M.A.N.] [PATCHv12 2/4] batman-adv: Add multicast optimization support for bridged setups Linus Lüssing
2016-04-07 13:43   ` Sven Eckelmann
2016-04-07 13:50   ` Sven Eckelmann
2016-04-19  2:22     ` Linus Lüssing
2016-04-24  7:07       ` Sven Eckelmann
2016-03-16  4:06 ` [B.A.T.M.A.N.] [PATCHv12 3/4] batman-adv: Adding logging of mcast flag changes Linus Lüssing
2016-03-16  4:06 ` [B.A.T.M.A.N.] [PATCHv12 4/4] batman-adv: Add debugfs table for mcast flags Linus Lüssing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160410124329.GH19310@otheros \
    --to=linus.luessing@c0d3.blue \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).