From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv12 2/4] batman-adv: Add multicast optimization support for bridged setups
Date: Tue, 19 Apr 2016 04:22:18 +0200 [thread overview]
Message-ID: <20160419022218.GE17647@otheros> (raw)
In-Reply-To: <3374405.0Pi9Duaxya@bentobox>
On Thu, Apr 07, 2016 at 03:50:39PM +0200, Sven Eckelmann wrote:
> On Wednesday 16 March 2016 05:06:43 Linus Lüssing wrote:
> > --- /dev/null
> > +++ b/compat-sources/net/bridge/br_multicast.c
> > @@ -0,0 +1,33 @@
> > +#include <linux/if_bridge.h>
> > +#include <linux/printk.h>
> > +
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 16, 0) || \
> > + LINUX_VERSION_CODE == KERNEL_VERSION(3, 16, 0) && \
> > + (!IS_ENABLED(CONFIG_BRIDGE) || \
> > + !IS_ENABLED(CONFIG_BRIDGE_IGMP_SNOOPING))
> > +
> > +int br_multicast_list_adjacent(struct net_device *dev,
> > + struct list_head *br_ip_list)
> > +{
> > + return 0;
> > +}
> > +
> > +bool br_multicast_has_querier_adjacent(struct net_device *dev, int proto)
> > +{
> > + return false;
> > +}
> > +
> > +#endif /* < KERNEL_VERSION(3, 16, 0) ||
> > + * !IS_ENABLED(CONFIG_BRIDGE) ||
> > + * !IS_ENABLED(CONFIG_BRIDGE_IGMP_SNOOPING) */
> > +
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
> > +
> > +bool br_multicast_has_querier_anywhere(struct net_device *dev, int proto)
> > +{
> > + pr_warn_once("Old kernel detected (< 3.17) - multicast optimizations disabled\n");
> > +
> > + return false;
> > +}
> > +
> > +#endif /* < KERNEL_VERSION(3, 17, 0) */
>
> Why must there be a special compat-sources/*.c file for these tiny
> functions?
I think it is necessary because of the missing stubs in 3.16.
3.16 has the function declarations in if_bridge.h but without
function definitions if the kernel is build without bridge
(snooping) support.
Adding simple inline functions in compat-include/linux/if_bridge.h
for these functions would yield a compile-time error for the 3.16
kernel without bridge (snooping) support case: The declaration is
always there in 3.16's if_bridge.h include which would clash
with a self-made inline function in our compat-include's
if_bridge.h.
next prev parent reply other threads:[~2016-04-19 2:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 4:06 [B.A.T.M.A.N.] [PATCHv12 0/4] Multicast optimizations for bridges Linus Lüssing
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 1/4] batman-adv: Always flood IGMP/MLD reports Linus Lüssing
2016-04-07 13:03 ` Simon Wunderlich
2016-04-07 13:24 ` Sven Eckelmann
2016-04-10 12:07 ` Linus Lüssing
2016-04-10 12:43 ` Linus Lüssing
2016-04-19 2:12 ` Linus Lüssing
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 2/4] batman-adv: Add multicast optimization support for bridged setups Linus Lüssing
2016-04-07 13:43 ` Sven Eckelmann
2016-04-07 13:50 ` Sven Eckelmann
2016-04-19 2:22 ` Linus Lüssing [this message]
2016-04-24 7:07 ` Sven Eckelmann
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 3/4] batman-adv: Adding logging of mcast flag changes Linus Lüssing
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 4/4] batman-adv: Add debugfs table for mcast flags Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419022218.GE17647@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).