* [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations
@ 2016-05-21 12:17 Antonio Quartulli
2016-05-21 12:17 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files Antonio Quartulli
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Antonio Quartulli @ 2016-05-21 12:17 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
If main.h is included, the batman-adv private forward declarations are
not needed anymore. Remove them.
Cc: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
net/batman-adv/gateway_client.h | 1 -
net/batman-adv/icmp_socket.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/net/batman-adv/gateway_client.h b/net/batman-adv/gateway_client.h
index 582dd8c..c74aca5 100644
--- a/net/batman-adv/gateway_client.h
+++ b/net/batman-adv/gateway_client.h
@@ -22,7 +22,6 @@
#include <linux/types.h>
-struct batadv_tvlv_gateway_data;
struct seq_file;
struct sk_buff;
diff --git a/net/batman-adv/icmp_socket.h b/net/batman-adv/icmp_socket.h
index 618d5de..ce3ed25 100644
--- a/net/batman-adv/icmp_socket.h
+++ b/net/batman-adv/icmp_socket.h
@@ -22,8 +22,6 @@
#include <linux/types.h>
-struct batadv_icmp_header;
-
#define BATADV_ICMP_SOCKET "socket"
void batadv_socket_init(void);
--
2.8.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files
2016-05-21 12:17 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Antonio Quartulli
@ 2016-05-21 12:17 ` Antonio Quartulli
2016-05-21 12:32 ` Sven Eckelmann
2016-05-21 12:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Sven Eckelmann
2016-06-06 16:10 ` Marek Lindner
2 siblings, 1 reply; 7+ messages in thread
From: Antonio Quartulli @ 2016-05-21 12:17 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
main.h is always included after the #ifdef guard except for
bat_v_elp.h. Move it at the right place.
Cc: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
net/batman-adv/bat_v_elp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/batman-adv/bat_v_elp.h b/net/batman-adv/bat_v_elp.h
index cc130b2..be17c0b 100644
--- a/net/batman-adv/bat_v_elp.h
+++ b/net/batman-adv/bat_v_elp.h
@@ -15,11 +15,11 @@
* along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
-#include "main.h"
-
#ifndef _NET_BATMAN_ADV_BAT_V_ELP_H_
#define _NET_BATMAN_ADV_BAT_V_ELP_H_
+#include "main.h"
+
struct sk_buff;
struct work_struct;
--
2.8.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations
2016-05-21 12:17 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Antonio Quartulli
2016-05-21 12:17 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files Antonio Quartulli
@ 2016-05-21 12:30 ` Sven Eckelmann
2016-05-21 12:32 ` Antonio Quartulli
2016-06-06 16:10 ` Marek Lindner
2 siblings, 1 reply; 7+ messages in thread
From: Sven Eckelmann @ 2016-05-21 12:30 UTC (permalink / raw)
To: Antonio Quartulli; +Cc: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
On Saturday 21 May 2016 20:17:55 Antonio Quartulli wrote:
> If main.h is included, the batman-adv private forward declarations are
> not needed anymore. Remove them.
No, these are defined in packet.h and not main.h/types.h
Kind regards,
Sven
> net/batman-adv/gateway_client.h | 1 -
> net/batman-adv/icmp_socket.h | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/net/batman-adv/gateway_client.h
> b/net/batman-adv/gateway_client.h index 582dd8c..c74aca5 100644
> --- a/net/batman-adv/gateway_client.h
> +++ b/net/batman-adv/gateway_client.h
> @@ -22,7 +22,6 @@
>
> #include <linux/types.h>
>
> -struct batadv_tvlv_gateway_data;
> struct seq_file;
> struct sk_buff;
>
> diff --git a/net/batman-adv/icmp_socket.h b/net/batman-adv/icmp_socket.h
> index 618d5de..ce3ed25 100644
> --- a/net/batman-adv/icmp_socket.h
> +++ b/net/batman-adv/icmp_socket.h
> @@ -22,8 +22,6 @@
>
> #include <linux/types.h>
>
> -struct batadv_icmp_header;
> -
> #define BATADV_ICMP_SOCKET "socket"
>
> void batadv_socket_init(void);
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations
2016-05-21 12:17 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Antonio Quartulli
2016-05-21 12:17 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files Antonio Quartulli
2016-05-21 12:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Sven Eckelmann
@ 2016-06-06 16:10 ` Marek Lindner
2 siblings, 0 replies; 7+ messages in thread
From: Marek Lindner @ 2016-06-06 16:10 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
On Saturday, May 21, 2016 20:17:55 Antonio Quartulli wrote:
> If main.h is included, the batman-adv private forward declarations are
> not needed anymore. Remove them.
>
> Cc: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
> net/batman-adv/gateway_client.h | 1 -
> net/batman-adv/icmp_socket.h | 2 --
> 2 files changed, 3 deletions(-)
Applied in revision 563823d.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-06 16:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-21 12:17 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Antonio Quartulli
2016-05-21 12:17 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files Antonio Quartulli
2016-05-21 12:32 ` Sven Eckelmann
2016-06-06 16:12 ` Marek Lindner
2016-05-21 12:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Sven Eckelmann
2016-05-21 12:32 ` Antonio Quartulli
2016-06-06 16:10 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).