b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] [PATCH v2] alfred: vis: Don't fail when debugfs cannot be mounted
@ 2016-11-01 12:19 Sven Eckelmann
  2016-11-01 15:00 ` Simon Wunderlich
  0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2016-11-01 12:19 UTC (permalink / raw)
  To: b.a.t.m.a.n

The vis server is supposed to use netlink when available. This allows to
work on systems without debugfs and under network namespaces. Thus it is
now not strictly required anymore to have debugfs available.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 vis/vis.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/vis/vis.c b/vis/vis.c
index f4d13c7..51d7f5c 100644
--- a/vis/vis.c
+++ b/vis/vis.c
@@ -1120,13 +1120,7 @@ static struct globals *vis_init(int argc, char *argv[])
 
 static int vis_server(struct globals *globals)
 {
-	char *debugfs_mnt;
-
-	debugfs_mnt = debugfs_mount(NULL);
-	if (!debugfs_mnt) {
-		fprintf(stderr, "Error - can't mount or find debugfs\n");
-		return EXIT_FAILURE;
-	}
+	debugfs_mount(NULL);
 
 	globals->push = (struct alfred_push_data_v0 *) globals->buf;
 	globals->vis_data = (struct vis_v1 *) (globals->buf + sizeof(*globals->push) + sizeof(struct alfred_data));
-- 
2.10.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH v2] alfred: vis: Don't fail when debugfs cannot be mounted
  2016-11-01 12:19 [B.A.T.M.A.N.] [PATCH v2] alfred: vis: Don't fail when debugfs cannot be mounted Sven Eckelmann
@ 2016-11-01 15:00 ` Simon Wunderlich
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Wunderlich @ 2016-11-01 15:00 UTC (permalink / raw)
  To: b.a.t.m.a.n

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

On Tuesday, November 1, 2016 1:19:37 PM CET Sven Eckelmann wrote:
> The vis server is supposed to use netlink when available. This allows to
> work on systems without debugfs and under network namespaces. Thus it is
> now not strictly required anymore to have debugfs available.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>

Applied in a580287.

Thanks,
     Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-01 15:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01 12:19 [B.A.T.M.A.N.] [PATCH v2] alfred: vis: Don't fail when debugfs cannot be mounted Sven Eckelmann
2016-11-01 15:00 ` Simon Wunderlich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).