* [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
[not found] <201607061025.fb3YfL1g%fengguang.wu@intel.com>
@ 2016-07-06 2:49 ` kbuild test robot
2016-07-06 6:12 ` Sven Eckelmann
2016-07-06 13:44 ` Marek Lindner
0 siblings, 2 replies; 4+ messages in thread
From: kbuild test robot @ 2016-07-06 2:49 UTC (permalink / raw)
Cc: Marek Lindner, netdev, b.a.t.m.a.n, Antonio Quartulli,
linux-kernel, kbuild-all
net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
bridge_loop_avoidance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str
/* Let the loopdetect frames on the mesh in any case. */
if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT)
- return 0;
+ return false;
/* check if it is a claim frame. */
ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
2016-07-06 2:49 ` [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
@ 2016-07-06 6:12 ` Sven Eckelmann
2016-07-06 7:26 ` Sven Eckelmann
2016-07-06 13:44 ` Marek Lindner
1 sibling, 1 reply; 4+ messages in thread
From: Sven Eckelmann @ 2016-07-06 6:12 UTC (permalink / raw)
To: kbuild test robot
Cc: Antonio Quartulli, kbuild-all, b.a.t.m.a.n, Marek Lindner
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
On Wednesday 06 July 2016 10:49:29 kbuild test robot wrote:
> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> CC: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
Reviewed-by: Sven Eckelmann <sven@narfation.org>
The problematic commit is in batman-adv.git (next):
Fixes: a998bf5dfbd7 ("batman-adv: add detection for complex bridge loops")
And in net-next.git (due to some reordering)
Fixes: 4b426b108ac8 ("batman-adv: Use bool as return type for boolean functions")
Thanks,
Sven
>
> bridge_loop_avoidance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/batman-adv/bridge_loop_avoidance.c
> +++ b/net/batman-adv/bridge_loop_avoidance.c
> @@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str
>
> /* Let the loopdetect frames on the mesh in any case. */
> if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT)
> - return 0;
> + return false;
>
> /* check if it is a claim frame. */
> ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
2016-07-06 6:12 ` Sven Eckelmann
@ 2016-07-06 7:26 ` Sven Eckelmann
0 siblings, 0 replies; 4+ messages in thread
From: Sven Eckelmann @ 2016-07-06 7:26 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: kbuild test robot, Antonio Quartulli, kbuild-all, Marek Lindner
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Wednesday 06 July 2016 08:12:09 Sven Eckelmann wrote:
> On Wednesday 06 July 2016 10:49:29 kbuild test robot wrote:
> > net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
> >
> > Return statements in functions returning bool should use
> > true/false instead of 1/0.
> > Generated by: scripts/coccinelle/misc/boolreturn.cocci
> >
> > CC: Sven Eckelmann <sven@narfation.org>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
>
> The problematic commit is in batman-adv.git (next):
>
> Fixes: a998bf5dfbd7 ("batman-adv: add detection for complex bridge loops")
Sorry, I meant maint and not next. It was already part of v2016.2
@Marek not sure where you want to apply it. It should have no effect
on the actual functionality.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
2016-07-06 2:49 ` [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
2016-07-06 6:12 ` Sven Eckelmann
@ 2016-07-06 13:44 ` Marek Lindner
1 sibling, 0 replies; 4+ messages in thread
From: Marek Lindner @ 2016-07-06 13:44 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: netdev, Antonio Quartulli, linux-kernel, kbuild-all, kbuild test robot
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Wednesday, July 06, 2016 10:49:29 kbuild test robot wrote:
> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in
> function 'batadv_bla_process_claim' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> CC: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> bridge_loop_avoidance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision 36e7316.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-06 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201607061025.fb3YfL1g%fengguang.wu@intel.com>
2016-07-06 2:49 ` [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
2016-07-06 6:12 ` Sven Eckelmann
2016-07-06 7:26 ` Sven Eckelmann
2016-07-06 13:44 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).