Re: [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam

From: Antonio Quartulli <antonio@meshcoding.com>
To: "André Gaul" <gaul@web-yard.de>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam
Date: Mon, 09 Jun 2014 23:05:29 +0200	[thread overview]
Message-ID: <53962199.4060202@meshcoding.com> (raw)
In-Reply-To: <1402334059-28681-1-git-send-email-gaul@web-yard.de>

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

On 09/06/14 19:14, André Gaul wrote:
> This patch removes unnecessary logspam which resulted from superfluous
> calls to net_ratelimit(). With the supplied patch, net_ratelimit() is
> called after the loglevel has been checked.
> 
> Signed-off-by: André Gaul <gaul@web-yard.de>

André,

I'd suggest you to check this patch with checkpatch.pl --strict. Here I
get many errors due to non-printable chars at the end of various lines.

Here[1] you find our guidelines (which is a set of complementary rules
to the guidelines you find in the kernel tree[2]).

Moreover, the subject must start with "batman-adv: ", because this patch
will end up in the kernel and it requires this format to easily
distinguish the subsystem that the patch is touching.

A couple of things to keep in mind while sending new versions of the
same patch:
- don't reply to an existing thread
- write [PATCHvN] (with N = version of the patch - 2 in this case) in
the subject

Cheers,

[1]
http://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches
[2]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches

-- 
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]