b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: "André Gaul" <gaul@web-yard.de>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam
Date: Mon, 09 Jun 2014 23:36:54 +0200	[thread overview]
Message-ID: <539628F6.9070706@web-yard.de> (raw)
In-Reply-To: <53962199.4060202@meshcoding.com>

Hey Antonio,

thx for your quick reply!

Am 09.06.2014 23:05, schrieb Antonio Quartulli:
> I'd suggest you to check this patch with checkpatch.pl --strict. Here I
> get many errors due to non-printable chars at the end of various lines.

I did that and I don't get any errors or warnings with checkpatch.pl
--strict. It tells me:

------
$ ./scripts/checkpatch.pl --strict
/tmp/0001-remove-unnecessary-logspam.patch
total: 0 errors, 0 warnings, 65 lines checked

/tmp/0001-remove-unnecessary-logspam.patch has no obvious style problems
and is ready for submission.
------

> Here[1] you find our guidelines (which is a set of complementary rules
> to the guidelines you find in the kernel tree[2]).
> 
> Moreover, the subject must start with "batman-adv: ", because this patch
> will end up in the kernel and it requires this format to easily
> distinguish the subsystem that the patch is touching.
> 
> A couple of things to keep in mind while sending new versions of the
> same patch:
> - don't reply to an existing thread
> - write [PATCHvN] (with N = version of the patch - 2 in this case) in
> the subject

OK, I can resubmit with the corrected subject line
  [PATCHv2] batman-adv: remove unnecessary logspam
but I'd like to know first what this non-printable chars issue is about.

cheers,
André

-- 
Homepage   http://page.math.tu-berlin.de/~gaul
github     https://github.com/andrenarchy
Twitter    https://twitter.com/#!/andrenarchy
Diaspora   https://diasp.org/u/andrenarchy
           (you won't find me on facebook!)
Jabber     gaul@web-yard.de
PGP Key    0x0FA9170E

  reply	other threads:[~2014-06-09 21:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 19:53 [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam André Gaul
2014-06-09  8:54 ` Antonio Quartulli
2014-06-09 17:14   ` André Gaul
2014-06-09 21:05     ` Antonio Quartulli
2014-06-09 21:36       ` André Gaul [this message]
2014-06-10  6:01         ` Antonio Quartulli
2014-06-10 15:38           ` André Gaul
2014-06-10 15:40             ` Antonio Quartulli
2014-06-10 15:45               ` André Gaul
2014-06-11  6:04                 ` Antonio Quartulli
2014-06-14  1:44                 ` Marek Lindner
2014-06-15 12:32                   ` André Gaul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539628F6.9070706@web-yard.de \
    --to=gaul@web-yard.de \
    --cc=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).