b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] [PATCH] batman-adv: fix coccinelle warnings
@ 2014-01-06 16:09 Martin Hundebøll
  2014-01-16  9:36 ` Marek Lindner
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Hundebøll @ 2014-01-06 16:09 UTC (permalink / raw)
  To: b.a.t.m.a.n; +Cc: Martin Hundebøll, Fengguang Wu

From: Fengguang Wu <fengguang.wu@intel.com>

net/batman-adv/network-coding.c:1535:1-7: Replace memcpy with struct assignment

Generated by: coccinelle/misc/memcpy-assign.cocci
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
---
 network-coding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/network-coding.c b/network-coding.c
index f1b604d..801ece6 100644
--- a/network-coding.c
+++ b/network-coding.c
@@ -1636,7 +1636,7 @@ batadv_nc_skb_decode_packet(struct batadv_priv *bat_priv, struct sk_buff *skb,
 
 	/* Reconstruct original mac header */
 	ethhdr = eth_hdr(skb);
-	memcpy(ethhdr, &ethhdr_tmp, sizeof(*ethhdr));
+	*ethhdr = ethhdr_tmp;
 
 	/* Select the correct unicast header information based on the location
 	 * of our mac address in the coded_packet header
-- 
1.8.5.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix coccinelle warnings
  2014-01-06 16:09 [B.A.T.M.A.N.] [PATCH] batman-adv: fix coccinelle warnings Martin Hundebøll
@ 2014-01-16  9:36 ` Marek Lindner
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2014-01-16  9:36 UTC (permalink / raw)
  To: b.a.t.m.a.n; +Cc: Fengguang Wu, Martin Hundebøll

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On Monday 06 January 2014 17:09:46 Martin Hundebøll wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> net/batman-adv/network-coding.c:1535:1-7: Replace memcpy with struct
> assignment
> 
> Generated by: coccinelle/misc/memcpy-assign.cocci
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
> ---
>  network-coding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision c99b36a.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-16  9:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-06 16:09 [B.A.T.M.A.N.] [PATCH] batman-adv: fix coccinelle warnings Martin Hundebøll
2014-01-16  9:36 ` Marek Lindner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).