From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ajay Kaher <akaher@vmware.com>,
Alexey Makhalov <amakhalov@vmware.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative
Date: Wed, 25 Oct 2023 15:57:36 +0200 [thread overview]
Message-ID: <bc0b5357-1b0d-44ad-a0a2-a8b102328fff@suse.com> (raw)
In-Reply-To: <20231025134425.GEZTkbua5w0bI2GQlP@fat_crate.local>
[-- Attachment #1.1.1: Type: text/plain, Size: 601 bytes --]
On 25.10.23 15:44, Borislav Petkov wrote:
> On Wed, Oct 25, 2023 at 03:31:07PM +0200, Juergen Gross wrote:
>> There is
>>
>> #define nop() asm volatile ("nop")
>>
>> in arch/x86/include/asm/special_insns.h already.
>
> Then call it "nop_func" or so.
Okay.
>
>> It might not be needed now, but are you sure we won't need it in future?
>
> No, I'm not.
>
> What I'm sure of is: stuff should be added to the kernel only when
> really needed. Not in the expectation that it might potentially be
> needed at some point.
Will double check whether it is needed now.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross via Virtualization <virtualization@lists.linux-foundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Wanpeng Li <wanpengli@tencent.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Alexey Makhalov <amakhalov@vmware.com>,
xen-devel@lists.xenproject.org, kvm@vger.kernel.org,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Peter Zijlstra <peterz@infradead.org>,
Ajay Kaher <akaher@vmware.com>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative
Date: Wed, 25 Oct 2023 15:57:36 +0200 [thread overview]
Message-ID: <bc0b5357-1b0d-44ad-a0a2-a8b102328fff@suse.com> (raw)
In-Reply-To: <20231025134425.GEZTkbua5w0bI2GQlP@fat_crate.local>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 601 bytes --]
On 25.10.23 15:44, Borislav Petkov wrote:
> On Wed, Oct 25, 2023 at 03:31:07PM +0200, Juergen Gross wrote:
>> There is
>>
>> #define nop() asm volatile ("nop")
>>
>> in arch/x86/include/asm/special_insns.h already.
>
> Then call it "nop_func" or so.
Okay.
>
>> It might not be needed now, but are you sure we won't need it in future?
>
> No, I'm not.
>
> What I'm sure of is: stuff should be added to the kernel only when
> really needed. Not in the expectation that it might potentially be
> needed at some point.
Will double check whether it is needed now.
Juergen
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-10-25 13:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 9:15 [PATCH v3 0/5] x86/paravirt: Get rid of paravirt patching Juergen Gross
2023-10-19 9:15 ` Juergen Gross via Virtualization
2023-10-19 9:15 ` [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative Juergen Gross
2023-10-19 9:15 ` Juergen Gross via Virtualization
2023-10-19 11:33 ` kernel test robot
2023-10-19 11:33 ` kernel test robot
2023-10-25 10:34 ` Borislav Petkov
2023-10-25 10:34 ` Borislav Petkov
2023-10-25 13:31 ` Juergen Gross
2023-10-25 13:31 ` Juergen Gross via Virtualization
2023-10-25 13:44 ` Borislav Petkov
2023-10-25 13:44 ` Borislav Petkov
2023-10-25 13:57 ` Juergen Gross [this message]
2023-10-25 13:57 ` Juergen Gross via Virtualization
2023-10-30 12:39 ` Juergen Gross
2023-10-30 12:39 ` Juergen Gross via Virtualization
2023-10-19 9:15 ` [PATCH v3 2/5] x86/alternative: add indirect call patching Juergen Gross
2023-10-19 9:15 ` [PATCH v3 3/5] x86/paravirt: introduce ALT_NOT_XEN Juergen Gross
2023-10-19 9:15 ` Juergen Gross via Virtualization
2023-10-19 9:15 ` [PATCH v3 4/5] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2 Juergen Gross
2023-10-19 9:15 ` Juergen Gross via Virtualization
2023-10-19 11:55 ` kernel test robot
2023-10-19 11:55 ` kernel test robot
2023-10-26 2:44 ` kernel test robot
2023-10-26 6:33 ` Juergen Gross
2023-10-26 6:33 ` Juergen Gross via Virtualization
2023-10-26 9:02 ` kernel test robot
2023-10-26 9:02 ` kernel test robot
2023-10-19 9:15 ` [PATCH v3 5/5] x86/paravirt: remove no longer needed paravirt patching code Juergen Gross
2023-10-19 9:15 ` Juergen Gross via Virtualization
2023-10-19 12:06 ` kernel test robot
2023-10-19 12:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0b5357-1b0d-44ad-a0a2-a8b102328fff@suse.com \
--to=jgross@suse.com \
--cc=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pv-drivers@vmware.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.