From: Kuogee Hsieh <quic_khsieh@quicinc.com>
To: <robdclark@gmail.com>, <sean@poorly.run>, <swboyd@chromium.org>,
<vkoul@kernel.org>, <daniel@ffwll.ch>, <airlied@linux.ie>,
<agross@kernel.org>, <dmitry.baryshkov@linaro.org>,
<bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
aravindh@codeaurora.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list
Date: Mon, 14 Feb 2022 08:41:31 -0800 [thread overview]
Message-ID: <bc21d3d2-78fb-cb3e-43e7-71b37804139d@quicinc.com> (raw)
In-Reply-To: <1643066274-25814-1-git-send-email-quic_khsieh@quicinc.com>
Hi Stephen,
Are you have more comments?
On 1/24/2022 3:17 PM, Kuogee Hsieh wrote:
> Some of DP link compliant test expects to return fail-safe mode
> if prefer detailed timing mode can not be supported by mainlink's
> lane and rate after link training. Therefore add fail-safe mode
> into connector mode list as backup mode. This patch fixes test
> case 4.2.2.1.
>
> Changes in v2:
> -- add Fixes text string
>
> Fixes: 4b85d405cfe9 ( "drm/msm/dp: reduce link rate if failed at link training 1")
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
> index 71db10c..f141872 100644
> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
> @@ -212,6 +212,11 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
> if (drm_add_modes_noedid(connector, 640, 480))
> drm_set_preferred_mode(connector, 640, 480);
> mutex_unlock(&connector->dev->mode_config.mutex);
> + } else {
> + /* always add fail-safe mode as backup mode */
> + mutex_lock(&connector->dev->mode_config.mutex);
> + drm_add_modes_noedid(connector, 640, 480);
> + mutex_unlock(&connector->dev->mode_config.mutex);
> }
>
> if (panel->aux_cfg_update_done) {
WARNING: multiple messages have this Message-ID (diff)
From: Kuogee Hsieh <quic_khsieh@quicinc.com>
To: <robdclark@gmail.com>, <sean@poorly.run>, <swboyd@chromium.org>,
<vkoul@kernel.org>, <daniel@ffwll.ch>, <airlied@linux.ie>,
<agross@kernel.org>, <dmitry.baryshkov@linaro.org>,
<bjorn.andersson@linaro.org>
Cc: <quic_abhinavk@quicinc.com>, <aravindh@codeaurora.org>,
<freedreno@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list
Date: Mon, 14 Feb 2022 08:41:31 -0800 [thread overview]
Message-ID: <bc21d3d2-78fb-cb3e-43e7-71b37804139d@quicinc.com> (raw)
In-Reply-To: <1643066274-25814-1-git-send-email-quic_khsieh@quicinc.com>
Hi Stephen,
Are you have more comments?
On 1/24/2022 3:17 PM, Kuogee Hsieh wrote:
> Some of DP link compliant test expects to return fail-safe mode
> if prefer detailed timing mode can not be supported by mainlink's
> lane and rate after link training. Therefore add fail-safe mode
> into connector mode list as backup mode. This patch fixes test
> case 4.2.2.1.
>
> Changes in v2:
> -- add Fixes text string
>
> Fixes: 4b85d405cfe9 ( "drm/msm/dp: reduce link rate if failed at link training 1")
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
> index 71db10c..f141872 100644
> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
> @@ -212,6 +212,11 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
> if (drm_add_modes_noedid(connector, 640, 480))
> drm_set_preferred_mode(connector, 640, 480);
> mutex_unlock(&connector->dev->mode_config.mutex);
> + } else {
> + /* always add fail-safe mode as backup mode */
> + mutex_lock(&connector->dev->mode_config.mutex);
> + drm_add_modes_noedid(connector, 640, 480);
> + mutex_unlock(&connector->dev->mode_config.mutex);
> }
>
> if (panel->aux_cfg_update_done) {
next prev parent reply other threads:[~2022-02-14 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 23:17 [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list Kuogee Hsieh
2022-01-24 23:17 ` Kuogee Hsieh
2022-02-14 16:41 ` Kuogee Hsieh [this message]
2022-02-14 16:41 ` Kuogee Hsieh
2022-02-16 19:32 ` Stephen Boyd
2022-02-16 19:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc21d3d2-78fb-cb3e-43e7-71b37804139d@quicinc.com \
--to=quic_khsieh@quicinc.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=aravindh@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.