From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Michal Hocko <mhocko@suse.com>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>,
Paul Mackerras <paulus@samba.org>,
sparclinux@vger.kernel.org, linux-s390@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
x86@kernel.org, Russell King <linux@armlinux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Fenghua Yu <fenghua.yu@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrey Konovalov <andreyknvl@google.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Christophe Leroy <christophe.leroy@c-s.fr>,
Tony Luck <tony.luck@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC V3] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()
Date: Mon, 10 Jun 2019 04:48:34 +0000 [thread overview]
Message-ID: <bc8e2140-dc78-ce99-a336-91733c2fda67@arm.com> (raw)
In-Reply-To: <6e095842-0f7f-f428-653d-2b6e98fea6b3@intel.com>
On 06/07/2019 08:36 PM, Dave Hansen wrote:
> On 6/7/19 3:34 AM, Anshuman Khandual wrote:
>> +static nokprobe_inline bool kprobe_page_fault(struct pt_regs *regs,
>> + unsigned int trap)
>> +{
>> + int ret = 0;
>> +
>> + /*
>> + * To be potentially processing a kprobe fault and to be allowed
>> + * to call kprobe_running(), we have to be non-preemptible.
>> + */
>> + if (kprobes_built_in() && !preemptible() && !user_mode(regs)) {
>> + if (kprobe_running() && kprobe_fault_handler(regs, trap))
>> + ret = 1;
>> + }
>> + return ret;
>> +}
>
> Nits: Other that taking the nice, readable, x86 one and globbing it onto
> a single line, looks OK to me. It does seem a _bit_ silly to go to the
> trouble of converting to 'bool' and then using 0/1 and an 'int'
> internally instead of true/false and a bool, though. It's also not a
Changing to 'bool'...
> horrible thing to add a single line comment to this sucker to say:
>
> /* returns true if kprobes handled the fault */
>
Picking this in-code comment.
> In any case, and even if you don't clean any of this up:
>
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
>
Thanks !
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrey Konovalov <andreyknvl@google.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [RFC V3] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()
Date: Mon, 10 Jun 2019 10:06:34 +0530 [thread overview]
Message-ID: <bc8e2140-dc78-ce99-a336-91733c2fda67@arm.com> (raw)
In-Reply-To: <6e095842-0f7f-f428-653d-2b6e98fea6b3@intel.com>
On 06/07/2019 08:36 PM, Dave Hansen wrote:
> On 6/7/19 3:34 AM, Anshuman Khandual wrote:
>> +static nokprobe_inline bool kprobe_page_fault(struct pt_regs *regs,
>> + unsigned int trap)
>> +{
>> + int ret = 0;
>> +
>> + /*
>> + * To be potentially processing a kprobe fault and to be allowed
>> + * to call kprobe_running(), we have to be non-preemptible.
>> + */
>> + if (kprobes_built_in() && !preemptible() && !user_mode(regs)) {
>> + if (kprobe_running() && kprobe_fault_handler(regs, trap))
>> + ret = 1;
>> + }
>> + return ret;
>> +}
>
> Nits: Other that taking the nice, readable, x86 one and globbing it onto
> a single line, looks OK to me. It does seem a _bit_ silly to go to the
> trouble of converting to 'bool' and then using 0/1 and an 'int'
> internally instead of true/false and a bool, though. It's also not a
Changing to 'bool'...
> horrible thing to add a single line comment to this sucker to say:
>
> /* returns true if kprobes handled the fault */
>
Picking this in-code comment.
> In any case, and even if you don't clean any of this up:
>
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
>
Thanks !
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Michal Hocko <mhocko@suse.com>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>,
Paul Mackerras <paulus@samba.org>,
sparclinux@vger.kernel.org, linux-s390@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
x86@kernel.org, Russell King <linux@armlinux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Fenghua Yu <fenghua.yu@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrey Konovalov <andreyknvl@google.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Tony Luck <tony.luck@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC V3] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()
Date: Mon, 10 Jun 2019 10:06:34 +0530 [thread overview]
Message-ID: <bc8e2140-dc78-ce99-a336-91733c2fda67@arm.com> (raw)
In-Reply-To: <6e095842-0f7f-f428-653d-2b6e98fea6b3@intel.com>
On 06/07/2019 08:36 PM, Dave Hansen wrote:
> On 6/7/19 3:34 AM, Anshuman Khandual wrote:
>> +static nokprobe_inline bool kprobe_page_fault(struct pt_regs *regs,
>> + unsigned int trap)
>> +{
>> + int ret = 0;
>> +
>> + /*
>> + * To be potentially processing a kprobe fault and to be allowed
>> + * to call kprobe_running(), we have to be non-preemptible.
>> + */
>> + if (kprobes_built_in() && !preemptible() && !user_mode(regs)) {
>> + if (kprobe_running() && kprobe_fault_handler(regs, trap))
>> + ret = 1;
>> + }
>> + return ret;
>> +}
>
> Nits: Other that taking the nice, readable, x86 one and globbing it onto
> a single line, looks OK to me. It does seem a _bit_ silly to go to the
> trouble of converting to 'bool' and then using 0/1 and an 'int'
> internally instead of true/false and a bool, though. It's also not a
Changing to 'bool'...
> horrible thing to add a single line comment to this sucker to say:
>
> /* returns true if kprobes handled the fault */
>
Picking this in-code comment.
> In any case, and even if you don't clean any of this up:
>
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
>
Thanks !
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Michal Hocko <mhocko@suse.com>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>,
Paul Mackerras <paulus@samba.org>,
sparclinux@vger.kernel.org, linux-s390@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
x86@kernel.org, Russell King <linux@armlinux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Fenghua Yu <fenghua.yu@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrey Konovalov <andreyknvl@google.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Christophe Leroy <christophe.leroy@c-s.fr>,
Tony Luck <tony.luck@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC V3] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()
Date: Mon, 10 Jun 2019 10:06:34 +0530 [thread overview]
Message-ID: <bc8e2140-dc78-ce99-a336-91733c2fda67@arm.com> (raw)
In-Reply-To: <6e095842-0f7f-f428-653d-2b6e98fea6b3@intel.com>
On 06/07/2019 08:36 PM, Dave Hansen wrote:
> On 6/7/19 3:34 AM, Anshuman Khandual wrote:
>> +static nokprobe_inline bool kprobe_page_fault(struct pt_regs *regs,
>> + unsigned int trap)
>> +{
>> + int ret = 0;
>> +
>> + /*
>> + * To be potentially processing a kprobe fault and to be allowed
>> + * to call kprobe_running(), we have to be non-preemptible.
>> + */
>> + if (kprobes_built_in() && !preemptible() && !user_mode(regs)) {
>> + if (kprobe_running() && kprobe_fault_handler(regs, trap))
>> + ret = 1;
>> + }
>> + return ret;
>> +}
>
> Nits: Other that taking the nice, readable, x86 one and globbing it onto
> a single line, looks OK to me. It does seem a _bit_ silly to go to the
> trouble of converting to 'bool' and then using 0/1 and an 'int'
> internally instead of true/false and a bool, though. It's also not a
Changing to 'bool'...
> horrible thing to add a single line comment to this sucker to say:
>
> /* returns true if kprobes handled the fault */
>
Picking this in-code comment.
> In any case, and even if you don't clean any of this up:
>
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
>
Thanks !
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-10 4:48 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 10:34 [RFC V3] mm: Generalize and rename notify_page_fault() as kprobe_page_fault() Anshuman Khandual
2019-06-07 10:46 ` Anshuman Khandual
2019-06-07 10:34 ` Anshuman Khandual
2019-06-07 10:34 ` Anshuman Khandual
2019-06-07 12:03 ` Stephen Rothwell
2019-06-07 12:03 ` Stephen Rothwell
2019-06-07 12:03 ` Stephen Rothwell
2019-06-07 12:03 ` Stephen Rothwell
2019-06-10 2:23 ` Anshuman Khandual
2019-06-10 2:35 ` Anshuman Khandual
2019-06-10 2:23 ` Anshuman Khandual
2019-06-10 2:23 ` Anshuman Khandual
2019-06-07 15:06 ` Dave Hansen
2019-06-07 15:06 ` Dave Hansen
2019-06-07 15:06 ` Dave Hansen
2019-06-07 15:06 ` Dave Hansen
2019-06-10 4:36 ` Anshuman Khandual [this message]
2019-06-10 4:48 ` Anshuman Khandual
2019-06-10 4:36 ` Anshuman Khandual
2019-06-10 4:36 ` Anshuman Khandual
2019-06-07 15:31 ` Christophe Leroy
2019-06-07 15:31 ` Christophe Leroy
2019-06-07 15:31 ` Christophe Leroy
2019-06-07 15:31 ` Christophe Leroy
2019-06-10 2:39 ` Anshuman Khandual
2019-06-10 2:51 ` Anshuman Khandual
2019-06-10 2:39 ` Anshuman Khandual
2019-06-10 2:39 ` Anshuman Khandual
2019-06-10 15:27 ` Leonardo Bras
2019-06-10 15:27 ` Leonardo Bras
2019-06-10 15:27 ` Leonardo Bras
2019-06-10 15:27 ` Leonardo Bras
2019-06-11 5:14 ` Anshuman Khandual
2019-06-11 5:26 ` Anshuman Khandual
2019-06-11 5:14 ` Anshuman Khandual
2019-06-11 5:14 ` Anshuman Khandual
2019-06-11 17:31 ` Leonardo Bras
2019-06-11 17:31 ` Leonardo Bras
2019-06-11 17:31 ` Leonardo Bras
2019-06-11 4:46 ` Christophe Leroy
2019-06-11 4:46 ` Christophe Leroy
2019-06-11 4:46 ` Christophe Leroy
2019-06-11 4:46 ` Christophe Leroy
2019-06-11 5:15 ` Anshuman Khandual
2019-06-11 5:27 ` Anshuman Khandual
2019-06-11 5:15 ` Anshuman Khandual
2019-06-11 5:15 ` Anshuman Khandual
2019-06-07 20:12 ` Matthew Wilcox
2019-06-07 20:12 ` Matthew Wilcox
2019-06-07 20:12 ` Matthew Wilcox
2019-06-07 20:12 ` Matthew Wilcox
2019-06-10 4:34 ` Anshuman Khandual
2019-06-10 4:46 ` Anshuman Khandual
2019-06-10 4:34 ` Anshuman Khandual
2019-06-10 4:34 ` Anshuman Khandual
2019-06-10 4:34 ` Anshuman Khandual
2019-06-10 4:57 ` Dave Hansen
2019-06-10 4:57 ` Dave Hansen
2019-06-10 4:57 ` Dave Hansen
2019-06-10 4:57 ` Dave Hansen
2019-06-10 4:57 ` Dave Hansen
2019-06-10 5:06 ` Anshuman Khandual
2019-06-10 5:18 ` Anshuman Khandual
2019-06-10 5:06 ` Anshuman Khandual
2019-06-10 5:06 ` Anshuman Khandual
2019-06-10 5:06 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8e2140-dc78-ce99-a336-91733c2fda67@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@c-s.fr \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.