Re: [PATCH v2 00/11] PS/2 controller related fixes

From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 00/11] PS/2 controller related fixes
Date: Sun, 9 May 2021 18:03:49 +0200	[thread overview]
Message-ID: <bca8cfb0-06b5-2665-c36e-d2da5cb818d1@t-online.de> (raw)
In-Reply-To: <a898b0d5-7086-9699-ae8b-9524ad319b01@t-online.de>

> This patch series fixes two different PS/2 mouse stream corruptions
> and adds a feature that allows some old misbehaving DOS programs to
> have a working keyboard. With the last few patches, the PS/2 con-
> troller behaves more like a real controller.
>
> v2:
> Introduce the function kbd_pending() in a preliminary patch to ease
> the review of patch "pckbd: correctly disable PS/2 communication",
> as Philippe suggested.
>
> Volker Rümelin (11):
>   ps2: fix mouse stream corruption
>   ps2: don't raise an interrupt if queue is full
>   ps2: don't deassert irq twice if queue is empty
>   pckbd: split out interrupt line changing code
>   pckbd: don't update OBF flags if KBD_STAT_OBF is set
>   pckbd: PS/2 keyboard throttle
>   pckbd: add state variable for interrupt source
>   pckbd: add controller response queue
>   pckbd: add function kbd_pending()
>   pckbd: correctly disable PS/2 communication
>   pckbd: remove duplicated keyboard and mouse defines

I'm sorry, there is a bug somewhere in this series. Seabios sometimes
doesn't detect the PS/2 keyboard. Please ignore this series for now.

With best regards,
Volker

>
>  hw/input/pckbd.c | 293 ++++++++++++++++++++++++++++++++++-------------
>  hw/input/ps2.c   |  11 +-
>  2 files changed, 223 insertions(+), 81 deletions(-)
>