From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 00/11] PS/2 controller related fixes
Date: Mon, 10 May 2021 22:41:18 +0200 [thread overview]
Message-ID: <f0562d4f-af20-0ec6-eb69-7bcaae33726f@t-online.de> (raw)
In-Reply-To: <bca8cfb0-06b5-2665-c36e-d2da5cb818d1@t-online.de>
>> This patch series fixes two different PS/2 mouse stream corruptions
>> and adds a feature that allows some old misbehaving DOS programs to
>> have a working keyboard. With the last few patches, the PS/2 con-
>> troller behaves more like a real controller.
>>
>> v2:
>> Introduce the function kbd_pending() in a preliminary patch to ease
>> the review of patch "pckbd: correctly disable PS/2 communication",
>> as Philippe suggested.
>>
>> Volker Rümelin (11):
>> ps2: fix mouse stream corruption
>> ps2: don't raise an interrupt if queue is full
>> ps2: don't deassert irq twice if queue is empty
>> pckbd: split out interrupt line changing code
>> pckbd: don't update OBF flags if KBD_STAT_OBF is set
>> pckbd: PS/2 keyboard throttle
>> pckbd: add state variable for interrupt source
>> pckbd: add controller response queue
>> pckbd: add function kbd_pending()
>> pckbd: correctly disable PS/2 communication
>> pckbd: remove duplicated keyboard and mouse defines
>
> I'm sorry, there is a bug somewhere in this series. Seabios sometimes
> doesn't detect the PS/2 keyboard. Please ignore this series for now.
>
This is a Seabios bug. Seabios expects the PS/2 controller doesn't
generate interrupts after it sends the command KBD_CCMD_KBD_DISABLE
to the controller. Even the original author of the pckbd code wrote
in a comment that this is incorrect. I will send a version 3 series
where I don't fix the incorrectness.
> With best regards,
> Volker
>
>>
>> hw/input/pckbd.c | 293 ++++++++++++++++++++++++++++++++++-------------
>> hw/input/ps2.c | 11 +-
>> 2 files changed, 223 insertions(+), 81 deletions(-)
>>
>
prev parent reply other threads:[~2021-05-10 20:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:08 [PATCH v2 00/11] PS/2 controller related fixes Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 01/11] ps2: fix mouse stream corruption Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 02/11] ps2: don't raise an interrupt if queue is full Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 03/11] ps2: don't deassert irq twice if queue is empty Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 04/11] pckbd: split out interrupt line changing code Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 05/11] pckbd: don't update OBF flags if KBD_STAT_OBF is set Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 06/11] pckbd: PS/2 keyboard throttle Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 07/11] pckbd: add state variable for interrupt source Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 08/11] pckbd: add controller response queue Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 09/11] pckbd: add function kbd_pending() Volker Rümelin
2021-05-07 21:37 ` Philippe Mathieu-Daudé
2021-05-07 18:09 ` [PATCH v2 10/11] pckbd: correctly disable PS/2 communication Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 11/11] pckbd: remove duplicated keyboard and mouse defines Volker Rümelin
2021-05-09 16:03 ` [PATCH v2 00/11] PS/2 controller related fixes Volker Rümelin
2021-05-10 20:41 ` Volker Rümelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0562d4f-af20-0ec6-eb69-7bcaae33726f@t-online.de \
--to=vr_qemu@t-online.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.