From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jason Gunthorpe <jgg@nvidia.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Clint Sbisa <csbisa@amazon.com>,
linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
linux-arm-kernel@lists.infradead.org, will@kernel.org,
catalin.marinas@arm.com, Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] arm64: Enable PCI write-combine resources under sysfs
Date: Wed, 16 Sep 2020 09:17:38 +1000 [thread overview]
Message-ID: <bcb95faafa72734478b942084a9d24a61ae9887f.camel@kernel.crashing.org> (raw)
In-Reply-To: <20200915110511.GQ904879@nvidia.com>
On Tue, 2020-09-15 at 08:05 -0300, Jason Gunthorpe wrote:
> > To sum it up:
> >
> > (1) RDMA drivers need a new mapping function/attribute to define their
> > message push model. Actually the message model is not necessarily related
> > to write combining a la x86, so we should probably come up with a better
> > and consistent naming. Enabling this patchset may trigger performance
> > regressions on mellanox drivers on arm64 - this ought to be
> > addressed.
>
> It is pretty clear now that the certain ARM chips that don't do write
> combining with pgprot_writecombine will performance regress if they
> are running a certain uncommon Mellanox configuration. I suspect these
> deployments are all running the out of tree patch for DEVICE_GRE
> though.
I'm not sure I understand...
Today those ARM chips will not use pgprot_writecombine (at least not
using that code path, they might still use it as the result of the
other path in the driver that can enable it). So they get
MT_DEVICE_nGnRnE (unless I missed something here).
So they will not combine.
With the patch, those device will now use MT_DEVICE_NC.
Why would that be a regression ? It will allow speculation, that
doesn't necessarily mean that the CPU will cause spurrious accesses, it
probably won't in most case... And it should allow combining, no ?
BTW. Lorenzo, why don't we use MT_DEVICE_GRE for pgprot_writecombine ?
Its not supported on some chips ?
Not that this lead me to discover annother weird thing ...
What on earth is pgprot_device() ? This is new ? On ARM it will be
MT_DEVICE_nGnRE, so it allows posted write. It seems to match what
ioremap does. Should then ioremap use it as well ?
But it's only ever used for PCI mmap. Why is it different from
pgprot_noncached() which disables posted writes (nE) ?
Because a whole lot of drivers will use pgprot_noncached() explicitly
in either mmap or vmap, with the expectation that it's somewhat the
same as what ioremap does...
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jason Gunthorpe <jgg@nvidia.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Leon Romanovsky <leon@kernel.org>,
linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
Clint Sbisa <csbisa@amazon.com>
Subject: Re: [PATCH] arm64: Enable PCI write-combine resources under sysfs
Date: Wed, 16 Sep 2020 09:17:38 +1000 [thread overview]
Message-ID: <bcb95faafa72734478b942084a9d24a61ae9887f.camel@kernel.crashing.org> (raw)
In-Reply-To: <20200915110511.GQ904879@nvidia.com>
On Tue, 2020-09-15 at 08:05 -0300, Jason Gunthorpe wrote:
> > To sum it up:
> >
> > (1) RDMA drivers need a new mapping function/attribute to define their
> > message push model. Actually the message model is not necessarily related
> > to write combining a la x86, so we should probably come up with a better
> > and consistent naming. Enabling this patchset may trigger performance
> > regressions on mellanox drivers on arm64 - this ought to be
> > addressed.
>
> It is pretty clear now that the certain ARM chips that don't do write
> combining with pgprot_writecombine will performance regress if they
> are running a certain uncommon Mellanox configuration. I suspect these
> deployments are all running the out of tree patch for DEVICE_GRE
> though.
I'm not sure I understand...
Today those ARM chips will not use pgprot_writecombine (at least not
using that code path, they might still use it as the result of the
other path in the driver that can enable it). So they get
MT_DEVICE_nGnRnE (unless I missed something here).
So they will not combine.
With the patch, those device will now use MT_DEVICE_NC.
Why would that be a regression ? It will allow speculation, that
doesn't necessarily mean that the CPU will cause spurrious accesses, it
probably won't in most case... And it should allow combining, no ?
BTW. Lorenzo, why don't we use MT_DEVICE_GRE for pgprot_writecombine ?
Its not supported on some chips ?
Not that this lead me to discover annother weird thing ...
What on earth is pgprot_device() ? This is new ? On ARM it will be
MT_DEVICE_nGnRE, so it allows posted write. It seems to match what
ioremap does. Should then ioremap use it as well ?
But it's only ever used for PCI mmap. Why is it different from
pgprot_noncached() which disables posted writes (nE) ?
Because a whole lot of drivers will use pgprot_noncached() explicitly
in either mmap or vmap, with the expectation that it's somewhat the
same as what ioremap does...
Cheers,
Ben.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 23:18 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 15:18 [PATCH] arm64: Enable PCI write-combine resources under sysfs Clint Sbisa
2020-08-31 23:24 ` Benjamin Herrenschmidt
2020-09-01 18:37 ` Bjorn Helgaas
2020-09-01 23:22 ` Benjamin Herrenschmidt
2020-09-02 8:57 ` Will Deacon
2020-09-02 11:32 ` Lorenzo Pieralisi
2020-09-02 14:29 ` Clint Sbisa
2020-09-02 16:47 ` Lorenzo Pieralisi
2020-09-02 16:47 ` Lorenzo Pieralisi
2020-09-02 17:21 ` Catalin Marinas
2020-09-02 17:21 ` Catalin Marinas
2020-09-02 17:54 ` Lorenzo Pieralisi
2020-09-02 17:54 ` Lorenzo Pieralisi
2020-09-02 23:03 ` Benjamin Herrenschmidt
2020-09-02 23:03 ` Benjamin Herrenschmidt
2020-09-02 23:08 ` Benjamin Herrenschmidt
2020-09-02 23:08 ` Benjamin Herrenschmidt
2020-09-02 23:08 ` Benjamin Herrenschmidt
2020-09-02 23:08 ` Benjamin Herrenschmidt
2020-09-02 23:07 ` Benjamin Herrenschmidt
2020-09-02 23:07 ` Benjamin Herrenschmidt
2020-09-03 11:08 ` Lorenzo Pieralisi
2020-09-03 11:08 ` Lorenzo Pieralisi
2020-09-03 14:36 ` Clint Sbisa
2020-09-03 14:36 ` Clint Sbisa
2020-09-03 22:26 ` Benjamin Herrenschmidt
2020-09-03 22:26 ` Benjamin Herrenschmidt
2020-09-07 23:33 ` Benjamin Herrenschmidt
2020-09-07 23:33 ` Benjamin Herrenschmidt
2020-09-10 9:46 ` Lorenzo Pieralisi
2020-09-10 9:46 ` Lorenzo Pieralisi
2020-09-10 10:54 ` Leon Romanovsky
2020-09-10 10:54 ` Leon Romanovsky
2020-09-10 12:37 ` Jason Gunthorpe
2020-09-10 12:37 ` Jason Gunthorpe
2020-09-10 15:17 ` Lorenzo Pieralisi
2020-09-10 15:17 ` Lorenzo Pieralisi
2020-09-10 17:10 ` Jason Gunthorpe
2020-09-10 17:10 ` Jason Gunthorpe
2020-09-10 21:46 ` Benjamin Herrenschmidt
2020-09-10 21:46 ` Benjamin Herrenschmidt
2020-09-10 23:29 ` Jason Gunthorpe
2020-09-10 23:29 ` Jason Gunthorpe
2020-09-11 0:39 ` Benjamin Herrenschmidt
2020-09-11 0:39 ` Benjamin Herrenschmidt
2020-09-11 14:21 ` Jason Gunthorpe
2020-09-11 14:21 ` Jason Gunthorpe
2020-09-11 21:42 ` Clint Sbisa
2020-09-11 21:42 ` Clint Sbisa
2020-09-14 14:17 ` Jason Gunthorpe
2020-09-14 14:17 ` Jason Gunthorpe
2020-09-14 14:24 ` Clint Sbisa
2020-09-14 14:24 ` Clint Sbisa
2020-09-14 14:38 ` Jason Gunthorpe
2020-09-14 14:38 ` Jason Gunthorpe
2020-09-14 21:42 ` Benjamin Herrenschmidt
2020-09-14 21:42 ` Benjamin Herrenschmidt
2020-09-14 22:00 ` Benjamin Herrenschmidt
2020-09-14 22:00 ` Benjamin Herrenschmidt
2020-09-14 22:32 ` Clint Sbisa
2020-09-14 22:32 ` Clint Sbisa
2020-09-14 22:57 ` Jason Gunthorpe
2020-09-14 22:57 ` Jason Gunthorpe
2020-09-14 23:25 ` Benjamin Herrenschmidt
2020-09-14 23:25 ` Benjamin Herrenschmidt
2020-09-15 10:18 ` Lorenzo Pieralisi
2020-09-15 10:18 ` Lorenzo Pieralisi
2020-09-15 11:05 ` Jason Gunthorpe
2020-09-15 11:05 ` Jason Gunthorpe
2020-09-15 23:17 ` Benjamin Herrenschmidt [this message]
2020-09-15 23:17 ` Benjamin Herrenschmidt
2020-09-15 23:40 ` Jason Gunthorpe
2020-09-15 23:40 ` Jason Gunthorpe
2020-09-16 7:59 ` Benjamin Herrenschmidt
2020-09-16 7:59 ` Benjamin Herrenschmidt
2020-09-16 12:12 ` Jason Gunthorpe
2020-09-16 12:12 ` Jason Gunthorpe
2020-09-16 14:09 ` Lorenzo Pieralisi
2020-09-16 14:09 ` Lorenzo Pieralisi
2020-09-16 14:14 ` Jason Gunthorpe
2020-09-16 14:14 ` Jason Gunthorpe
2020-09-16 23:59 ` Benjamin Herrenschmidt
2020-09-16 23:59 ` Benjamin Herrenschmidt
2020-09-17 10:28 ` Lorenzo Pieralisi
2020-09-17 10:28 ` Lorenzo Pieralisi
2020-09-17 11:32 ` Jason Gunthorpe
2020-09-17 11:32 ` Jason Gunthorpe
2020-09-17 14:01 ` Lorenzo Pieralisi
2020-09-17 14:01 ` Lorenzo Pieralisi
2020-09-17 16:08 ` Will Deacon
2020-09-17 16:08 ` Will Deacon
2020-09-16 12:48 ` Leon Romanovsky
2020-09-16 12:48 ` Leon Romanovsky
2020-09-16 8:33 ` Will Deacon
2020-09-16 8:33 ` Will Deacon
2020-09-16 8:48 ` Catalin Marinas
2020-09-16 8:48 ` Catalin Marinas
2020-09-16 14:15 ` Lorenzo Pieralisi
2020-09-16 14:15 ` Lorenzo Pieralisi
2020-09-16 17:00 ` Catalin Marinas
2020-09-16 17:00 ` Catalin Marinas
2020-09-16 21:29 ` Benjamin Herrenschmidt
2020-09-16 21:29 ` Benjamin Herrenschmidt
2020-09-16 12:08 ` Jason Gunthorpe
2020-09-16 12:08 ` Jason Gunthorpe
2020-09-15 23:00 ` Benjamin Herrenschmidt
2020-09-15 23:00 ` Benjamin Herrenschmidt
2020-09-15 23:12 ` Clint Sbisa
2020-09-15 23:12 ` Clint Sbisa
2020-09-14 21:41 ` Benjamin Herrenschmidt
2020-09-14 21:41 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2020-08-21 15:51 Clint Sbisa
2020-08-21 15:51 ` Clint Sbisa
2020-08-27 14:41 ` Clint Sbisa
2020-08-27 14:41 ` Clint Sbisa
2020-08-31 15:22 ` Clint Sbisa
2020-08-31 15:22 ` Clint Sbisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcb95faafa72734478b942084a9d24a61ae9887f.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=csbisa@amazon.com \
--cc=helgaas@kernel.org \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.