From: Sungbo Eo <mans0n@gorani.run> To: Marc Zyngier <maz@kernel.org> Cc: linux-oxnas@groups.io, Linus Walleij <linus.walleij@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong <narmstrong@baylibre.com> Subject: Re: [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly Date: Thu, 19 Mar 2020 03:20:13 +0900 [thread overview] Message-ID: <bdb90bd8-ede1-63d5-816c-57f6bf0417a4@gorani.run> (raw) In-Reply-To: <112cdab389aa9cc30189c7aec0baded2@kernel.org> Hi Marc, On 2020-03-19 02:48, Marc Zyngier wrote: > Hi Sungbo, > > On 2020-03-18 17:09, Sungbo Eo wrote: >> Enclose the chained handler with chained_irq_{enter,exit}(), so that the >> muxed interrupts get properly acked. >> >> This patch also fixes a reboot bug on OX820 SoC, where the jiffies timer >> interrupt is never acked. The kernel waits a clock tick forever in >> calibrate_delay_converge(), which leads to a boot hang. > > Nice catch. > >> >> Signed-off-by: Sungbo Eo <mans0n@gorani.run> >> Cc: Neil Armstrong <narmstrong@baylibre.com> >> --- >> drivers/irqchip/irq-versatile-fpga.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/irq-versatile-fpga.c >> b/drivers/irqchip/irq-versatile-fpga.c >> index 928858dada75..08faab2fec3e 100644 >> --- a/drivers/irqchip/irq-versatile-fpga.c >> +++ b/drivers/irqchip/irq-versatile-fpga.c >> @@ -6,6 +6,7 @@ >> #include <linux/irq.h> >> #include <linux/io.h> >> #include <linux/irqchip.h> >> +#include <linux/irqchip/chained_irq.h> >> #include <linux/irqchip/versatile-fpga.h> >> #include <linux/irqdomain.h> >> #include <linux/module.h> >> @@ -68,12 +69,15 @@ static void fpga_irq_unmask(struct irq_data *d) >> >> static void fpga_irq_handle(struct irq_desc *desc) >> { >> + struct irq_chip *chip = irq_desc_get_chip(desc); >> struct fpga_irq_data *f = irq_desc_get_handler_data(desc); >> u32 status = readl(f->base + IRQ_STATUS); >> >> + chained_irq_enter(chip, desc); >> + > > It's probably not a big deal, but I'm not fond of starting talking to > the muxing irqchip before having done the chained_irq_enter() call. > > Moving that read here would probably be safer. Oops, I missed it. Thanks for pointing it out. > >> if (status == 0) { >> do_bad_IRQ(desc); >> - return; >> + goto out; >> } >> >> do { >> @@ -82,6 +86,9 @@ static void fpga_irq_handle(struct irq_desc *desc) >> status &= ~(1 << irq); >> generic_handle_irq(irq_find_mapping(f->domain, irq)); >> } while (status); >> + >> +out: >> + chained_irq_exit(chip, desc); >> } >> >> /* > > Otherwise looks good. If you send it again with the above fixed > and a Fixes: tag, I'll queue it. It seems the handler had been broken from the very beginning. Could you give me a hint on how the tag should be like? Thanks. > > Thanks, > > M.
WARNING: multiple messages have this Message-ID (diff)
From: Sungbo Eo <mans0n@gorani.run> To: Marc Zyngier <maz@kernel.org> Cc: Jason Cooper <jason@lakedaemon.net>, Neil Armstrong <narmstrong@baylibre.com>, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, linux-oxnas@groups.io, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly Date: Thu, 19 Mar 2020 03:20:13 +0900 [thread overview] Message-ID: <bdb90bd8-ede1-63d5-816c-57f6bf0417a4@gorani.run> (raw) In-Reply-To: <112cdab389aa9cc30189c7aec0baded2@kernel.org> Hi Marc, On 2020-03-19 02:48, Marc Zyngier wrote: > Hi Sungbo, > > On 2020-03-18 17:09, Sungbo Eo wrote: >> Enclose the chained handler with chained_irq_{enter,exit}(), so that the >> muxed interrupts get properly acked. >> >> This patch also fixes a reboot bug on OX820 SoC, where the jiffies timer >> interrupt is never acked. The kernel waits a clock tick forever in >> calibrate_delay_converge(), which leads to a boot hang. > > Nice catch. > >> >> Signed-off-by: Sungbo Eo <mans0n@gorani.run> >> Cc: Neil Armstrong <narmstrong@baylibre.com> >> --- >> drivers/irqchip/irq-versatile-fpga.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/irq-versatile-fpga.c >> b/drivers/irqchip/irq-versatile-fpga.c >> index 928858dada75..08faab2fec3e 100644 >> --- a/drivers/irqchip/irq-versatile-fpga.c >> +++ b/drivers/irqchip/irq-versatile-fpga.c >> @@ -6,6 +6,7 @@ >> #include <linux/irq.h> >> #include <linux/io.h> >> #include <linux/irqchip.h> >> +#include <linux/irqchip/chained_irq.h> >> #include <linux/irqchip/versatile-fpga.h> >> #include <linux/irqdomain.h> >> #include <linux/module.h> >> @@ -68,12 +69,15 @@ static void fpga_irq_unmask(struct irq_data *d) >> >> static void fpga_irq_handle(struct irq_desc *desc) >> { >> + struct irq_chip *chip = irq_desc_get_chip(desc); >> struct fpga_irq_data *f = irq_desc_get_handler_data(desc); >> u32 status = readl(f->base + IRQ_STATUS); >> >> + chained_irq_enter(chip, desc); >> + > > It's probably not a big deal, but I'm not fond of starting talking to > the muxing irqchip before having done the chained_irq_enter() call. > > Moving that read here would probably be safer. Oops, I missed it. Thanks for pointing it out. > >> if (status == 0) { >> do_bad_IRQ(desc); >> - return; >> + goto out; >> } >> >> do { >> @@ -82,6 +86,9 @@ static void fpga_irq_handle(struct irq_desc *desc) >> status &= ~(1 << irq); >> generic_handle_irq(irq_find_mapping(f->domain, irq)); >> } while (status); >> + >> +out: >> + chained_irq_exit(chip, desc); >> } >> >> /* > > Otherwise looks good. If you send it again with the above fixed > and a Fixes: tag, I'll queue it. It seems the handler had been broken from the very beginning. Could you give me a hint on how the tag should be like? Thanks. > > Thanks, > > M. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-19 8:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-18 17:09 [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly Sungbo Eo 2020-03-18 17:09 ` Sungbo Eo 2020-03-18 17:48 ` Marc Zyngier 2020-03-18 17:48 ` Marc Zyngier 2020-03-18 18:20 ` Sungbo Eo [this message] 2020-03-18 18:20 ` Sungbo Eo 2020-03-18 19:11 ` Marc Zyngier 2020-03-18 19:11 ` Marc Zyngier 2020-03-19 2:34 ` [PATCH v2] " Sungbo Eo 2020-03-19 2:34 ` Sungbo Eo 2020-03-19 8:44 ` Marc Zyngier 2020-03-19 8:44 ` Marc Zyngier 2020-03-19 22:56 ` [linux-oxnas] " Daniel Golle 2020-03-27 10:28 ` Linus Walleij 2020-03-27 10:28 ` Linus Walleij 2020-03-29 20:26 ` [tip: irq/core] " tip-bot2 for Sungbo Eo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bdb90bd8-ede1-63d5-816c-57f6bf0417a4@gorani.run \ --to=mans0n@gorani.run \ --cc=jason@lakedaemon.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-oxnas@groups.io \ --cc=maz@kernel.org \ --cc=narmstrong@baylibre.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.