From: Johan Jonker <jbx6244@gmail.com>
To: Alex Bee <knaerzche@gmail.com>, heiko@sntech.de, hjc@rock-chips.com
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node
Date: Mon, 4 Dec 2023 21:25:27 +0100 [thread overview]
Message-ID: <bdda61be-8e02-36f5-6261-37d4b75278ba@gmail.com> (raw)
In-Reply-To: <447b1bde-584f-4eb4-8bfb-9abd3aa8b6fa@gmail.com>
Hi Alex, Heiko,
On 12/4/23 20:12, Alex Bee wrote:
> Hi Johan,
> Am 04.12.23 um 18:40 schrieb Johan Jonker:
>> Add hdmi-connector node to comply with the inno_hdmi binding.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>> arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> index 67e1e04139e7..a213333be011 100644
>> --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> @@ -13,6 +13,17 @@ memory@60000000 {
>> reg = <0x60000000 0x20000000>;
>> };
>>
>> + hdmi_con: hdmi-con {
>> + compatible = "hdmi-connector";
>> + type = "c";
> According to [0], kylin has an A-Type HDMI port - so this should be
> + type = "a";
> > [0] http://rockchip.wikidot.com/kylin
Not sure from the text or do I miss something...
I did look at that board picture before submitting.
Can be wrong, but to me it looks a smaller HDMI connector.
Does anyone have a Kylin picture from a different angle?
Or reference design?
Else apply and fix later? (Heiko ?)
Let me know.
Johan
>
> Regards,
> Alex
>> +
>> + port {
>> + hdmi_con_in: endpoint {
>> + remote-endpoint = <&hdmi_out_con>;
>> + };
>> + };
>> + };
>> +
>> leds: gpio-leds {
>> compatible = "gpio-leds";
>>
>> @@ -110,6 +121,12 @@ &hdmi {
>> status = "okay";
>> };
>>
>> +&hdmi_out {
>> + hdmi_out_con: endpoint {
>> + remote-endpoint = <&hdmi_con_in>;
>> + };
>> +};
>> +
>> &i2c1 {
>> clock-frequency = <400000>;
>>
>> --
>> 2.39.2
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Alex Bee <knaerzche@gmail.com>, heiko@sntech.de, hjc@rock-chips.com
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node
Date: Mon, 4 Dec 2023 21:25:27 +0100 [thread overview]
Message-ID: <bdda61be-8e02-36f5-6261-37d4b75278ba@gmail.com> (raw)
In-Reply-To: <447b1bde-584f-4eb4-8bfb-9abd3aa8b6fa@gmail.com>
Hi Alex, Heiko,
On 12/4/23 20:12, Alex Bee wrote:
> Hi Johan,
> Am 04.12.23 um 18:40 schrieb Johan Jonker:
>> Add hdmi-connector node to comply with the inno_hdmi binding.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>> arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> index 67e1e04139e7..a213333be011 100644
>> --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> @@ -13,6 +13,17 @@ memory@60000000 {
>> reg = <0x60000000 0x20000000>;
>> };
>>
>> + hdmi_con: hdmi-con {
>> + compatible = "hdmi-connector";
>> + type = "c";
> According to [0], kylin has an A-Type HDMI port - so this should be
> + type = "a";
> > [0] http://rockchip.wikidot.com/kylin
Not sure from the text or do I miss something...
I did look at that board picture before submitting.
Can be wrong, but to me it looks a smaller HDMI connector.
Does anyone have a Kylin picture from a different angle?
Or reference design?
Else apply and fix later? (Heiko ?)
Let me know.
Johan
>
> Regards,
> Alex
>> +
>> + port {
>> + hdmi_con_in: endpoint {
>> + remote-endpoint = <&hdmi_out_con>;
>> + };
>> + };
>> + };
>> +
>> leds: gpio-leds {
>> compatible = "gpio-leds";
>>
>> @@ -110,6 +121,12 @@ &hdmi {
>> status = "okay";
>> };
>>
>> +&hdmi_out {
>> + hdmi_out_con: endpoint {
>> + remote-endpoint = <&hdmi_con_in>;
>> + };
>> +};
>> +
>> &i2c1 {
>> clock-frequency = <400000>;
>>
>> --
>> 2.39.2
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Alex Bee <knaerzche@gmail.com>, heiko@sntech.de, hjc@rock-chips.com
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node
Date: Mon, 4 Dec 2023 21:25:27 +0100 [thread overview]
Message-ID: <bdda61be-8e02-36f5-6261-37d4b75278ba@gmail.com> (raw)
In-Reply-To: <447b1bde-584f-4eb4-8bfb-9abd3aa8b6fa@gmail.com>
Hi Alex, Heiko,
On 12/4/23 20:12, Alex Bee wrote:
> Hi Johan,
> Am 04.12.23 um 18:40 schrieb Johan Jonker:
>> Add hdmi-connector node to comply with the inno_hdmi binding.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>> arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> index 67e1e04139e7..a213333be011 100644
>> --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> @@ -13,6 +13,17 @@ memory@60000000 {
>> reg = <0x60000000 0x20000000>;
>> };
>>
>> + hdmi_con: hdmi-con {
>> + compatible = "hdmi-connector";
>> + type = "c";
> According to [0], kylin has an A-Type HDMI port - so this should be
> + type = "a";
> > [0] http://rockchip.wikidot.com/kylin
Not sure from the text or do I miss something...
I did look at that board picture before submitting.
Can be wrong, but to me it looks a smaller HDMI connector.
Does anyone have a Kylin picture from a different angle?
Or reference design?
Else apply and fix later? (Heiko ?)
Let me know.
Johan
>
> Regards,
> Alex
>> +
>> + port {
>> + hdmi_con_in: endpoint {
>> + remote-endpoint = <&hdmi_out_con>;
>> + };
>> + };
>> + };
>> +
>> leds: gpio-leds {
>> compatible = "gpio-leds";
>>
>> @@ -110,6 +121,12 @@ &hdmi {
>> status = "okay";
>> };
>>
>> +&hdmi_out {
>> + hdmi_out_con: endpoint {
>> + remote-endpoint = <&hdmi_con_in>;
>> + };
>> +};
>> +
>> &i2c1 {
>> clock-frequency = <400000>;
>>
>> --
>> 2.39.2
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Alex Bee <knaerzche@gmail.com>, heiko@sntech.de, hjc@rock-chips.com
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
tzimmermann@suse.de, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, mripard@kernel.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node
Date: Mon, 4 Dec 2023 21:25:27 +0100 [thread overview]
Message-ID: <bdda61be-8e02-36f5-6261-37d4b75278ba@gmail.com> (raw)
In-Reply-To: <447b1bde-584f-4eb4-8bfb-9abd3aa8b6fa@gmail.com>
Hi Alex, Heiko,
On 12/4/23 20:12, Alex Bee wrote:
> Hi Johan,
> Am 04.12.23 um 18:40 schrieb Johan Jonker:
>> Add hdmi-connector node to comply with the inno_hdmi binding.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>> arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> index 67e1e04139e7..a213333be011 100644
>> --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts
>> @@ -13,6 +13,17 @@ memory@60000000 {
>> reg = <0x60000000 0x20000000>;
>> };
>>
>> + hdmi_con: hdmi-con {
>> + compatible = "hdmi-connector";
>> + type = "c";
> According to [0], kylin has an A-Type HDMI port - so this should be
> + type = "a";
> > [0] http://rockchip.wikidot.com/kylin
Not sure from the text or do I miss something...
I did look at that board picture before submitting.
Can be wrong, but to me it looks a smaller HDMI connector.
Does anyone have a Kylin picture from a different angle?
Or reference design?
Else apply and fix later? (Heiko ?)
Let me know.
Johan
>
> Regards,
> Alex
>> +
>> + port {
>> + hdmi_con_in: endpoint {
>> + remote-endpoint = <&hdmi_out_con>;
>> + };
>> + };
>> + };
>> +
>> leds: gpio-leds {
>> compatible = "gpio-leds";
>>
>> @@ -110,6 +121,12 @@ &hdmi {
>> status = "okay";
>> };
>>
>> +&hdmi_out {
>> + hdmi_out_con: endpoint {
>> + remote-endpoint = <&hdmi_con_in>;
>> + };
>> +};
>> +
>> &i2c1 {
>> clock-frequency = <400000>;
>>
>> --
>> 2.39.2
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
next prev parent reply other threads:[~2023-12-04 20:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:39 [PATCH v1 1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml Johan Jonker
2023-12-04 17:39 ` Johan Jonker
2023-12-04 17:39 ` Johan Jonker
2023-12-04 17:39 ` Johan Jonker
2023-12-04 17:40 ` [PATCH v1 2/3] ARM: dts: rockchip: rk3036: fix hdmi ports node Johan Jonker
2023-12-04 17:40 ` Johan Jonker
2023-12-04 17:40 ` Johan Jonker
2023-12-04 17:40 ` Johan Jonker
2023-12-04 17:40 ` [PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node Johan Jonker
2023-12-04 17:40 ` Johan Jonker
2023-12-04 17:40 ` Johan Jonker
2023-12-04 17:40 ` Johan Jonker
2023-12-04 19:12 ` Alex Bee
2023-12-04 19:12 ` Alex Bee
2023-12-04 19:12 ` Alex Bee
2023-12-04 19:12 ` Alex Bee
2023-12-04 20:25 ` Johan Jonker [this message]
2023-12-04 20:25 ` Johan Jonker
2023-12-04 20:25 ` Johan Jonker
2023-12-04 20:25 ` Johan Jonker
2023-12-04 18:56 ` [PATCH v1 1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml Alex Bee
2023-12-04 18:56 ` Alex Bee
2023-12-04 18:56 ` Alex Bee
2023-12-04 18:56 ` Alex Bee
2023-12-04 20:47 ` Johan Jonker
2023-12-04 20:47 ` Johan Jonker
2023-12-04 20:47 ` Johan Jonker
2023-12-04 20:47 ` Johan Jonker
2023-12-05 16:55 ` Conor Dooley
2023-12-05 16:55 ` Conor Dooley
2023-12-05 16:55 ` Conor Dooley
2023-12-05 16:55 ` Conor Dooley
2023-12-08 16:44 ` Rob Herring
2023-12-08 16:44 ` Rob Herring
2023-12-08 16:44 ` Rob Herring
2023-12-08 16:44 ` Rob Herring
2023-12-12 20:16 ` (subset) " Heiko Stuebner
2023-12-12 20:16 ` Heiko Stuebner
2023-12-12 20:16 ` Heiko Stuebner
2023-12-12 20:16 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdda61be-8e02-36f5-6261-37d4b75278ba@gmail.com \
--to=jbx6244@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=knaerzche@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.