From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, fabio.estevam@nxp.com, timur@tabi.org,
caleb@crome.org, arnaud.mouiche@invoxia.com, lukma@denx.de,
kernel@pengutronix.de
Subject: Re: [PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings
Date: Wed, 13 Dec 2017 23:30:31 +0100 [thread overview]
Message-ID: <bf6f6d92-ae85-e61f-b027-95189c06916d@maciej.szmigiero.name> (raw)
In-Reply-To: <1513146874-25476-6-git-send-email-nicoleotsuka@gmail.com>
On 13.12.2017 07:34, Nicolin Chen wrote:
> This patch just simply unifies the coding style.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
>
> Changelog
> v1->v2
> * Added two missing indentation changes
> * Removed two extra blank lines.
>
> sound/soc/fsl/fsl_ssi.c | 239 +++++++++++++++++++++-----------------------
> sound/soc/fsl/fsl_ssi.h | 2 +-
> sound/soc/fsl/fsl_ssi_dbg.c | 3 +-
> 3 files changed, 118 insertions(+), 126 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 8b5407d..9a3db08 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
(..)
> @@ -916,12 +917,11 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
> case SND_SOC_DAIFMT_DSP_A:
> /* Data on rising edge of bclk, frame high, 1clk before data */
> strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP |
> - SSI_STCR_TXBIT0 | SSI_STCR_TEFS;
> + SSI_STCR_TXBIT0 | SSI_STCR_TEFS;
> break;
> case SND_SOC_DAIFMT_DSP_B:
> /* Data on rising edge of bclk, frame high */
> - strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP |
> - SSI_STCR_TXBIT0;
> + strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP | SSI_STCR_TXBIT0;
It looks like an extra space got here ^.
Maciej
next prev parent reply other threads:[~2017-12-13 22:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 6:34 [PATCH v2 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-13 6:34 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-13 6:34 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-13 6:34 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-13 22:28 ` Maciej S. Szmigiero
2017-12-13 22:28 ` Maciej S. Szmigiero
2017-12-13 22:36 ` Nicolin Chen
2017-12-13 22:36 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-13 6:34 ` Nicolin Chen
2017-12-13 22:30 ` Maciej S. Szmigiero [this message]
2017-12-13 22:33 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-13 6:34 ` Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Rename cpu_dai parameter to dai" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-13 6:34 ` [PATCH v2 08/11] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-13 6:34 ` [PATCH v2 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen
2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Rename i2smode to i2s_net" to the asoc tree Mark Brown
2017-12-19 10:59 ` Mark Brown
2017-12-13 6:34 ` [PATCH v2 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen
2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Define ternary macros to simplify code" to the asoc tree Mark Brown
2017-12-19 10:59 ` Mark Brown
2017-12-13 22:37 ` [PATCH v2 00/11] ASoC: fsl_ssi: Clean up - coding style level Maciej S. Szmigiero
2017-12-13 22:37 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf6f6d92-ae85-e61f-b027-95189c06916d@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.