Re: [bitbake-devel] [PATCH 1/3] build: Catch and error upon circular task references

["Quentin Schulz" <quentin.schulz@theobroma-systems.com>]

Hi Richard,

On Fri, Sep 10, 2021 at 03:07:38PM +0100, Richard Purdie wrote:
> If there are circular task references, error on them rather than show
> a recursion error. A simple reproducer is:
> 
> """
> do_packageswu () {
>        :
> }
> 
> addtask do_packageswu after do_image_complete before do_image_qa
> """
> 
> into image_types.bbclass. There is code in runqueue to detect these but
> we never get that far with the current codebase.
> 
> [YOCTO #13140]
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  lib/bb/build.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/bb/build.py b/lib/bb/build.py
> index 1e062adb51..4249c0be2b 100644
> --- a/lib/bb/build.py
> +++ b/lib/bb/build.py
> @@ -1034,6 +1034,8 @@ def tasksbetween(task_start, task_end, d):
>      def follow_chain(task, endtask, chain=None):
>          if not chain:
>              chain = []
> +        if task in chain:
> +            bb.fatal("Circular task dependencies as %s depends itself via the chain %s" % (task, " -> ".join(chain)))

depends +on itself?

Cheers,
Quentin