From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/3] build: Catch and error upon circular task references
Date: Fri, 10 Sep 2021 15:54:29 +0100 [thread overview]
Message-ID: <8cc846add7518345e6a948ef11dab6c0c528e14b.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210910144229.osayhx4ewsmtc7cl@fedora>
On Fri, 2021-09-10 at 16:42 +0200, Quentin Schulz wrote:
> Hi Richard,
>
> On Fri, Sep 10, 2021 at 03:07:38PM +0100, Richard Purdie wrote:
> > If there are circular task references, error on them rather than show
> > a recursion error. A simple reproducer is:
> >
> > """
> > do_packageswu () {
> > :
> > }
> >
> > addtask do_packageswu after do_image_complete before do_image_qa
> > """
> >
> > into image_types.bbclass. There is code in runqueue to detect these but
> > we never get that far with the current codebase.
> >
> > [YOCTO #13140]
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > lib/bb/build.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/bb/build.py b/lib/bb/build.py
> > index 1e062adb51..4249c0be2b 100644
> > --- a/lib/bb/build.py
> > +++ b/lib/bb/build.py
> > @@ -1034,6 +1034,8 @@ def tasksbetween(task_start, task_end, d):
> > def follow_chain(task, endtask, chain=None):
> > if not chain:
> > chain = []
> > + if task in chain:
> > + bb.fatal("Circular task dependencies as %s depends itself via the chain %s" % (task, " -> ".join(chain)))
>
> depends +on itself?
Well spotted, tweaked in master-next, thanks.
Cheers,
Richard
prev parent reply other threads:[~2021-09-10 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 14:07 [PATCH 1/3] build: Catch and error upon circular task references Richard Purdie
2021-09-10 14:07 ` [PATCH 2/3] data_smart: Improve error display for handled exceptions Richard Purdie
2021-09-10 14:07 ` [PATCH 3/3] fetch2: Add recursion guard Richard Purdie
2021-09-10 14:48 ` [bitbake-devel] " Quentin Schulz
2021-09-10 14:49 ` Richard Purdie
2021-09-10 14:42 ` [bitbake-devel] [PATCH 1/3] build: Catch and error upon circular task references Quentin Schulz
2021-09-10 14:54 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cc846add7518345e6a948ef11dab6c0c528e14b.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).