archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] npmsw fetcher: Avoid instantiating Fetch class if url list is empty
@ 2023-04-18 20:49 Svend Meyland Nicolaisen
  0 siblings, 0 replies; only message in thread
From: Svend Meyland Nicolaisen @ 2023-04-18 20:49 UTC (permalink / raw)
  To: bitbake-devel; +Cc: Svend Meyland Nicolaisen

Recipes containing both git and npmsw sources in the SRC_URI fail
during fetch from the shrinkwrap. It seems that when the fetcher is
fetching from the shrinkwrap, the SRCREV variable has been deleted but it
till ends up fetching from the git source resulting in an error because
SRCREV is undefined. The root cause of this is that the Fetch class defaults
to urls from the SRC_URI when the urls parameter contains an empty list. This
patch will ensure that Fetch is not instantiated if the urls list is empty.

Signed-off-by: Svend Meyland Nicolaisen <>
 lib/bb/fetch2/ | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/bb/fetch2/ b/lib/bb/fetch2/
index 36fcbfba..cc81100b 100644
--- a/lib/bb/fetch2/
+++ b/lib/bb/fetch2/
@@ -205,7 +205,9 @@ class NpmShrinkWrap(FetchMethod):
         # This fetcher resolves multiple URIs from a shrinkwrap file and then
         # forwards it to a proxy fetcher. The management of the donestamp file,
         # the lockfile and the checksums are forwarded to the proxy fetcher.
-        ud.proxy = Fetch([dep["url"] for dep in ud.deps if dep["url"]], data)
+        shrinkwrap_urls = [dep["url"] for dep in ud.deps if dep["url"]]
+        if shrinkwrap_urls:
+            ud.proxy = Fetch(shrinkwrap_urls, data)
         ud.needdonestamp = False

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-18 20:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 20:49 [PATCH v2] npmsw fetcher: Avoid instantiating Fetch class if url list is empty Svend Meyland Nicolaisen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).