From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: Ross Burton <ross@burtonini.com>, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH v3 4/4] fetch2/wget: fetch securely by default
Date: Wed, 11 Aug 2021 15:46:13 +0200 [thread overview]
Message-ID: <86a39b80-209b-8fc5-7239-ef6cf3541f55@bootlin.com> (raw)
In-Reply-To: <20210810165509.19121-4-ross.burton@arm.com>
Hi Ross,
Thanks for the patches!
On 8/10/21 6:55 PM, Ross Burton wrote:
> From: Ross Burton <ross@burtonini.com>
>
> The days of broken certificates are behind us now, so instead of always
> passing --no-check-certificate to wget, don't pass it by default and
> instead only pass it BB_CHECK_SSL_CERTS = "0".
>
> [ YOCTO #14108 ]
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> .../bitbake-user-manual-fetching.rst | 4 ++++
> .../bitbake-user-manual-ref-variables.rst | 4 ++++
> bitbake/lib/bb/fetch2/wget.py | 19 ++++++++++++++++---
> 3 files changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/bitbake/doc/bitbake-user-manual/bitbake-user-manual-fetching.rst b/bitbake/doc/bitbake-user-manual/bitbake-user-manual-fetching.rst
This patch looks good, but your patches seem to apply to the Poky repo,
not BitBake. Wouldn't be easier for Richard if you submitted patches for
the BitBake repo instead? That's where the patches need to go, if I
understood correctly. Unless there's a workflow I'm not familiar with...
Cheers,
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-08-11 13:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 16:55 [PATCH v3 1/4] utils: add environment updating context manager Ross Burton
2021-08-10 16:55 ` [PATCH v3 2/4] fetch2: expose environment variable names that need to be exported Ross Burton
2021-08-10 16:55 ` [PATCH v3 3/4] fetch2/wget: ensure all variables are set when calling urllib Ross Burton
2021-08-17 17:39 ` [bitbake-devel] " Enrico Scholz
2021-08-17 17:44 ` Enrico Scholz
2021-08-17 18:45 ` Enrico Scholz
2021-08-18 9:28 ` Enrico Scholz
2021-08-18 10:07 ` Ross Burton
2021-08-10 16:55 ` [PATCH v3 4/4] fetch2/wget: fetch securely by default Ross Burton
2021-08-11 13:46 ` Michael Opdenacker [this message]
2021-08-11 15:39 ` [bitbake-devel] " Peter Kjellerstedt
2021-08-13 16:41 ` Ross Burton
2021-08-13 22:00 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a39b80-209b-8fc5-7239-ef6cf3541f55@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=ross@burtonini.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).