From: "Ross Burton" <ross@burtonini.com>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH v3 3/4] fetch2/wget: ensure all variables are set when calling urllib
Date: Wed, 18 Aug 2021 11:07:15 +0100 [thread overview]
Message-ID: <CAAnfSTt+vLN3hHE7aRDBtcO7dbkWEEX_SwAXxc5R5D=SbqvaRA@mail.gmail.com> (raw)
In-Reply-To: <lywnojqeyb.fsf@ensc-virt.intern.sigma-chemnitz.de>
As you've chased this, please send a patch. Apologies, I thought I
checked that all the variables were already checked by the time the
with block closes.
Ross
On Wed, 18 Aug 2021 at 10:28, Enrico Scholz
<enrico.scholz@sigma-chemnitz.de> wrote:
>
> "Enrico Scholz via lists.openembedded.org"
> <enrico.scholz=sigma-chemnitz.de@lists.openembedded.org> writes:
>
> > "Ross Burton" <ross@burtonini.com> writes:
> >
> >> Instead of just exporting the proxy variables when calling into urllib,
> >> use bb.utils.environment() to export all of the known variables that are
> >> needed for proper connectivity.
> >
> > This patch breaks fetching from sstate servers[1].
>
> | --- a/bitbake/lib/bb/fetch2/wget.py
> | +++ b/bitbake/lib/bb/fetch2/wget.py
> | ...
> | + with bb.utils.environment(**newenv):
> | + import ssl
> | ...
> | try:
> | uri = ud.url.split(";")[0]
>
> Moving this 'try' block (with the `opener.open(r)` call) into the 'with'
> context seems to solve the problem.
>
>
>
> Enrico
next prev parent reply other threads:[~2021-08-18 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 16:55 [PATCH v3 1/4] utils: add environment updating context manager Ross Burton
2021-08-10 16:55 ` [PATCH v3 2/4] fetch2: expose environment variable names that need to be exported Ross Burton
2021-08-10 16:55 ` [PATCH v3 3/4] fetch2/wget: ensure all variables are set when calling urllib Ross Burton
2021-08-17 17:39 ` [bitbake-devel] " Enrico Scholz
2021-08-17 17:44 ` Enrico Scholz
2021-08-17 18:45 ` Enrico Scholz
2021-08-18 9:28 ` Enrico Scholz
2021-08-18 10:07 ` Ross Burton [this message]
2021-08-10 16:55 ` [PATCH v3 4/4] fetch2/wget: fetch securely by default Ross Burton
2021-08-11 13:46 ` [bitbake-devel] " Michael Opdenacker
2021-08-11 15:39 ` Peter Kjellerstedt
2021-08-13 16:41 ` Ross Burton
2021-08-13 22:00 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAnfSTt+vLN3hHE7aRDBtcO7dbkWEEX_SwAXxc5R5D=SbqvaRA@mail.gmail.com' \
--to=ross@burtonini.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=enrico.scholz@sigma-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).