Re: [bitbake-devel] [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf

[Changqing Li <changqing.li@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]

Hi, Richard

This patch cause one problem for layerindex.

function init_parser in 
http://git.yoctoproject.org/cgit.cgi/layerindex-web/tree/layerindex/recipeparse.py, 


will setup tinfoil in an temp dir without setting BBLAYERS . This patch 
will make layerindex update failed since setup tinfoil failed.

layerindex setup tinfoil for parsing current target-layer's layer.conf, 
so don't need to set BBLAYERS.

Can we revert this or just report as warning?

Thanks

Changqing

||
On 9/10/21 10:27 PM, Richard Purdie wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> If there is no BBLAYERS set in bblayers.conf show a more helpful
> error and exit.
>
> [YOCTO #14340]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   lib/bb/cookerdata.py | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> index e54858cf02..d6206b7319 100644
> --- a/lib/bb/cookerdata.py
> +++ b/lib/bb/cookerdata.py
> @@ -342,6 +342,9 @@ class CookerDataBuilder(object):
>               layers = (data.getVar('BBLAYERS') or "").split()
>               broken_layers = []
>
> +            if not layers:
> +                bb.fatal("The bblayers.conf file doesn't contain any BBLAYERS definition")
> +
>               data = bb.data.createCopy(data)
>               approved = bb.utils.approved_variables()
>
> --
> 2.32.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#12629): https://lists.openembedded.org/g/bitbake-devel/message/12629
> Mute This Topic: https://lists.openembedded.org/mt/85510606/3616873
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [changqing.li@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

[-- Attachment #2: Type: text/html, Size: 3066 bytes --]