* [PATCH] cookerdata: Improve missing core layer error message
@ 2021-09-10 14:27 Richard Purdie
2021-09-10 14:27 ` [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2021-09-10 14:27 UTC (permalink / raw)
To: bitbake-devel
If the core layer is missing from bblayers.conf, the message the user sees is
hard to understand. Improve it.
[YOCTO #14340]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/cookerdata.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
index 1c1e008c6b..e54858cf02 100644
--- a/lib/bb/cookerdata.py
+++ b/lib/bb/cookerdata.py
@@ -396,6 +396,8 @@ class CookerDataBuilder(object):
if c in collections_tmp:
bb.fatal("Found duplicated BBFILE_COLLECTIONS '%s', check bblayers.conf or layer.conf to fix it." % c)
compat = set((data.getVar("LAYERSERIES_COMPAT_%s" % c) or "").split())
+ if compat and not layerseries:
+ bb.fatal("No core layer found to work with layer '%s'. Missing entry in bblayers.conf?" % c)
if compat and not (compat & layerseries):
bb.fatal("Layer %s is not compatible with the core layer which only supports these series: %s (layer is compatible with %s)"
% (c, " ".join(layerseries), " ".join(compat)))
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf
2021-09-10 14:27 [PATCH] cookerdata: Improve missing core layer error message Richard Purdie
@ 2021-09-10 14:27 ` Richard Purdie
2021-09-27 8:58 ` [bitbake-devel] " Changqing Li
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2021-09-10 14:27 UTC (permalink / raw)
To: bitbake-devel
If there is no BBLAYERS set in bblayers.conf show a more helpful
error and exit.
[YOCTO #14340]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/cookerdata.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
index e54858cf02..d6206b7319 100644
--- a/lib/bb/cookerdata.py
+++ b/lib/bb/cookerdata.py
@@ -342,6 +342,9 @@ class CookerDataBuilder(object):
layers = (data.getVar('BBLAYERS') or "").split()
broken_layers = []
+ if not layers:
+ bb.fatal("The bblayers.conf file doesn't contain any BBLAYERS definition")
+
data = bb.data.createCopy(data)
approved = bb.utils.approved_variables()
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [bitbake-devel] [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf
2021-09-10 14:27 ` [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf Richard Purdie
@ 2021-09-27 8:58 ` Changqing Li
2021-09-29 16:55 ` Mark Hatle
0 siblings, 1 reply; 4+ messages in thread
From: Changqing Li @ 2021-09-27 8:58 UTC (permalink / raw)
To: Richard Purdie, bitbake-devel
[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]
Hi, Richard
This patch cause one problem for layerindex.
function init_parser in
http://git.yoctoproject.org/cgit.cgi/layerindex-web/tree/layerindex/recipeparse.py,
will setup tinfoil in an temp dir without setting BBLAYERS . This patch
will make layerindex update failed since setup tinfoil failed.
layerindex setup tinfoil for parsing current target-layer's layer.conf,
so don't need to set BBLAYERS.
Can we revert this or just report as warning?
Thanks
Changqing
||
On 9/10/21 10:27 PM, Richard Purdie wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> If there is no BBLAYERS set in bblayers.conf show a more helpful
> error and exit.
>
> [YOCTO #14340]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> lib/bb/cookerdata.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> index e54858cf02..d6206b7319 100644
> --- a/lib/bb/cookerdata.py
> +++ b/lib/bb/cookerdata.py
> @@ -342,6 +342,9 @@ class CookerDataBuilder(object):
> layers = (data.getVar('BBLAYERS') or "").split()
> broken_layers = []
>
> + if not layers:
> + bb.fatal("The bblayers.conf file doesn't contain any BBLAYERS definition")
> +
> data = bb.data.createCopy(data)
> approved = bb.utils.approved_variables()
>
> --
> 2.32.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#12629): https://lists.openembedded.org/g/bitbake-devel/message/12629
> Mute This Topic: https://lists.openembedded.org/mt/85510606/3616873
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [changqing.li@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
[-- Attachment #2: Type: text/html, Size: 3066 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bitbake-devel] [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf
2021-09-27 8:58 ` [bitbake-devel] " Changqing Li
@ 2021-09-29 16:55 ` Mark Hatle
0 siblings, 0 replies; 4+ messages in thread
From: Mark Hatle @ 2021-09-29 16:55 UTC (permalink / raw)
To: bitbake-devel
On 9/27/21 3:58 AM, Changqing Li wrote:
> Hi, Richard
>
> This patch cause one problem for layerindex.
>
> function init_parser in
> http://git.yoctoproject.org/cgit.cgi/layerindex-web/tree/layerindex/recipeparse.py,
>
> will setup tinfoil in an temp dir without setting BBLAYERS . This patch will
> make layerindex update failed since setup tinfoil failed.
Does the temp dir need this configured? I believe other parts of the parsing we
do configure things to work with specific default variable definitions.
Defining the branch/release we're looking for seems like the right answer here.
> layerindex setup tinfoil for parsing current target-layer's layer.conf, so don't
> need to set BBLAYERS.
>
> Can we revert this or just report as warning?
It really should be a error. I've ended up accidently doing this before and
it's really painful to debug.
I could see some of the other utilities thought failing here (bitbake-tests or
even bitbake-layers in some cases.)
So I think it's a setup issue within the scope of the layer index parser. It
might be enough to set the name in a variable in the 'if not classic' case to
simulate a properly configured machine. (i.e. BBLAYERS = " " or generate a
dummy layer that does nothing and include it.)
--Mark
> Thanks
>
> Changqing
>
> ||
> On 9/10/21 10:27 PM, Richard Purdie wrote:
>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>
>> If there is no BBLAYERS set in bblayers.conf show a more helpful
>> error and exit.
>>
>> [YOCTO #14340]
>>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>> lib/bb/cookerdata.py | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
>> index e54858cf02..d6206b7319 100644
>> --- a/lib/bb/cookerdata.py
>> +++ b/lib/bb/cookerdata.py
>> @@ -342,6 +342,9 @@ class CookerDataBuilder(object):
>> layers = (data.getVar('BBLAYERS') or "").split()
>> broken_layers = []
>>
>> + if not layers:
>> + bb.fatal("The bblayers.conf file doesn't contain any BBLAYERS definition")
>> +
>> data = bb.data.createCopy(data)
>> approved = bb.utils.approved_variables()
>>
>> --
>> 2.32.0
>>
>>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#12709): https://lists.openembedded.org/g/bitbake-devel/message/12709
> Mute This Topic: https://lists.openembedded.org/mt/85510606/3616948
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [mark.hatle@kernel.crashing.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-29 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 14:27 [PATCH] cookerdata: Improve missing core layer error message Richard Purdie
2021-09-10 14:27 ` [PATCH] cookerdata: Show error for no BBLAYERS in bblayers.conf Richard Purdie
2021-09-27 8:58 ` [bitbake-devel] " Changqing Li
2021-09-29 16:55 ` Mark Hatle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).