[PATCH] MAINTAINERS: XDP: restrict N: and K:

[PATCH] MAINTAINERS: XDP: restrict N: and K:

[Alexander A. Klimov]

Rationale:
Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
which has nothing to do with XDP.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
---
 See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1d4aa7f942de..2bb7feb838af 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
 F:	kernel/bpf/cpumap.c
 F:	kernel/bpf/devmap.c
 F:	net/core/xdp.c
-N:	xdp
-K:	xdp
+N:	(?:\b|_)xdp(?:\b|_)
+K:	(?:\b|_)xdp(?:\b|_)
 
 XDP SOCKETS (AF_XDP)
 M:	Björn Töpel <bjorn.topel@intel.com>
-- 
2.27.0

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Daniel Borkmann]

On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
> Rationale:
> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> which has nothing to do with XDP.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> ---
>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
> 
>   MAINTAINERS | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d4aa7f942de..2bb7feb838af 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
>   F:	kernel/bpf/cpumap.c
>   F:	kernel/bpf/devmap.c
>   F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +N:	(?:\b|_)xdp(?:\b|_)
> +K:	(?:\b|_)xdp(?:\b|_)

Please also include \W to generally match on non-alphanumeric char given you
explicitly want to avoid [a-z0-9] around the term xdp.

>   XDP SOCKETS (AF_XDP)
>   M:	Björn Töpel <bjorn.topel@intel.com>
> 

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Alexander A. Klimov]

Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> Rationale:
>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> which has nothing to do with XDP.
>>
>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>> ---
>>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
>>
>>   MAINTAINERS | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 1d4aa7f942de..2bb7feb838af 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>   F:    kernel/bpf/cpumap.c
>>   F:    kernel/bpf/devmap.c
>>   F:    net/core/xdp.c
>> -N:    xdp
>> -K:    xdp
>> +N:    (?:\b|_)xdp(?:\b|_)
>> +K:    (?:\b|_)xdp(?:\b|_)
> 
> Please also include \W to generally match on non-alphanumeric char given 
> you
> explicitly want to avoid [a-z0-9] around the term xdp.
Aren't \W, ^ and $ already covered by \b?

> 
>>   XDP SOCKETS (AF_XDP)
>>   M:    Björn Töpel <bjorn.topel@intel.com>
>>
> 

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Daniel Borkmann]

On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>>> Rationale:
>>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>>> which has nothing to do with XDP.
>>>
>>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>>> ---
>>>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
>>>
>>>   MAINTAINERS | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 1d4aa7f942de..2bb7feb838af 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>>   F:    kernel/bpf/cpumap.c
>>>   F:    kernel/bpf/devmap.c
>>>   F:    net/core/xdp.c
>>> -N:    xdp
>>> -K:    xdp
>>> +N:    (?:\b|_)xdp(?:\b|_)
>>> +K:    (?:\b|_)xdp(?:\b|_)
>>
>> Please also include \W to generally match on non-alphanumeric char given you
>> explicitly want to avoid [a-z0-9] around the term xdp.
> Aren't \W, ^ and $ already covered by \b?

Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
In case this goes via net or net-next tree:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Joe Perches]

On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
> On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
> > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
> > > > Rationale:
> > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > > > which has nothing to do with XDP.
[]
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
> > > >   F:    kernel/bpf/cpumap.c
> > > >   F:    kernel/bpf/devmap.c
> > > >   F:    net/core/xdp.c
> > > > -N:    xdp
> > > > -K:    xdp
> > > > +N:    (?:\b|_)xdp(?:\b|_)
> > > > +K:    (?:\b|_)xdp(?:\b|_)
> > > 
> > > Please also include \W to generally match on non-alphanumeric char given you
> > > explicitly want to avoid [a-z0-9] around the term xdp.
> > Aren't \W, ^ and $ already covered by \b?
> 
> Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
> In case this goes via net or net-next tree:

This N: pattern does not match files like:

	samples/bpf/xdp1_kern.c

and does match files like:

	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c

Should it?

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Toke Høiland-Jørgensen]

Joe Perches <joe@perches.com> writes:

> On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>> On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>> > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> > > > Rationale:
>> > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> > > > which has nothing to do with XDP.
> []
>> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>> > > >   F:    kernel/bpf/cpumap.c
>> > > >   F:    kernel/bpf/devmap.c
>> > > >   F:    net/core/xdp.c
>> > > > -N:    xdp
>> > > > -K:    xdp
>> > > > +N:    (?:\b|_)xdp(?:\b|_)
>> > > > +K:    (?:\b|_)xdp(?:\b|_)
>> > > 
>> > > Please also include \W to generally match on non-alphanumeric char given you
>> > > explicitly want to avoid [a-z0-9] around the term xdp.
>> > Aren't \W, ^ and $ already covered by \b?
>> 
>> Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>> In case this goes via net or net-next tree:
>
> This N: pattern does not match files like:
>
> 	samples/bpf/xdp1_kern.c
>
> and does match files like:
>
> 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>
> Should it?

I think the idea is that it should match both?

-Toke

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Alexander A. Klimov]

Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
> Joe Perches <joe@perches.com> writes:
> 
>> On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>>> On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>>>> Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>>>>> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>>>>>> Rationale:
>>>>>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>>>>>> which has nothing to do with XDP.
>> []
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>> []
>>>>>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>>>>>    F:    kernel/bpf/cpumap.c
>>>>>>    F:    kernel/bpf/devmap.c
>>>>>>    F:    net/core/xdp.c
>>>>>> -N:    xdp
>>>>>> -K:    xdp
>>>>>> +N:    (?:\b|_)xdp(?:\b|_)
>>>>>> +K:    (?:\b|_)xdp(?:\b|_)
>>>>>
>>>>> Please also include \W to generally match on non-alphanumeric char given you
>>>>> explicitly want to avoid [a-z0-9] around the term xdp.
>>>> Aren't \W, ^ and $ already covered by \b?
>>>
>>> Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>>> In case this goes via net or net-next tree:
>>
>> This N: pattern does not match files like:
>>
>> 	samples/bpf/xdp1_kern.c
>>
>> and does match files like:
>>
>> 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>>
>> Should it?
> 
> I think the idea is that it should match both?
In *your* opinion: Which of these shall it (not) match?

> 
> -Toke
> 

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Joe Perches]

On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote:
> 
> Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
> > Joe Perches <joe@perches.com> writes:
> > 
> > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
> > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> > > > > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
> > > > > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
> > > > > > > Rationale:
> > > > > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > > > > > > which has nothing to do with XDP.
> > > []
> > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > []
> > > > > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
> > > > > > >    F:    kernel/bpf/cpumap.c
> > > > > > >    F:    kernel/bpf/devmap.c
> > > > > > >    F:    net/core/xdp.c
> > > > > > > -N:    xdp
> > > > > > > -K:    xdp
> > > > > > > +N:    (?:\b|_)xdp(?:\b|_)
> > > > > > > +K:    (?:\b|_)xdp(?:\b|_)
> > > > > > 
> > > > > > Please also include \W to generally match on non-alphanumeric char given you
> > > > > > explicitly want to avoid [a-z0-9] around the term xdp.
> > > > > Aren't \W, ^ and $ already covered by \b?
> > > > 
> > > > Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
> > > > In case this goes via net or net-next tree:
> > > 
> > > This N: pattern does not match files like:
> > > 
> > > 	samples/bpf/xdp1_kern.c
> > > 
> > > and does match files like:
> > > 
> > > 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > > 
> > > Should it?
> > 
> > I think the idea is that it should match both?
> In *your* opinion: Which of these shall it (not) match?

Dunno, but it doesn't match these files.
The first 5 are good, the rest probably should.

$ git ls-files | grep xdp | grep -v -P '(?:\b|_)xdp(?:\b|_)'
Documentation/hwmon/xdpe12284.rst
arch/arm/mach-ixp4xx/ixdp425-pci.c
arch/arm/mach-ixp4xx/ixdp425-setup.c
arch/arm/mach-ixp4xx/ixdpg425-pci.c
drivers/hwmon/pmbus/xdpe12284.c
samples/bpf/xdp1_kern.c
samples/bpf/xdp1_user.c
samples/bpf/xdp2_kern.c
samples/bpf/xdp2skb_meta.sh
samples/bpf/xdp2skb_meta_kern.c
samples/bpf/xdpsock.h
samples/bpf/xdpsock_kern.c
samples/bpf/xdpsock_user.c
tools/testing/selftests/bpf/progs/xdping_kern.c
tools/testing/selftests/bpf/test_xdping.sh
tools/testing/selftests/bpf/xdping.c
tools/testing/selftests/bpf/xdping.h

Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

[Toke Høiland-Jørgensen]

Joe Perches <joe@perches.com> writes:

> On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote:
>> 
>> Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
>> > Joe Perches <joe@perches.com> writes:
>> > 
>> > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>> > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>> > > > > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> > > > > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> > > > > > > Rationale:
>> > > > > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> > > > > > > which has nothing to do with XDP.
>> > > []
>> > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
>> > > []
>> > > > > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>> > > > > > >    F:    kernel/bpf/cpumap.c
>> > > > > > >    F:    kernel/bpf/devmap.c
>> > > > > > >    F:    net/core/xdp.c
>> > > > > > > -N:    xdp
>> > > > > > > -K:    xdp
>> > > > > > > +N:    (?:\b|_)xdp(?:\b|_)
>> > > > > > > +K:    (?:\b|_)xdp(?:\b|_)
>> > > > > > 
>> > > > > > Please also include \W to generally match on non-alphanumeric char given you
>> > > > > > explicitly want to avoid [a-z0-9] around the term xdp.
>> > > > > Aren't \W, ^ and $ already covered by \b?
>> > > > 
>> > > > Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>> > > > In case this goes via net or net-next tree:
>> > > 
>> > > This N: pattern does not match files like:
>> > > 
>> > > 	samples/bpf/xdp1_kern.c
>> > > 
>> > > and does match files like:
>> > > 
>> > > 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>> > > 
>> > > Should it?
>> > 
>> > I think the idea is that it should match both?
>> In *your* opinion: Which of these shall it (not) match?
>
> Dunno, but it doesn't match these files.
> The first 5 are good, the rest probably should.

Yup, I agree, all but the first 5 should be matched...

-Toke

> $ git ls-files | grep xdp | grep -v -P '(?:\b|_)xdp(?:\b|_)'
> Documentation/hwmon/xdpe12284.rst
> arch/arm/mach-ixp4xx/ixdp425-pci.c
> arch/arm/mach-ixp4xx/ixdp425-setup.c
> arch/arm/mach-ixp4xx/ixdpg425-pci.c
> drivers/hwmon/pmbus/xdpe12284.c
> samples/bpf/xdp1_kern.c
> samples/bpf/xdp1_user.c
> samples/bpf/xdp2_kern.c
> samples/bpf/xdp2skb_meta.sh
> samples/bpf/xdp2skb_meta_kern.c
> samples/bpf/xdpsock.h
> samples/bpf/xdpsock_kern.c
> samples/bpf/xdpsock_user.c
> tools/testing/selftests/bpf/progs/xdping_kern.c
> tools/testing/selftests/bpf/test_xdping.sh
> tools/testing/selftests/bpf/xdping.c
> tools/testing/selftests/bpf/xdping.h

[PATCH v2] MAINTAINERS: XDP: restrict N: and K:

[Alexander A. Klimov]

Rationale:
Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
which has nothing to do with XDP.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
---
 Better?

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1d4aa7f942de..735e2475e926 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
 F:	kernel/bpf/cpumap.c
 F:	kernel/bpf/devmap.c
 F:	net/core/xdp.c
-N:	xdp
-K:	xdp
+N:	(?:\b|_)xdp
+K:	(?:\b|_)xdp
 
 XDP SOCKETS (AF_XDP)
 M:	Björn Töpel <bjorn.topel@intel.com>
-- 
2.27.0

Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

[Joe Perches]

On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote:
> Rationale:
> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> which has nothing to do with XDP.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> ---
>  Better?
> 
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d4aa7f942de..735e2475e926 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
>  F:	kernel/bpf/cpumap.c
>  F:	kernel/bpf/devmap.c
>  F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +N:	(?:\b|_)xdp
> +K:	(?:\b|_)xdp

Generally, it's better to have comprehensive files lists
rather than adding name matching regexes.

Perhaps:
---
 MAINTAINERS | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 16854e47e8cb..2e96cbf15b31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18763,13 +18763,19 @@ M:	John Fastabend <john.fastabend@gmail.com>
 L:	netdev@vger.kernel.org
 L:	bpf@vger.kernel.org
 S:	Supported
-F:	include/net/xdp.h
+F:	Documentation/networking/af_xdp.rst
+F:	include/net/xdp*
 F:	include/trace/events/xdp.h
+F:	include/uapi/linux/if_xdp.h
+F:	include/uapi/linux/xdp_diag.h
 F:	kernel/bpf/cpumap.c
 F:	kernel/bpf/devmap.c
 F:	net/core/xdp.c
-N:	xdp
-K:	xdp
+F:	net/xdp/
+F:	samples/bpf/xdp*
+F:	tools/testing/selftests/bfp/*xdp*
+F:	tools/testing/selftests/bfp/*/*xdp*
+K:	(?:\b|_)xdp(?:\b|_)
 
 XDP SOCKETS (AF_XDP)
 M:	Björn Töpel <bjorn.topel@intel.com>

Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

[Jesper Dangaard Brouer]

On Fri, 10 Jul 2020 12:37:47 -0700
Joe Perches <joe@perches.com> wrote:

> On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote:
> > Rationale:
> > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > which has nothing to do with XDP.
> > 
> > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> > ---
> >  Better?
> > 
> >  MAINTAINERS | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1d4aa7f942de..735e2475e926 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
> >  F:	kernel/bpf/cpumap.c
> >  F:	kernel/bpf/devmap.c
> >  F:	net/core/xdp.c
> > -N:	xdp
> > -K:	xdp
> > +N:	(?:\b|_)xdp
> > +K:	(?:\b|_)xdp  
> 
> Generally, it's better to have comprehensive files lists
> rather than adding name matching regexes.

I like below more direct matching of the files we already know are XDP
related. The pattern match are meant to catch drivers containing XDP
related bits.

(small typo in your patch below)

> Perhaps:
> ---
>  MAINTAINERS | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 16854e47e8cb..2e96cbf15b31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18763,13 +18763,19 @@ M:	John Fastabend <john.fastabend@gmail.com>
>  L:	netdev@vger.kernel.org
>  L:	bpf@vger.kernel.org
>  S:	Supported
> -F:	include/net/xdp.h
> +F:	Documentation/networking/af_xdp.rst
> +F:	include/net/xdp*
>  F:	include/trace/events/xdp.h
> +F:	include/uapi/linux/if_xdp.h
> +F:	include/uapi/linux/xdp_diag.h
>  F:	kernel/bpf/cpumap.c
>  F:	kernel/bpf/devmap.c
>  F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +F:	net/xdp/
> +F:	samples/bpf/xdp*
> +F:	tools/testing/selftests/bfp/*xdp*
                               ^^^^ 
Typo, should be "bpf"

> +F:	tools/testing/selftests/bfp/*/*xdp*
> +K:	(?:\b|_)xdp(?:\b|_)
>  
>  XDP SOCKETS (AF_XDP)
>  M:	Björn Töpel <bjorn.topel@intel.com>
> 



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

[Joe Perches]

On Sat, 2020-07-11 at 10:23 +0200, Jesper Dangaard Brouer wrote:
> On Fri, 10 Jul 2020 12:37:47 -0700
> Joe Perches <joe@perches.com> wrote:
> 
> > On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote:
> > > Rationale:
> > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > > which has nothing to do with XDP.
> > > 
> > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> > > ---
> > >  Better?
> > > 
> > >  MAINTAINERS | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 1d4aa7f942de..735e2475e926 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
> > >  F:	kernel/bpf/cpumap.c
> > >  F:	kernel/bpf/devmap.c
> > >  F:	net/core/xdp.c
> > > -N:	xdp
> > > -K:	xdp
> > > +N:	(?:\b|_)xdp
> > > +K:	(?:\b|_)xdp  
> > 
> > Generally, it's better to have comprehensive files lists
> > rather than adding name matching regexes.
> 
> I like below more direct matching of the files we already know are XDP
> related. The pattern match are meant to catch drivers containing XDP
> related bits.

That's what the K: entry is for no?

Anyway, if you agree with using the appropriate F: patterns,
please submit it.  I'm not going to.

> (small typo in your patch below)
> 
> > Perhaps:
> > ---
> >  MAINTAINERS | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 16854e47e8cb..2e96cbf15b31 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18763,13 +18763,19 @@ M:	John Fastabend <john.fastabend@gmail.com>
> >  L:	netdev@vger.kernel.org
> >  L:	bpf@vger.kernel.org
> >  S:	Supported
> > -F:	include/net/xdp.h
> > +F:	Documentation/networking/af_xdp.rst
> > +F:	include/net/xdp*
> >  F:	include/trace/events/xdp.h
> > +F:	include/uapi/linux/if_xdp.h
> > +F:	include/uapi/linux/xdp_diag.h
> >  F:	kernel/bpf/cpumap.c
> >  F:	kernel/bpf/devmap.c
> >  F:	net/core/xdp.c
> > -N:	xdp
> > -K:	xdp
> > +F:	net/xdp/
> > +F:	samples/bpf/xdp*
> > +F:	tools/testing/selftests/bfp/*xdp*
>                                ^^^^ 
> Typo, should be "bpf"
> 
> > +F:	tools/testing/selftests/bfp/*/*xdp*
> > +K:	(?:\b|_)xdp(?:\b|_)
> >  
> >  XDP SOCKETS (AF_XDP)
> >  M:	Björn Töpel <bjorn.topel@intel.com>
> > 
> 
>