From: Daniel Borkmann <daniel@iogearbox.net>
To: Hechao Li <hechaol@fb.com>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, ast@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next] selftests/bpf : clean up feature/ when make clean
Date: Tue, 11 Jun 2019 10:54:32 +0200 [thread overview]
Message-ID: <0ef29619-baec-64c7-f64a-c7f61e2f8d5b@iogearbox.net> (raw)
In-Reply-To: <20190611004307.3774913-1-hechaol@fb.com>
On 06/11/2019 02:43 AM, Hechao Li wrote:
> An error "implicit declaration of function 'reallocarray'" can be thrown
> with the following steps:
>
> $ cd tools/testing/selftests/bpf
> $ make clean && make CC=<Path to GCC 4.8.5>
> $ make clean && make CC=<Path to GCC 7.x>
>
> The cause is that the feature folder generated by GCC 4.8.5 is not
> removed, leaving feature-reallocarray being 1, which causes reallocarray
> not defined when re-compliing with GCC 7.x. This diff adds feature
> folder to EXTRA_CLEAN to avoid this problem.
>
> v2: Rephrase the commit message.
>
> Signed-off-by: Hechao Li <hechaol@fb.com>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
Applied, thanks!
prev parent reply other threads:[~2019-06-11 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 0:43 [PATCH v2 bpf-next] selftests/bpf : clean up feature/ when make clean Hechao Li
2019-06-11 8:54 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef29619-baec-64c7-f64a-c7f61e2f8d5b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hechaol@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).