From: Yonghong Song <yhs@fb.com>
To: Haowen Bai <baihaowen@meizu.com>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] selftests/bpf: Fix warning comparing pointer to 0
Date: Tue, 29 Mar 2022 20:16:08 -0700 [thread overview]
Message-ID: <11f618a9-7710-d235-bbec-5554b27512e2@fb.com> (raw)
In-Reply-To: <1648605588-19269-1-git-send-email-baihaowen@meizu.com>
On 3/29/22 6:59 PM, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
>
> reported by coccicheck:
> tools/testing/selftests/bpf/progs/map_ptr_kern.c:370:21-22:
> WARNING comparing pointer to 0
> tools/testing/selftests/bpf/progs/map_ptr_kern.c:397:21-22:
> WARNING comparing pointer to 0
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2022-03-30 3:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 2:08 [PATCH] selftests/bpf: Fix warning comparing pointer to 0 Haowen Bai
2022-03-24 20:28 ` Martin KaFai Lau
2022-03-25 1:15 ` 答复: " 白浩文
2022-03-25 19:55 ` Shuah Khan
2022-03-30 1:59 ` [PATCH V2] " Haowen Bai
2022-03-30 3:16 ` Yonghong Song [this message]
2022-03-30 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f618a9-7710-d235-bbec-5554b27512e2@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=baihaowen@meizu.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).