* [PATCH] bpf: Simplify the calculation of variables
@ 2021-03-03 7:20 Jiapeng Chong
2021-03-03 7:31 ` Yonghong Song
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-03 7:20 UTC (permalink / raw)
To: ast
Cc: daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, netdev, bpf, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./tools/bpf/bpf_dbg.c:1201:55-57: WARNING !A || A && B is equivalent to
!A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
tools/bpf/bpf_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/bpf_dbg.c b/tools/bpf/bpf_dbg.c
index a07dfc4..00e560a 100644
--- a/tools/bpf/bpf_dbg.c
+++ b/tools/bpf/bpf_dbg.c
@@ -1198,7 +1198,7 @@ static int cmd_run(char *num)
else
return CMD_OK;
bpf_reset();
- } while (pcap_next_pkt() && (!has_limit || (has_limit && ++i < pkts)));
+ } while (pcap_next_pkt() && (!has_limit || (++i < pkts)));
rl_printf("bpf passes:%u fails:%u\n", pass, fail);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bpf: Simplify the calculation of variables
2021-03-03 7:20 [PATCH] bpf: Simplify the calculation of variables Jiapeng Chong
@ 2021-03-03 7:31 ` Yonghong Song
0 siblings, 0 replies; 2+ messages in thread
From: Yonghong Song @ 2021-03-03 7:31 UTC (permalink / raw)
To: Jiapeng Chong, ast
Cc: daniel, andrii, kafai, songliubraving, john.fastabend, kpsingh,
netdev, bpf, linux-kernel
On 3/2/21 11:20 PM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./tools/bpf/bpf_dbg.c:1201:55-57: WARNING !A || A && B is equivalent to
> !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Yonghong Song <yhs@fb.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-03 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 7:20 [PATCH] bpf: Simplify the calculation of variables Jiapeng Chong
2021-03-03 7:31 ` Yonghong Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).