* [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
@ 2021-02-12 1:00 Stanislav Fomichev
2021-02-12 19:48 ` Andrii Nakryiko
2021-02-12 21:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 6+ messages in thread
From: Stanislav Fomichev @ 2021-02-12 1:00 UTC (permalink / raw)
To: netdev, bpf; +Cc: ast, daniel, Stanislav Fomichev
There is what I see after compiling the kernel:
# bpf-next...bpf-next/master
?? tools/bpf/resolve_btfids/libbpf/
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
tools/bpf/resolve_btfids/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 25f308c933cc..16913fffc985 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,2 +1,3 @@
/fixdep
/resolve_btfids
+/libbpf/
--
2.30.0.478.g8a0d178c01-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
2021-02-12 1:00 [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore Stanislav Fomichev
@ 2021-02-12 19:48 ` Andrii Nakryiko
2021-02-12 19:56 ` Stanislav Fomichev
2021-02-12 21:04 ` Jiri Olsa
2021-02-12 21:10 ` patchwork-bot+netdevbpf
1 sibling, 2 replies; 6+ messages in thread
From: Andrii Nakryiko @ 2021-02-12 19:48 UTC (permalink / raw)
To: Stanislav Fomichev; +Cc: Networking, bpf, Alexei Starovoitov, Daniel Borkmann
On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev <sdf@google.com> wrote:
>
> There is what I see after compiling the kernel:
typo: This?
>
> # bpf-next...bpf-next/master
> ?? tools/bpf/resolve_btfids/libbpf/
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
Jiri,
Is this
Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
in separate directories")
?
Do we need similar stuff for libsubcmd (what's that, btw?)
> tools/bpf/resolve_btfids/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> index 25f308c933cc..16913fffc985 100644
> --- a/tools/bpf/resolve_btfids/.gitignore
> +++ b/tools/bpf/resolve_btfids/.gitignore
> @@ -1,2 +1,3 @@
> /fixdep
> /resolve_btfids
> +/libbpf/
> --
> 2.30.0.478.g8a0d178c01-goog
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
2021-02-12 19:48 ` Andrii Nakryiko
@ 2021-02-12 19:56 ` Stanislav Fomichev
2021-02-12 21:05 ` Jiri Olsa
2021-02-12 21:04 ` Jiri Olsa
1 sibling, 1 reply; 6+ messages in thread
From: Stanislav Fomichev @ 2021-02-12 19:56 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: Networking, bpf, Alexei Starovoitov, Daniel Borkmann, jolsa
On Fri, Feb 12, 2021 at 11:48 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > There is what I see after compiling the kernel:
>
> typo: This?
Yes, sure.
> > # bpf-next...bpf-next/master
> > ?? tools/bpf/resolve_btfids/libbpf/
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > ---
>
> Jiri,
>
> Is this
>
> Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
> in separate directories")
>
> ?
>
> Do we need similar stuff for libsubcmd (what's that, btw?)
It's probably not needed because it has only .o files in there (.o are
ignored in the root .gitignore).
I assume libbpf/ has an issue because there is bpf_helper_defs.h in
that libbpf/ directory.
Not sure why it was removed in fc6b48f692f8 rather than being prefixed
with libbpf/ directory.
I'll leave it up to Jiri to comment.
> > tools/bpf/resolve_btfids/.gitignore | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> > index 25f308c933cc..16913fffc985 100644
> > --- a/tools/bpf/resolve_btfids/.gitignore
> > +++ b/tools/bpf/resolve_btfids/.gitignore
> > @@ -1,2 +1,3 @@
> > /fixdep
> > /resolve_btfids
> > +/libbpf/
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
2021-02-12 19:48 ` Andrii Nakryiko
2021-02-12 19:56 ` Stanislav Fomichev
@ 2021-02-12 21:04 ` Jiri Olsa
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Olsa @ 2021-02-12 21:04 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: Stanislav Fomichev, Networking, bpf, Alexei Starovoitov, Daniel Borkmann
On Fri, Feb 12, 2021 at 11:48:46AM -0800, Andrii Nakryiko wrote:
> On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > There is what I see after compiling the kernel:
>
> typo: This?
>
> >
> > # bpf-next...bpf-next/master
> > ?? tools/bpf/resolve_btfids/libbpf/
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > ---
>
> Jiri,
>
> Is this
>
> Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
> in separate directories")
yes
>
> ?
>
> Do we need similar stuff for libsubcmd (what's that, btw?)
as Stanislav said it's only .o files in there, so there's no need
it provides the parse_options functionality
jirka
>
> > tools/bpf/resolve_btfids/.gitignore | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> > index 25f308c933cc..16913fffc985 100644
> > --- a/tools/bpf/resolve_btfids/.gitignore
> > +++ b/tools/bpf/resolve_btfids/.gitignore
> > @@ -1,2 +1,3 @@
> > /fixdep
> > /resolve_btfids
> > +/libbpf/
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
2021-02-12 19:56 ` Stanislav Fomichev
@ 2021-02-12 21:05 ` Jiri Olsa
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Olsa @ 2021-02-12 21:05 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: Andrii Nakryiko, Networking, bpf, Alexei Starovoitov,
Daniel Borkmann, jolsa
On Fri, Feb 12, 2021 at 11:56:29AM -0800, Stanislav Fomichev wrote:
> On Fri, Feb 12, 2021 at 11:48 AM Andrii Nakryiko
> <andrii.nakryiko@gmail.com> wrote:
> >
> > On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev <sdf@google.com> wrote:
> > >
> > > There is what I see after compiling the kernel:
> >
> > typo: This?
> Yes, sure.
>
>
> > > # bpf-next...bpf-next/master
> > > ?? tools/bpf/resolve_btfids/libbpf/
> > >
> > > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > > ---
> >
> > Jiri,
> >
> > Is this
> >
> > Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
> > in separate directories")
> >
> > ?
> >
> > Do we need similar stuff for libsubcmd (what's that, btw?)
> It's probably not needed because it has only .o files in there (.o are
> ignored in the root .gitignore).
> I assume libbpf/ has an issue because there is bpf_helper_defs.h in
> that libbpf/ directory.
> Not sure why it was removed in fc6b48f692f8 rather than being prefixed
> with libbpf/ directory.
> I'll leave it up to Jiri to comment.
you're right, thanks for the fix
jirka
>
>
> > > tools/bpf/resolve_btfids/.gitignore | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> > > index 25f308c933cc..16913fffc985 100644
> > > --- a/tools/bpf/resolve_btfids/.gitignore
> > > +++ b/tools/bpf/resolve_btfids/.gitignore
> > > @@ -1,2 +1,3 @@
> > > /fixdep
> > > /resolve_btfids
> > > +/libbpf/
> > > --
> > > 2.30.0.478.g8a0d178c01-goog
> > >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
2021-02-12 1:00 [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore Stanislav Fomichev
2021-02-12 19:48 ` Andrii Nakryiko
@ 2021-02-12 21:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-12 21:10 UTC (permalink / raw)
To: Stanislav Fomichev; +Cc: netdev, bpf, ast, daniel
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Thu, 11 Feb 2021 17:00:53 -0800 you wrote:
> There is what I see after compiling the kernel:
>
> # bpf-next...bpf-next/master
> ?? tools/bpf/resolve_btfids/libbpf/
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
>
> [...]
Here is the summary with links:
- [bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
https://git.kernel.org/bpf/bpf-next/c/90a82b1fa40d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-12 21:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 1:00 [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore Stanislav Fomichev
2021-02-12 19:48 ` Andrii Nakryiko
2021-02-12 19:56 ` Stanislav Fomichev
2021-02-12 21:05 ` Jiri Olsa
2021-02-12 21:04 ` Jiri Olsa
2021-02-12 21:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).