* [PATCH bpf-next] tools/bpftool: Avoid using "?:" in generated code
@ 2021-09-28 18:42 Yucong Sun
2021-09-28 22:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yucong Sun @ 2021-09-28 18:42 UTC (permalink / raw)
To: bpf; +Cc: andrii, sunyucong, Yucong Sun
"?:" is a GNU C extension, some environment has warning flags for its
use, or even prohibit it directly. This patch avoid triggering these
problems by simply expand it to its full form, no functionality change.
Signed-off-by: Yucong Sun <fallentree@fb.com>
---
tools/bpf/bpftool/gen.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c
index e3ec47a6a612..cc835859465b 100644
--- a/tools/bpf/bpftool/gen.c
+++ b/tools/bpf/bpftool/gen.c
@@ -803,7 +803,10 @@ static int do_skeleton(int argc, char **argv)
} \n\
\n\
err = %1$s__create_skeleton(obj); \n\
- err = err ?: bpf_object__open_skeleton(obj->skeleton, opts);\n\
+ if (err) \n\
+ goto err_out; \n\
+ \n\
+ err = bpf_object__open_skeleton(obj->skeleton, opts);\n\
if (err) \n\
goto err_out; \n\
\n\
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] tools/bpftool: Avoid using "?:" in generated code
2021-09-28 18:42 [PATCH bpf-next] tools/bpftool: Avoid using "?:" in generated code Yucong Sun
@ 2021-09-28 22:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-28 22:30 UTC (permalink / raw)
To: Yucong Sun; +Cc: bpf, andrii, sunyucong
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Tue, 28 Sep 2021 11:42:21 -0700 you wrote:
> "?:" is a GNU C extension, some environment has warning flags for its
> use, or even prohibit it directly. This patch avoid triggering these
> problems by simply expand it to its full form, no functionality change.
>
> Signed-off-by: Yucong Sun <fallentree@fb.com>
> ---
> tools/bpf/bpftool/gen.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Here is the summary with links:
- [bpf-next] tools/bpftool: Avoid using "?:" in generated code
https://git.kernel.org/bpf/bpf-next/c/09710d82c0a3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-28 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 18:42 [PATCH bpf-next] tools/bpftool: Avoid using "?:" in generated code Yucong Sun
2021-09-28 22:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).